Re: [PATCH 1/2] dt-bindings/phy: ingenic: Add compatibles for JZ4760(B) SoCs

[Rob Herring <robh+dt@kernel.org>]

On Wed, Jan 20, 2021 at 5:59 AM Paul Cercueil <paul@crapouillou.net> wrote:
>
> Add the ingenic,jz4760-phy and ingenic,jz4760b-phy compatible strings,
> and make the ingenic,jz4770-phy compatible string require
> ingenic,jz4760-phy as a fallback, since both work the same, and the
> JZ4760 SoC is older.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  .../bindings/phy/ingenic,phy-usb.yaml         | 22 ++++++++++++-------
>  1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> index 0fd93d71fe5a..3c65dfcf352b 100644
> --- a/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> +++ b/Documentation/devicetree/bindings/phy/ingenic,phy-usb.yaml
> @@ -15,13 +15,19 @@ properties:
>      pattern: '^usb-phy@.*'
>
>    compatible:
> -    enum:
> -      - ingenic,jz4770-phy
> -      - ingenic,jz4775-phy
> -      - ingenic,jz4780-phy
> -      - ingenic,x1000-phy
> -      - ingenic,x1830-phy
> -      - ingenic,x2000-phy
> +    oneOf:
> +      - enum:
> +        - ingenic,jz4760-phy

This should be 2 more spaces indentation. Indent is always 2 more than
the above keyword and ignores '-'.

> +        - ingenic,jz4775-phy
> +        - ingenic,jz4780-phy
> +        - ingenic,x1000-phy
> +        - ingenic,x1830-phy
> +        - ingenic,x2000-phy
> +      - items:
> +        - enum:
> +          - ingenic,jz4760b-phy
> +          - ingenic,jz4770-phy
> +        - const: ingenic,jz4760-phy
>
>    reg:
>      maxItems: 1
> @@ -48,7 +54,7 @@ examples:
>    - |
>      #include <dt-bindings/clock/jz4770-cgu.h>
>      otg_phy: usb-phy@3c {
> -      compatible = "ingenic,jz4770-phy";
> +      compatible = "ingenic,jz4770-phy", "ingenic,jz4760-phy";
>        reg = <0x3c 0x10>;
>
>        vcc-supply = <&vcc>;
> --
> 2.29.2
>