* [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init
2021-01-23 17:32 [PATCH 0/2] net: usbnet: convert to new tasklet API Emil Renner Berthing
@ 2021-01-23 17:32 ` Emil Renner Berthing
2021-02-01 10:36 ` Oliver Neukum
2021-01-23 17:32 ` [PATCH 2/2] net: usbnet: use new tasklet API Emil Renner Berthing
2021-01-27 2:10 ` [PATCH 0/2] net: usbnet: convert to " patchwork-bot+netdevbpf
2 siblings, 1 reply; 6+ messages in thread
From: Emil Renner Berthing @ 2021-01-23 17:32 UTC (permalink / raw)
To: linux-usb, netdev
Cc: Emil Renner Berthing, Oliver Neukum, David S. Miller,
Jakub Kicinski, linux-kernel
From: Emil Renner Berthing <kernel@esmil.dk>
Initialize tasklet using tasklet_init() rather than open-coding it.
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
---
drivers/net/usb/usbnet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 1447da1d5729..26455c76588f 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1673,8 +1673,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
skb_queue_head_init (&dev->txq);
skb_queue_head_init (&dev->done);
skb_queue_head_init(&dev->rxq_pause);
- dev->bh.func = usbnet_bh_tasklet;
- dev->bh.data = (unsigned long)&dev->delay;
+ tasklet_init(&dev->bh, usbnet_bh_tasklet, (unsigned long)&dev->delay);
INIT_WORK (&dev->kevent, usbnet_deferred_kevent);
init_usb_anchor(&dev->deferred);
timer_setup(&dev->delay, usbnet_bh, 0);
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] net: usbnet: use new tasklet API
2021-01-23 17:32 [PATCH 0/2] net: usbnet: convert to new tasklet API Emil Renner Berthing
2021-01-23 17:32 ` [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init Emil Renner Berthing
@ 2021-01-23 17:32 ` Emil Renner Berthing
2021-02-01 10:36 ` Oliver Neukum
2021-01-27 2:10 ` [PATCH 0/2] net: usbnet: convert to " patchwork-bot+netdevbpf
2 siblings, 1 reply; 6+ messages in thread
From: Emil Renner Berthing @ 2021-01-23 17:32 UTC (permalink / raw)
To: linux-usb, netdev
Cc: Emil Renner Berthing, Oliver Neukum, David S. Miller,
Jakub Kicinski, linux-kernel
From: Emil Renner Berthing <kernel@esmil.dk>
This converts the driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
---
drivers/net/usb/usbnet.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 26455c76588f..e3f1b419a98f 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1539,11 +1539,11 @@ static void usbnet_bh (struct timer_list *t)
}
}
-static void usbnet_bh_tasklet(unsigned long data)
+static void usbnet_bh_tasklet(struct tasklet_struct *t)
{
- struct timer_list *t = (struct timer_list *)data;
+ struct usbnet *dev = from_tasklet(dev, t, bh);
- usbnet_bh(t);
+ usbnet_bh(&dev->delay);
}
@@ -1673,7 +1673,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
skb_queue_head_init (&dev->txq);
skb_queue_head_init (&dev->done);
skb_queue_head_init(&dev->rxq_pause);
- tasklet_init(&dev->bh, usbnet_bh_tasklet, (unsigned long)&dev->delay);
+ tasklet_setup(&dev->bh, usbnet_bh_tasklet);
INIT_WORK (&dev->kevent, usbnet_deferred_kevent);
init_usb_anchor(&dev->deferred);
timer_setup(&dev->delay, usbnet_bh, 0);
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] net: usbnet: use new tasklet API
2021-01-23 17:32 ` [PATCH 2/2] net: usbnet: use new tasklet API Emil Renner Berthing
@ 2021-02-01 10:36 ` Oliver Neukum
0 siblings, 0 replies; 6+ messages in thread
From: Oliver Neukum @ 2021-02-01 10:36 UTC (permalink / raw)
To: Emil Renner Berthing, linux-usb, netdev
Cc: Emil Renner Berthing, David S. Miller, Jakub Kicinski, linux-kernel
Am Samstag, den 23.01.2021, 18:32 +0100 schrieb Emil Renner Berthing:
> From: Emil Renner Berthing <kernel@esmil.dk>
>
> This converts the driver to use the new tasklet API introduced in
> commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
>
> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Acked-by: Oliver Neukum <oneukum@suse.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] net: usbnet: convert to new tasklet API
2021-01-23 17:32 [PATCH 0/2] net: usbnet: convert to new tasklet API Emil Renner Berthing
2021-01-23 17:32 ` [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init Emil Renner Berthing
2021-01-23 17:32 ` [PATCH 2/2] net: usbnet: use new tasklet API Emil Renner Berthing
@ 2021-01-27 2:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-27 2:10 UTC (permalink / raw)
To: Emil Renner Berthing
Cc: linux-usb, netdev, kernel, oneukum, davem, kuba, linux-kernel
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sat, 23 Jan 2021 18:32:19 +0100 you wrote:
> From: Emil Renner Berthing <kernel@esmil.dk>
>
> This converts the usbnet driver to use the new tasklet API introduced in
> commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
>
> It is split into two commits for ease of reviewing.
>
> [...]
Here is the summary with links:
- [1/2] net: usbnet: initialize tasklet using tasklet_init
https://git.kernel.org/netdev/net-next/c/90a586b8d741
- [2/2] net: usbnet: use new tasklet API
https://git.kernel.org/netdev/net-next/c/c955e329bb9d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread