From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 4/4] tracing: Remove NULL check from current in tracing_generic_entry_update().
Date: Mon, 25 Jan 2021 20:45:11 +0100 [thread overview]
Message-ID: <20210125194511.3924915-5-bigeasy@linutronix.de> (raw)
In-Reply-To: <20210125194511.3924915-1-bigeasy@linutronix.de>
I can't imagine when or why `current' would return a NULL pointer. This
check was added in commit
72829bc3d63cd ("ftrace: move enums to ftrace.h and make helper function global")
but it doesn't give me hint why it was needed.
Assume `current' never returns a NULL pointer and remove the check.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/linux/trace_events.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 67ae708de40d6..5d1eeac4bfbea 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -152,10 +152,8 @@ static inline void tracing_generic_entry_update(struct trace_entry *entry,
unsigned short type,
unsigned int trace_ctx)
{
- struct task_struct *tsk = current;
-
entry->preempt_count = trace_ctx & 0xff;
- entry->pid = (tsk) ? tsk->pid : 0;
+ entry->pid = current->pid;
entry->type = type;
entry->flags = trace_ctx >> 16;
}
--
2.30.0
next prev parent reply other threads:[~2021-01-25 21:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 23:00 [PATCH 0/3] tracing: Merge irqflags + preempt counter Sebastian Andrzej Siewior
2021-01-12 23:00 ` [PATCH 1/3] " Sebastian Andrzej Siewior
2021-01-22 22:07 ` Steven Rostedt
2021-01-25 14:05 ` Sebastian Andrzej Siewior
2021-01-25 19:03 ` Steven Rostedt
2021-01-25 19:45 ` [PATCH 0/4 v2] " Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 1/4] " Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 2/4] tracing: Inline tracing_gen_ctx_flags() Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 3/4] tracing: Use in_serving_softirq() to deduct softirq status Sebastian Andrzej Siewior
2021-01-25 19:45 ` Sebastian Andrzej Siewior [this message]
2021-02-01 18:23 ` [PATCH 0/4 v2] tracing: Merge irqflags + preempt counter Sebastian Andrzej Siewior
2021-02-01 18:32 ` Steven Rostedt
2021-02-01 18:34 ` Sebastian Andrzej Siewior
2021-01-25 19:52 ` [PATCH 1/3] " Sebastian Andrzej Siewior
2021-01-25 19:55 ` Steven Rostedt
2021-01-12 23:00 ` [PATCH 2/3] tracing: Use in_serving_softirq() to deduct softirq status Sebastian Andrzej Siewior
2021-01-22 22:11 ` Steven Rostedt
2021-01-12 23:00 ` [PATCH 3/3] tracing: Remove NULL check from current in tracing_generic_entry_update() Sebastian Andrzej Siewior
2021-01-22 22:12 ` Steven Rostedt
2021-01-22 22:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125194511.3924915-5-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).