From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/3] tracing: Merge irqflags + preempt counter.
Date: Mon, 25 Jan 2021 20:52:28 +0100 [thread overview]
Message-ID: <20210125195228.ydtrixn4v3hb4lmj@linutronix.de> (raw)
In-Reply-To: <20210125140323.6b1ff20c@gandalf.local.home>
On 2021-01-25 14:03:23 [-0500], Steven Rostedt wrote:
>
> I was thinking about the inlining for two reasons. One was to consolidate
> the logic in the header file, as they are small functions. And two, inlined
> functions tend to be faster than non-inlined functions. Thus, I wasn't
> looking at this from a size point of view, but since this is called by all
> events, including function tracer, being efficient is a requirement.
In the ftrace_syscall_enter() example I made, flags were not evaluated
three times but only once. This should do more in terms of performance
compare to simply inline it.
> > I can post the irqflags-merge and the inlinining as two seprate patches
> > and you can then decide if you merge the two patches or drop the
> > inlining.
>
> Feel free to send it as separate patches. I'd like to have the inlining.
Just sent as an extra patch. In case you have a benchmark, I'm curious
;)
> Thanks!
>
> -- Steve
Sebastian
next prev parent reply other threads:[~2021-01-25 20:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 23:00 [PATCH 0/3] tracing: Merge irqflags + preempt counter Sebastian Andrzej Siewior
2021-01-12 23:00 ` [PATCH 1/3] " Sebastian Andrzej Siewior
2021-01-22 22:07 ` Steven Rostedt
2021-01-25 14:05 ` Sebastian Andrzej Siewior
2021-01-25 19:03 ` Steven Rostedt
2021-01-25 19:45 ` [PATCH 0/4 v2] " Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 1/4] " Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 2/4] tracing: Inline tracing_gen_ctx_flags() Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 3/4] tracing: Use in_serving_softirq() to deduct softirq status Sebastian Andrzej Siewior
2021-01-25 19:45 ` [PATCH 4/4] tracing: Remove NULL check from current in tracing_generic_entry_update() Sebastian Andrzej Siewior
2021-02-01 18:23 ` [PATCH 0/4 v2] tracing: Merge irqflags + preempt counter Sebastian Andrzej Siewior
2021-02-01 18:32 ` Steven Rostedt
2021-02-01 18:34 ` Sebastian Andrzej Siewior
2021-01-25 19:52 ` Sebastian Andrzej Siewior [this message]
2021-01-25 19:55 ` [PATCH 1/3] " Steven Rostedt
2021-01-12 23:00 ` [PATCH 2/3] tracing: Use in_serving_softirq() to deduct softirq status Sebastian Andrzej Siewior
2021-01-22 22:11 ` Steven Rostedt
2021-01-12 23:00 ` [PATCH 3/3] tracing: Remove NULL check from current in tracing_generic_entry_update() Sebastian Andrzej Siewior
2021-01-22 22:12 ` Steven Rostedt
2021-01-22 22:16 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125195228.ydtrixn4v3hb4lmj@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).