* [PATCH 1/2] byteorder: fix -Wsign-compare warnings
@ 2021-01-26 2:31 Jeffle Xu
2021-01-26 2:31 ` [PATCH 2/2] thread_info: " Jeffle Xu
0 siblings, 1 reply; 2+ messages in thread
From: Jeffle Xu @ 2021-01-26 2:31 UTC (permalink / raw)
To: linux-kernel; +Cc: lkp, joseph.qi, caspar
warning: comparison of integers of different signs: 'int' and 'size_t'
(aka 'unsigned long') [-Wsign-compare]
for (i = 0; i < len; i++)
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
include/linux/byteorder/generic.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
index 4b13e0a3e15b..c9a4c96c9943 100644
--- a/include/linux/byteorder/generic.h
+++ b/include/linux/byteorder/generic.h
@@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)
static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
{
- int i;
+ size_t i;
for (i = 0; i < len; i++)
dst[i] = cpu_to_be32(src[i]);
@@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len)
{
- int i;
+ size_t i;
for (i = 0; i < len; i++)
dst[i] = be32_to_cpu(src[i]);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] thread_info: fix -Wsign-compare warnings
2021-01-26 2:31 [PATCH 1/2] byteorder: fix -Wsign-compare warnings Jeffle Xu
@ 2021-01-26 2:31 ` Jeffle Xu
0 siblings, 0 replies; 2+ messages in thread
From: Jeffle Xu @ 2021-01-26 2:31 UTC (permalink / raw)
To: linux-kernel; +Cc: lkp, joseph.qi, caspar
warning: comparison of integers of different signs: 'int' and 'size_t'
(aka 'unsigned long') [-Wsign-compare]
if (unlikely(sz >= 0 && sz < bytes)) {
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
---
include/linux/thread_info.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h
index c8a974cead73..11b4b36116fa 100644
--- a/include/linux/thread_info.h
+++ b/include/linux/thread_info.h
@@ -179,15 +179,15 @@ __bad_copy_from(void);
extern void __compiletime_error("copy destination size is too small")
__bad_copy_to(void);
-static inline void copy_overflow(int size, unsigned long count)
+static inline void copy_overflow(unsigned long size, unsigned long count)
{
- WARN(1, "Buffer overflow detected (%d < %lu)!\n", size, count);
+ WARN(1, "Buffer overflow detected (%lu < %lu)!\n", size, count);
}
static __always_inline __must_check bool
check_copy_size(const void *addr, size_t bytes, bool is_source)
{
- int sz = __compiletime_object_size(addr);
+ size_t sz = __compiletime_object_size(addr);
if (unlikely(sz >= 0 && sz < bytes)) {
if (!__builtin_constant_p(bytes))
copy_overflow(sz, bytes);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-26 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 2:31 [PATCH 1/2] byteorder: fix -Wsign-compare warnings Jeffle Xu
2021-01-26 2:31 ` [PATCH 2/2] thread_info: " Jeffle Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).