* [PATCH 2/4] cxgb4: remove redundant NULL check
2021-01-25 9:47 [PATCH 1/4] cxgb4: remove redundant NULL check Yang Li
@ 2021-01-25 9:47 ` Yang Li
2021-01-25 9:47 ` [PATCH 3/4] " Yang Li
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Yang Li @ 2021-01-25 9:47 UTC (permalink / raw)
To: davem; +Cc: kuba, rajur, netdev, linux-kernel, Yang Li
Fix below warnings reported by coccicheck:
./drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:3558:2-8: WARNING: NULL
check before some freeing functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
index 75474f8..94eb8a6 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c
@@ -3554,8 +3554,7 @@ int cudbg_collect_qdesc(struct cudbg_init *pdbg_init,
}
out_free:
- if (data)
- kvfree(data);
+ kvfree(data);
#undef QDESC_GET_FLQ
#undef QDESC_GET_RXQ
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/4] cxgb4: remove redundant NULL check
2021-01-25 9:47 [PATCH 1/4] cxgb4: remove redundant NULL check Yang Li
2021-01-25 9:47 ` [PATCH 2/4] " Yang Li
@ 2021-01-25 9:47 ` Yang Li
2021-01-27 4:05 ` Raju Rangoju
2021-01-25 9:47 ` [PATCH 4/4] " Yang Li
2021-01-25 21:14 ` [PATCH 1/4] " Jakub Kicinski
3 siblings, 1 reply; 7+ messages in thread
From: Yang Li @ 2021-01-25 9:47 UTC (permalink / raw)
To: davem; +Cc: kuba, rajur, netdev, linux-kernel, Yang Li
Fix below warnings reported by coccicheck:
./drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING:
NULL check before some freeing functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c
index 77648e4..dd66b24 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c
@@ -157,8 +157,7 @@ static int cudbg_alloc_compress_buff(struct cudbg_init *pdbg_init)
static void cudbg_free_compress_buff(struct cudbg_init *pdbg_init)
{
- if (pdbg_init->compress_buff)
- vfree(pdbg_init->compress_buff);
+ vfree(pdbg_init->compress_buff);
}
int cxgb4_cudbg_collect(struct adapter *adap, void *buf, u32 *buf_size,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/4] cxgb4: remove redundant NULL check
2021-01-25 9:47 ` [PATCH 3/4] " Yang Li
@ 2021-01-27 4:05 ` Raju Rangoju
0 siblings, 0 replies; 7+ messages in thread
From: Raju Rangoju @ 2021-01-27 4:05 UTC (permalink / raw)
To: Yang Li; +Cc: davem, kuba, netdev, linux-kernel
On Monday, January 01/25/21, 2021 at 17:47:24 +0800, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c:161:2-7: WARNING:
> NULL check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c
> index 77648e4..dd66b24 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c
> @@ -157,8 +157,7 @@ static int cudbg_alloc_compress_buff(struct cudbg_init *pdbg_init)
>
> static void cudbg_free_compress_buff(struct cudbg_init *pdbg_init)
> {
> - if (pdbg_init->compress_buff)
NAK. The above check is necessary.
pdbg_init->compress_buff may be NULL when Zlib is unavailable or when
pdbg_init->compress_buff allocation fails, in which case we ignore error
and continue without compression.
> - vfree(pdbg_init->compress_buff);
> + vfree(pdbg_init->compress_buff);
> }
>
> int cxgb4_cudbg_collect(struct adapter *adap, void *buf, u32 *buf_size,
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 4/4] cxgb4: remove redundant NULL check
2021-01-25 9:47 [PATCH 1/4] cxgb4: remove redundant NULL check Yang Li
2021-01-25 9:47 ` [PATCH 2/4] " Yang Li
2021-01-25 9:47 ` [PATCH 3/4] " Yang Li
@ 2021-01-25 9:47 ` Yang Li
2021-01-27 3:56 ` Raju Rangoju
2021-01-25 21:14 ` [PATCH 1/4] " Jakub Kicinski
3 siblings, 1 reply; 7+ messages in thread
From: Yang Li @ 2021-01-25 9:47 UTC (permalink / raw)
To: davem; +Cc: kuba, rajur, netdev, linux-kernel, Yang Li
Fix below warnings reported by coccicheck:
./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING:
NULL check before some freeing functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
index dede025..97a811f 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
@@ -525,12 +525,10 @@ struct cxgb4_tc_u32_table *cxgb4_init_tc_u32(struct adapter *adap)
for (i = 0; i < t->size; i++) {
struct cxgb4_link *link = &t->table[i];
- if (link->tid_map)
- kvfree(link->tid_map);
+ kvfree(link->tid_map);
}
- if (t)
- kvfree(t);
+ kvfree(t);
return NULL;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 4/4] cxgb4: remove redundant NULL check
2021-01-25 9:47 ` [PATCH 4/4] " Yang Li
@ 2021-01-27 3:56 ` Raju Rangoju
0 siblings, 0 replies; 7+ messages in thread
From: Raju Rangoju @ 2021-01-27 3:56 UTC (permalink / raw)
To: Yang Li; +Cc: davem, kuba, netdev, linux-kernel
On Monday, January 01/25/21, 2021 at 17:47:25 +0800, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING:
> NULL check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
> index dede025..97a811f 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
> @@ -525,12 +525,10 @@ struct cxgb4_tc_u32_table *cxgb4_init_tc_u32(struct adapter *adap)
> for (i = 0; i < t->size; i++) {
> struct cxgb4_link *link = &t->table[i];
>
> - if (link->tid_map)
> - kvfree(link->tid_map);
This patch is wrong. NAK.
What if the call to link->tid_map = kvcalloc() fails above? it still goes ahead
and calls kvfree(link->tid_map), which is wrong.
> + kvfree(link->tid_map);
> }
>
> - if (t)
> - kvfree(t);
> + kvfree(t);
>
> return NULL;
> }
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/4] cxgb4: remove redundant NULL check
2021-01-25 9:47 [PATCH 1/4] cxgb4: remove redundant NULL check Yang Li
` (2 preceding siblings ...)
2021-01-25 9:47 ` [PATCH 4/4] " Yang Li
@ 2021-01-25 21:14 ` Jakub Kicinski
3 siblings, 0 replies; 7+ messages in thread
From: Jakub Kicinski @ 2021-01-25 21:14 UTC (permalink / raw)
To: Yang Li; +Cc: davem, rajur, netdev, linux-kernel
On Mon, 25 Jan 2021 17:47:22 +0800 Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c:327:3-9: WARNING: NULL
> check before some freeing functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
These 4 patches change the same driver in the same way, please squash
them all into a single patch and resend.
Please use [PATCH net-next] as the subject tag.
^ permalink raw reply [flat|nested] 7+ messages in thread