From: Vinicius Tinti <viniciustinti@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger.kernel@dilger.ca>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Vinicius Tinti <viniciustinti@gmail.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: [PATCH] ext4: Remove unreachable code
Date: Fri, 29 Jan 2021 18:58:56 +0000 [thread overview]
Message-ID: <20210129185856.158310-1-viniciustinti@gmail.com> (raw)
By enabling -Wunreachable-code-aggressive on Clang the following code
paths are unreachable.
Commit dd73b5d5cb67 ("ext4: convert dx_probe() to use the ERR_PTR
convention")
Commit ac27a0ec112a ("[PATCH] ext4: initial copy of files from ext3")
Clang warns:
fs/ext4/namei.c:831:17: warning: code will never be executed
[-Wunreachable-code]
unsigned n = count - 1;
^~~~~
fs/ext4/namei.c:830:7: note: silence by adding parentheses to mark code as
explicitly dead
if (0) { // linear search cross check
^
/* DISABLES CODE */ ( )
Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com>
---
fs/ext4/namei.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index cf652ba3e74d..1f64dbd7237b 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -827,21 +827,6 @@ dx_probe(struct ext4_filename *fname, struct inode *dir,
p = m + 1;
}
- if (0) { // linear search cross check
- unsigned n = count - 1;
- at = entries;
- while (n--)
- {
- dxtrace(printk(KERN_CONT ","));
- if (dx_get_hash(++at) > hash)
- {
- at--;
- break;
- }
- }
- ASSERT(at == p - 1);
- }
-
at = p - 1;
dxtrace(printk(KERN_CONT " %x->%u\n",
at == entries ? 0 : dx_get_hash(at),
--
2.25.1
next reply other threads:[~2021-01-29 19:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:58 Vinicius Tinti [this message]
2021-01-30 1:35 ` [PATCH] ext4: Remove unreachable code Nathan Chancellor
2021-01-30 6:42 ` Andreas Dilger
2021-02-01 0:31 ` [PATCH v2] ext4: Enable code path when DX_DEBUG is set Vinicius Tinti
2021-02-01 0:48 ` Nathan Chancellor
2021-02-01 12:49 ` Christoph Hellwig
2021-02-01 16:15 ` Vinicius Tinti
2021-02-01 17:13 ` Theodore Ts'o
2021-02-01 18:41 ` Vinicius Tinti
2021-02-01 20:45 ` Andreas Dilger
2021-02-01 21:09 ` Theodore Ts'o
2021-02-01 21:16 ` Nick Desaulniers
2021-02-01 21:38 ` Theodore Ts'o
2021-02-01 21:41 ` Nick Desaulniers
2021-02-01 22:05 ` Vinicius Tinti
2021-02-01 22:48 ` Theodore Ts'o
2021-02-01 23:09 ` Nick Desaulniers
2021-02-02 8:05 ` Christoph Hellwig
2021-02-02 16:28 ` [PATCH v3] " Vinicius Tinti
2021-02-03 5:39 ` Theodore Ts'o
2021-02-03 9:51 ` Vinicius Tinti
2021-02-01 16:58 ` [PATCH v2] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210129185856.158310-1-viniciustinti@gmail.com \
--to=viniciustinti@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).