From: Nick Desaulniers <ndesaulniers@google.com>
To: Vinicius Tinti <viniciustinti@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Nathan Chancellor <natechancellor@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH v2] ext4: Enable code path when DX_DEBUG is set
Date: Mon, 1 Feb 2021 13:16:19 -0800 [thread overview]
Message-ID: <CAKwvOd=ny2TeYV8SGZMD+aj8Yb6OSYGKAzSb-45r-HKk6WTUCQ@mail.gmail.com> (raw)
In-Reply-To: <YBhuHJgZ3QPqHheV@mit.edu>
On Mon, Feb 1, 2021 at 1:09 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> On Mon, Feb 01, 2021 at 03:41:50PM -0300, Vinicius Tinti wrote:
> >
> > My goal is to avoid having a dead code. Three options come to mind.
> >
> > The first would be to add another #ifdef SOMETHING (suggest a name).
> > But this doesn't remove the code and someone could enable it by accident.
>
> I *really* don't see the point of having the compiler whine about
> "dead code", so I'm not terribly fond of
> -Wunreachable-code-aggressive.
I agree; Vinicius, my recommendation for -Wunreachable-* with Clang
was to see whether dead code identified by this more aggressive
diagnostic (than -Wunused-function) was to ask maintainers whether
code identified by it was intentionally dead and if they would
consider removing it. If they say "no," that's fine, and doesn't need
to be pushed. It's not clear to maintainers that:
1. this warning is not on by default
2. we're not looking to pursue turning this on by default
If maintainers want to keep the dead code, that's fine, let them and
move on to the next instance to see if that's interesting (or not).
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-02-01 21:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:58 [PATCH] ext4: Remove unreachable code Vinicius Tinti
2021-01-30 1:35 ` Nathan Chancellor
2021-01-30 6:42 ` Andreas Dilger
2021-02-01 0:31 ` [PATCH v2] ext4: Enable code path when DX_DEBUG is set Vinicius Tinti
2021-02-01 0:48 ` Nathan Chancellor
2021-02-01 12:49 ` Christoph Hellwig
2021-02-01 16:15 ` Vinicius Tinti
2021-02-01 17:13 ` Theodore Ts'o
2021-02-01 18:41 ` Vinicius Tinti
2021-02-01 20:45 ` Andreas Dilger
2021-02-01 21:09 ` Theodore Ts'o
2021-02-01 21:16 ` Nick Desaulniers [this message]
2021-02-01 21:38 ` Theodore Ts'o
2021-02-01 21:41 ` Nick Desaulniers
2021-02-01 22:05 ` Vinicius Tinti
2021-02-01 22:48 ` Theodore Ts'o
2021-02-01 23:09 ` Nick Desaulniers
2021-02-02 8:05 ` Christoph Hellwig
2021-02-02 16:28 ` [PATCH v3] " Vinicius Tinti
2021-02-03 5:39 ` Theodore Ts'o
2021-02-03 9:51 ` Vinicius Tinti
2021-02-01 16:58 ` [PATCH v2] " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOd=ny2TeYV8SGZMD+aj8Yb6OSYGKAzSb-45r-HKk6WTUCQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=adilger.kernel@dilger.ca \
--cc=clang-built-linux@googlegroups.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=tytso@mit.edu \
--cc=viniciustinti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).