linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: meson-gx: remove wrong reserved BL31 memory
@ 2021-01-30  5:40 Artem Lapkin
  2021-02-02  0:45 ` Kevin Hilman
  0 siblings, 1 reply; 2+ messages in thread
From: Artem Lapkin @ 2021-01-30  5:40 UTC (permalink / raw)
  To: narmstrong
  Cc: khilman, robh+dt, jbrunet, christianshewitt, martin.blumenstingl,
	devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, art,
	nick, gouwa

Kernel boot fail on Khadas VIM1 VIM2 (meson GX) boards
SOLUTION: just remove wrong mem reservation for 0x10000000 0x200000

 ## Booting kernel from Legacy Image at 08080000 ...
   Image Name:   kernel
   Image Type:   AArch64 Linux Kernel Image (lzma compressed)
   Data Size:    4657736 Bytes = 4.4 MiB
   Load Address: 0f080000
   Entry Point:  0f080000
   Verifying Checksum ... OK
 ## Flattened Device Tree blob at 08008000
   Booting using the fdt blob at 0x8008000
   Uncompressing Kernel Image
 ERROR: reserving fdt memory region failed (addr=10000000 size=200000)
   Loading Device Tree to 000000007bf23000, end 000000007bf2d3ce ... OK

 Starting kernel ...

 bl31 reboot reason: 0xd
 bl31 reboot reason: 0x0
 system cmd  1.

Signed-off-by: Artem Lapkin <art@khadas.com>
---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index 726b91d3a..71083b89d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -32,12 +32,6 @@ hwrom_reserved: hwrom@0 {
 			no-map;
 		};
 
-		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
-		secmon_reserved: secmon@10000000 {
-			reg = <0x0 0x10000000 0x0 0x200000>;
-			no-map;
-		};
-
 		/* Alternate 3 MiB reserved for ARM Trusted Firmware (BL31) */
 		secmon_reserved_alt: secmon@5000000 {
 			reg = <0x0 0x05000000 0x0 0x300000>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: meson-gx: remove wrong reserved BL31 memory
  2021-01-30  5:40 [PATCH] arm64: dts: meson-gx: remove wrong reserved BL31 memory Artem Lapkin
@ 2021-02-02  0:45 ` Kevin Hilman
  0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2021-02-02  0:45 UTC (permalink / raw)
  To: Artem Lapkin, narmstrong
  Cc: robh+dt, jbrunet, christianshewitt, martin.blumenstingl,
	devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, art,
	nick, gouwa

Artem Lapkin <email2tema@gmail.com> writes:

> Kernel boot fail on Khadas VIM1 VIM2 (meson GX) boards
> SOLUTION: just remove wrong mem reservation for 0x10000000 0x200000

You don't explain why it's wrong.

This region was added becasue there there are definitely GX devices which
have secure memory in this area, and this patch will break those devices.

>  ## Booting kernel from Legacy Image at 08080000 ...
>    Image Name:   kernel
>    Image Type:   AArch64 Linux Kernel Image (lzma compressed)
>    Data Size:    4657736 Bytes = 4.4 MiB
>    Load Address: 0f080000
>    Entry Point:  0f080000
>    Verifying Checksum ... OK
>  ## Flattened Device Tree blob at 08008000
>    Booting using the fdt blob at 0x8008000
>    Uncompressing Kernel Image
>  ERROR: reserving fdt memory region failed (addr=10000000 size=200000)
>    Loading Device Tree to 000000007bf23000, end 000000007bf2d3ce ... OK

I suspect if you change the load addresses used by u-boot to avoid this
region, you'll be able to boot just fine.

Kevin

>  Starting kernel ...
>
>  bl31 reboot reason: 0xd
>  bl31 reboot reason: 0x0
>  system cmd  1.
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 726b91d3a..71083b89d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -32,12 +32,6 @@ hwrom_reserved: hwrom@0 {
>  			no-map;
>  		};
>  
> -		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
> -		secmon_reserved: secmon@10000000 {
> -			reg = <0x0 0x10000000 0x0 0x200000>;
> -			no-map;
> -		};
> -
>  		/* Alternate 3 MiB reserved for ARM Trusted Firmware (BL31) */
>  		secmon_reserved_alt: secmon@5000000 {
>  			reg = <0x0 0x05000000 0x0 0x300000>;
> -- 
> 2.25.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-02  0:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-30  5:40 [PATCH] arm64: dts: meson-gx: remove wrong reserved BL31 memory Artem Lapkin
2021-02-02  0:45 ` Kevin Hilman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).