* [PATCH] scsi: ufs: print the counter of each event history
[not found] <CGME20210203102752epcas1p16713d977a1a679cf641894144d8f299d@epcas1p1.samsung.com>
@ 2021-02-03 10:14 ` DooHyun Hwang
2021-02-05 8:17 ` Avri Altman
2021-02-09 3:16 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: DooHyun Hwang @ 2021-02-03 10:14 UTC (permalink / raw)
To: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, stanley.chu, cang, asutoshd, beanhuo, jaegeuk,
adrian.hunter, satyat
Cc: grant.jung, jt77.jang, junwoo80.lee, jangsub.yi, sh043.lee,
cw9316.lee, sh8267.baek, wkon.kim, DooHyun Hwang
Since only print the recorded event history list,
add to print the counter value.
Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 721f55db181f..1ea920aeb701 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -451,6 +451,8 @@ static void ufshcd_print_evt(struct ufs_hba *hba, u32 id,
if (!found)
dev_err(hba->dev, "No record of %s\n", err_name);
+ else
+ dev_err(hba->dev, "%s: total cnt=%llu\n", err_name, e->cnt);
}
static void ufshcd_print_evt_hist(struct ufs_hba *hba)
--
2.29.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs: print the counter of each event history
2021-02-03 10:14 ` [PATCH] scsi: ufs: print the counter of each event history DooHyun Hwang
@ 2021-02-05 8:17 ` Avri Altman
2021-02-05 8:35 ` DooHyun Hwang
2021-02-09 3:16 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Avri Altman @ 2021-02-05 8:17 UTC (permalink / raw)
To: DooHyun Hwang, linux-scsi, linux-kernel, alim.akhtar, jejb,
martin.petersen, stanley.chu, cang, asutoshd, beanhuo, jaegeuk,
adrian.hunter, satyat
Cc: grant.jung, jt77.jang, junwoo80.lee, jangsub.yi, sh043.lee,
cw9316.lee, sh8267.baek, wkon.kim
>
>
> Since only print the recorded event history list,
> add to print the counter value.
>
> Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Btw, You have the counter now in ufs-debugfs as well.
Thanks,
Avri
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs: print the counter of each event history
2021-02-05 8:17 ` Avri Altman
@ 2021-02-05 8:35 ` DooHyun Hwang
0 siblings, 0 replies; 4+ messages in thread
From: DooHyun Hwang @ 2021-02-05 8:35 UTC (permalink / raw)
To: 'Avri Altman',
linux-scsi, linux-kernel, alim.akhtar, jejb, martin.petersen,
stanley.chu, cang, asutoshd, beanhuo, jaegeuk, adrian.hunter,
satyat
Cc: grant.jung, jt77.jang, junwoo80.lee, jangsub.yi, sh043.lee,
cw9316.lee, sh8267.baek, wkon.kim
>>
>> Since only print the recorded event history list, add to print the
>> counter value.
>>
>> Signed-off-by: DooHyun Hwang <dh0421.hwang@samsung.com>
>Reviewed-by: Avri Altman <avri.altman@wdc.com>
>
>Btw, You have the counter now in ufs-debugfs as well.
>
>Thanks,
>Avri
Thank you for your review and information.
I hope to be able to check the counter value in kernel log as well.
Thank you.
DooHyun Hwang.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: print the counter of each event history
2021-02-03 10:14 ` [PATCH] scsi: ufs: print the counter of each event history DooHyun Hwang
2021-02-05 8:17 ` Avri Altman
@ 2021-02-09 3:16 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-02-09 3:16 UTC (permalink / raw)
To: DooHyun Hwang
Cc: linux-scsi, linux-kernel, alim.akhtar, avri.altman, jejb,
martin.petersen, stanley.chu, cang, asutoshd, beanhuo, jaegeuk,
adrian.hunter, satyat, grant.jung, jt77.jang, junwoo80.lee,
jangsub.yi, sh043.lee, cw9316.lee, sh8267.baek, wkon.kim
DooHyun,
> Since only print the recorded event history list, add to print the
> counter value.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-09 3:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210203102752epcas1p16713d977a1a679cf641894144d8f299d@epcas1p1.samsung.com>
2021-02-03 10:14 ` [PATCH] scsi: ufs: print the counter of each event history DooHyun Hwang
2021-02-05 8:17 ` Avri Altman
2021-02-05 8:35 ` DooHyun Hwang
2021-02-09 3:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).