* [PATCH][next] staging: qlge: fix read of an uninitialized pointer
@ 2021-02-03 13:38 Colin King
2021-02-03 13:50 ` Coiby Xu
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-02-03 13:38 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman, Coiby Xu,
netdev, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the pointer 'reporter' is not being initialized and is
being read in a netdev_warn message. The pointer is not used
and is redundant, fix this by removing it and replacing the reference
to it with priv->reporter instead.
Addresses-Coverity: ("Uninitialized pointer read")
Fixes: 1053c27804df ("staging: qlge: coredump via devlink health reporter")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/qlge/qlge_devlink.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/qlge/qlge_devlink.c b/drivers/staging/qlge/qlge_devlink.c
index c6ef5163e241..86834d96cebf 100644
--- a/drivers/staging/qlge/qlge_devlink.c
+++ b/drivers/staging/qlge/qlge_devlink.c
@@ -150,7 +150,6 @@ static const struct devlink_health_reporter_ops qlge_reporter_ops = {
void qlge_health_create_reporters(struct qlge_adapter *priv)
{
- struct devlink_health_reporter *reporter;
struct devlink *devlink;
devlink = priv_to_devlink(priv);
@@ -160,5 +159,5 @@ void qlge_health_create_reporters(struct qlge_adapter *priv)
if (IS_ERR(priv->reporter))
netdev_warn(priv->ndev,
"Failed to create reporter, err = %ld\n",
- PTR_ERR(reporter));
+ PTR_ERR(priv->reporter));
}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] staging: qlge: fix read of an uninitialized pointer
2021-02-03 13:38 [PATCH][next] staging: qlge: fix read of an uninitialized pointer Colin King
@ 2021-02-03 13:50 ` Coiby Xu
0 siblings, 0 replies; 2+ messages in thread
From: Coiby Xu @ 2021-02-03 13:50 UTC (permalink / raw)
To: Colin King
Cc: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman, netdev,
devel, kernel-janitors, linux-kernel, Dan Carpenter
On Wed, Feb 03, 2021 at 01:38:34PM +0000, Colin King wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>Currently the pointer 'reporter' is not being initialized and is
>being read in a netdev_warn message. The pointer is not used
>and is redundant, fix this by removing it and replacing the reference
>to it with priv->reporter instead.
>
>Addresses-Coverity: ("Uninitialized pointer read")
>Fixes: 1053c27804df ("staging: qlge: coredump via devlink health reporter")
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/staging/qlge/qlge_devlink.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/staging/qlge/qlge_devlink.c b/drivers/staging/qlge/qlge_devlink.c
>index c6ef5163e241..86834d96cebf 100644
>--- a/drivers/staging/qlge/qlge_devlink.c
>+++ b/drivers/staging/qlge/qlge_devlink.c
>@@ -150,7 +150,6 @@ static const struct devlink_health_reporter_ops qlge_reporter_ops = {
>
> void qlge_health_create_reporters(struct qlge_adapter *priv)
> {
>- struct devlink_health_reporter *reporter;
> struct devlink *devlink;
>
> devlink = priv_to_devlink(priv);
>@@ -160,5 +159,5 @@ void qlge_health_create_reporters(struct qlge_adapter *priv)
> if (IS_ERR(priv->reporter))
> netdev_warn(priv->ndev,
> "Failed to create reporter, err = %ld\n",
>- PTR_ERR(reporter));
>+ PTR_ERR(priv->reporter));
> }
>--
>2.29.2
>
Thanks for fixing this issue.
Reviewed-by: Coiby Xu <coiby.xu@gmail.com>
--
Best regards,
Coiby
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-03 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 13:38 [PATCH][next] staging: qlge: fix read of an uninitialized pointer Colin King
2021-02-03 13:50 ` Coiby Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).