* [PATCH] octeontx2-af: remove unneeded semicolon
@ 2021-02-03 2:17 Yang Li
2021-02-03 23:46 ` Jesse Brandeburg
0 siblings, 1 reply; 5+ messages in thread
From: Yang Li @ 2021-02-03 2:17 UTC (permalink / raw)
To: davem
Cc: kuba, sgoutham, lcherian, gakula, jerinj, netdev, linux-kernel, Yang Li
Eliminate the following coccicheck warning:
./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3:
Unneeded semicolon
./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4:
Unneeded semicolon
./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1788:3-4:
Unneeded semicolon
./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded
semicolon
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++--
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index e8fd712..0b6bf9f 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -1323,7 +1323,7 @@ static int rvu_get_attach_blkaddr(struct rvu *rvu, int blktype,
break;
default:
return rvu_get_blkaddr(rvu, blktype, 0);
- };
+ }
if (is_block_implemented(rvu->hw, blkaddr))
return blkaddr;
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
index d27543c..b5b5032 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
@@ -1785,7 +1785,7 @@ static void rvu_dbg_npc_mcam_show_action(struct seq_file *s,
break;
default:
break;
- };
+ }
} else {
switch (rule->rx_action.op) {
case NIX_RX_ACTIONOP_DROP:
@@ -1806,7 +1806,7 @@ static void rvu_dbg_npc_mcam_show_action(struct seq_file *s,
break;
default:
break;
- };
+ }
}
}
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index 14832b6..f72c795 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -269,7 +269,7 @@ static void npc_scan_parse_result(struct npc_mcam *mcam, u8 bit_number,
break;
default:
return;
- };
+ }
npc_set_kw_masks(mcam, type, nr_bits, kwi, offset, intf);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] octeontx2-af: remove unneeded semicolon
2021-02-03 2:17 [PATCH] octeontx2-af: remove unneeded semicolon Yang Li
@ 2021-02-03 23:46 ` Jesse Brandeburg
2021-02-04 0:02 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Jesse Brandeburg @ 2021-02-03 23:46 UTC (permalink / raw)
To: Yang Li
Cc: davem, kuba, sgoutham, lcherian, gakula, jerinj, netdev, linux-kernel
Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3:
> Unneeded semicolon
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4:
> Unneeded semicolon
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1788:3-4:
> Unneeded semicolon
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
> drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++--
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Trivial patch, recommend net-next as it's not a critical fix, Yang,
please include the targeted tree when sending like [PATCH net-next]
otherwise, for net-next:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] octeontx2-af: remove unneeded semicolon
2021-02-03 23:46 ` Jesse Brandeburg
@ 2021-02-04 0:02 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2021-02-04 0:02 UTC (permalink / raw)
To: Jesse Brandeburg
Cc: Yang Li, davem, sgoutham, lcherian, gakula, jerinj, netdev, linux-kernel
On Wed, 3 Feb 2021 15:46:58 -0800 Jesse Brandeburg wrote:
> Yang Li wrote:
>
> > Eliminate the following coccicheck warning:
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3:
> > Unneeded semicolon
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1809:3-4:
> > Unneeded semicolon
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c:1788:3-4:
> > Unneeded semicolon
> > ./drivers/net/ethernet/marvell/octeontx2/af/rvu.c:1326:2-3: Unneeded
> > semicolon
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
> > drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 4 ++--
> > drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
>
> Trivial patch, recommend net-next as it's not a critical fix, Yang,
> please include the targeted tree when sending like [PATCH net-next]
>
> otherwise, for net-next:
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
The patch does not apply to net-next, please rebase, add Jesse's review
tag and repost.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] octeontx2-af: Remove unneeded semicolon
@ 2021-01-19 7:50 Xu Wang
2021-01-20 1:51 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Xu Wang @ 2021-01-19 7:50 UTC (permalink / raw)
To: sgoutham, lcherian, gakula, jerinj, davem, kuba; +Cc: netdev, linux-kernel
fix semicolon.cocci warnings:
./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3: Unneeded semicolon
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index 14832b66d1fe..f72c79540b24 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -269,7 +269,7 @@ static void npc_scan_parse_result(struct npc_mcam *mcam, u8 bit_number,
break;
default:
return;
- };
+ }
npc_set_kw_masks(mcam, type, nr_bits, kwi, offset, intf);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] octeontx2-af: Remove unneeded semicolon
2021-01-19 7:50 [PATCH] octeontx2-af: Remove " Xu Wang
@ 2021-01-20 1:51 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2021-01-20 1:51 UTC (permalink / raw)
To: Xu Wang; +Cc: sgoutham, lcherian, gakula, jerinj, davem, netdev, linux-kernel
On Tue, 19 Jan 2021 07:50:59 +0000 Xu Wang wrote:
> fix semicolon.cocci warnings:
> ./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:272:2-3: Unneeded semicolon
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
I squashed your 3 patches for octeontx2-af and applied them to net-next.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-04 0:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 2:17 [PATCH] octeontx2-af: remove unneeded semicolon Yang Li
2021-02-03 23:46 ` Jesse Brandeburg
2021-02-04 0:02 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2021-01-19 7:50 [PATCH] octeontx2-af: Remove " Xu Wang
2021-01-20 1:51 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).