* [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties
@ 2021-02-04 12:59 Geert Uytterhoeven
2021-02-08 13:14 ` Marc Kleine-Budde
2021-02-09 22:52 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-02-04 12:59 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde, David S . Miller,
Jakub Kicinski, Rob Herring
Cc: Lad Prabhakar, linux-can, netdev, devicetree, linux-renesas-soc,
linux-kernel, Geert Uytterhoeven
To improve human readability and enable automatic validation, the tuples
in "pinctrl-*" properties should be grouped using angle brackets.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
index 22cf2a889b2c7d6b..248c4ed97a0a078e 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
@@ -97,7 +97,7 @@ E.g. below enables Channel 0 alone in the board using External clock
as fCAN clock.
&canfd {
- pinctrl-0 = <&canfd0_pins &can_clk_pins>;
+ pinctrl-0 = <&canfd0_pins>, <&can_clk_pins>;
pinctrl-names = "default";
status = "okay";
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties
2021-02-04 12:59 [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties Geert Uytterhoeven
@ 2021-02-08 13:14 ` Marc Kleine-Budde
2021-02-09 22:52 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2021-02-08 13:14 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Wolfgang Grandegger, David S . Miller, Jakub Kicinski,
Rob Herring, Lad Prabhakar, linux-can, netdev, devicetree,
linux-renesas-soc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
On 04.02.2021 13:59:37, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "pinctrl-*" properties should be grouped using angle brackets.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties
2021-02-04 12:59 [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties Geert Uytterhoeven
2021-02-08 13:14 ` Marc Kleine-Budde
@ 2021-02-09 22:52 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-02-09 22:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jakub Kicinski, linux-renesas-soc, devicetree,
Wolfgang Grandegger, linux-kernel, Rob Herring, linux-can,
Lad Prabhakar, David S . Miller, Marc Kleine-Budde, netdev
On Thu, 04 Feb 2021 13:59:37 +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "pinctrl-*" properties should be grouped using angle brackets.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-10 1:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 12:59 [PATCH] dt-bindings: can: rcar_canfd: Group tuples in pin control properties Geert Uytterhoeven
2021-02-08 13:14 ` Marc Kleine-Budde
2021-02-09 22:52 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).