linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: core: Remove extra spaces
Date: Thu, 4 Feb 2021 19:04:34 -0800	[thread overview]
Message-ID: <20210204190434.0771aa83@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210204030639.14965-1-zhengyongjun3@huawei.com>

On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
> Do codingstyle clean up to remove extra spaces.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  net/core/neighbour.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 9500d28a43b0..72ea94ec8c4a 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct net_device *dev,
>  
>  	p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
>  	if (p) {
> -		p->tbl		  = tbl;
> +		p->tbl = tbl;
>  		refcount_set(&p->refcnt, 1);
>  		p->reachable_time =

                                  ^

It's aligned with the assignment to reachable_time.

I don't find this particularly offensive, there are worse style issues
in this function.

>  				neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));


  reply	other threads:[~2021-02-05  3:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  3:06 [PATCH net-next] net: core: Remove extra spaces Zheng Yongjun
2021-02-05  3:04 ` Jakub Kicinski [this message]
2021-02-05  3:13   ` 答复: " zhengyongjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204190434.0771aa83@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=zhengyongjun3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).