From: zhengyongjun <zhengyongjun3@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH net-next] net: core: Remove extra spaces
Date: Fri, 5 Feb 2021 03:13:48 +0000 [thread overview]
Message-ID: <0617c92cb1bb41d0a5dc889df716d7b1@huawei.com> (raw)
In-Reply-To: <20210204190434.0771aa83@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Thank you, I will do this code style cleanup in ` net/core/neighbour.c` to fix the worse style issues you said :)
-----邮件原件-----
发件人: Jakub Kicinski [mailto:kuba@kernel.org]
发送时间: 2021年2月5日 11:05
收件人: zhengyongjun <zhengyongjun3@huawei.com>
抄送: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH net-next] net: core: Remove extra spaces
On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote:
> Do codingstyle clean up to remove extra spaces.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> net/core/neighbour.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c index
> 9500d28a43b0..72ea94ec8c4a 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -1618,7 +1618,7 @@ struct neigh_parms *neigh_parms_alloc(struct
> net_device *dev,
>
> p = kmemdup(&tbl->parms, sizeof(*p), GFP_KERNEL);
> if (p) {
> - p->tbl = tbl;
> + p->tbl = tbl;
> refcount_set(&p->refcnt, 1);
> p->reachable_time =
^
It's aligned with the assignment to reachable_time.
I don't find this particularly offensive, there are worse style issues in this function.
> neigh_rand_reach_time(NEIGH_VAR(p, BASE_REACHABLE_TIME));
prev parent reply other threads:[~2021-02-05 3:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 3:06 [PATCH net-next] net: core: Remove extra spaces Zheng Yongjun
2021-02-05 3:04 ` Jakub Kicinski
2021-02-05 3:13 ` zhengyongjun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0617c92cb1bb41d0a5dc889df716d7b1@huawei.com \
--to=zhengyongjun3@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).