From: Giancarlo Ferrari <giancarlo.ferrari89@gmail.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, penberg@kernel.org,
geert@linux-m68k.org, rppt@kernel.org, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
giancarlo.ferrari@nokia.com
Subject: Re: [PATCH] ARM: kexec: Fix panic after TLB are invalidated
Date: Fri, 5 Feb 2021 00:45:36 +0000 [thread overview]
Message-ID: <20210205004535.GB3319@p4> (raw)
In-Reply-To: <20210205004050.GA3319@p4>
Sorry for polluting,
On Fri, Feb 05, 2021 at 12:40:54AM +0000, Giancarlo Ferrari wrote:
> Russell,
>
> On Fri, Feb 05, 2021 at 12:18:33AM +0000, Russell King - ARM Linux admin wrote:
> > On Thu, Feb 04, 2021 at 11:48:42PM +0000, Giancarlo Ferrari wrote:
> > > Can I ask about having it integrated ?
> >
> > Thanks for testing. Are you willing for me to add:
> >
> > Tested-by: Giancarlo Ferrari <giancarlo.ferrari89@gmail.com>
> >
> > to the commit log?
> >
>
> Sure.
>
> I have a question regarding the patch. I saw that the structure start at
> the end of the relocation code:
>
> data = reboot_code_buffer + relocate_new_kernel_size;
>
> which means it overlap with the global symbol relocate_new_kernel_size.
> I think is minor comment as the variable is only used in the fncpy()
> then thrown away. Something like:
>
> data = reboot_code_buffer + relocate_new_kernel_size + sizeof(long);
>
> and accordingly in the instruction (arch/arm/kernel/relocate_kernel.S):
>
> adr r7, relocate_new_kernel_end
>
my fault. Do as I didn't talk... one is in virtual memory the other in the
initial code.
> > I can move it into the fixes branch which I want to send to Linus by
> > Saturday at the very latest.
> >
>
> I am not used with all the merging process. However it sounds great !
>
> > --
> > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
>
> Thanks in advance,
>
>
> GF
Thanks,
GF
next prev parent reply other threads:[~2021-02-05 0:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 0:44 [PATCH] ARM: kexec: Fix panic after TLB are invalidated Giancarlo Ferrari
2021-02-01 11:34 ` Russell King - ARM Linux admin
2021-02-01 12:47 ` Mark Rutland
2021-02-01 13:03 ` Russell King - ARM Linux admin
2021-02-01 13:57 ` Mark Rutland
2021-02-01 16:08 ` Russell King - ARM Linux admin
2021-02-01 16:32 ` Mark Rutland
2021-02-01 16:37 ` Russell King - ARM Linux admin
2021-02-01 20:07 ` Giancarlo Ferrari
2021-02-01 20:16 ` Russell King - ARM Linux admin
2021-02-01 22:18 ` Giancarlo Ferrari
2021-02-04 23:48 ` Giancarlo Ferrari
2021-02-05 0:18 ` Russell King - ARM Linux admin
2021-02-05 0:40 ` Giancarlo Ferrari
2021-02-05 0:45 ` Giancarlo Ferrari [this message]
2021-02-05 9:44 ` Russell King - ARM Linux admin
2021-02-05 14:36 ` Giancarlo Ferrari
2021-02-01 14:39 ` Giancarlo Ferrari
2021-02-01 15:30 ` Mark Rutland
2021-02-01 19:09 ` Giancarlo Ferrari
-- strict thread matches above, loose matches on Subject: below --
2021-01-12 16:49 Giancarlo Ferrari
2021-02-01 10:10 ` Giancarlo Ferrari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205004535.GB3319@p4 \
--to=giancarlo.ferrari89@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=giancarlo.ferrari@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=penberg@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).