* [PATCH 1/2] powerpc/Kconfig: Fix unmet direct dependency on NET
@ 2021-01-30 22:55 Florian Fainelli
2021-01-30 22:55 ` [PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2021-01-30 22:55 UTC (permalink / raw)
To: linux-kernel, arndb
Cc: kbuild-all, Florian Fainelli, kernel test robot,
Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
Christophe Leroy, Arnd Bergmann, Michal Simek,
open list:LINUX FOR POWERPC EMBEDDED PPC4XX
The kbuild test robot was able to generate a configuration where
ETHERNET and NETDEVICES was selected by the Akenobo platform but not
NET, which resulted in various build failures and these Kconfig
warnings:
WARNING: unmet direct dependencies detected for NETDEVICES
Depends on [n]: NET [=n]
Selected by [y]:
- AKEBONO [=y] && PPC_47x [=y]
WARNING: unmet direct dependencies detected for ETHERNET
Depends on [n]: NETDEVICES [=y] && NET [=n]
Selected by [y]:
- AKEBONO [=y] && PPC_47x [=y]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
arch/powerpc/platforms/44x/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 78ac6d67a935..68bd647c878f 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -206,6 +206,7 @@ config AKEBONO
select PPC4xx_HSTA_MSI
select I2C
select I2C_IBM_IIC
+ select NET
select NETDEVICES
select ETHERNET
select NET_VENDOR_IBM
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m
2021-01-30 22:55 [PATCH 1/2] powerpc/Kconfig: Fix unmet direct dependency on NET Florian Fainelli
@ 2021-01-30 22:55 ` Florian Fainelli
2021-02-05 3:38 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2021-01-30 22:55 UTC (permalink / raw)
To: linux-kernel, arndb
Cc: kbuild-all, Florian Fainelli, kernel test robot, Herbert Xu,
David S. Miller, open list:CRYPTO API
It is currently possible to build CONFIG_HW_RANDOM_PPC4XX=y with
CONFIG_HW_RANDOM=m which would lead to the inability of linking with
devm_hwrng_{register,unregister}. We cannot have the framework modular
and the consumer of that framework built-in, so make that dependency
explicit.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index e535f28a8028..c833ac08ea81 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -348,7 +348,7 @@ config CRYPTO_DEV_PPC4XX
config HW_RANDOM_PPC4XX
bool "PowerPC 4xx generic true random number generator support"
- depends on CRYPTO_DEV_PPC4XX && HW_RANDOM
+ depends on CRYPTO_DEV_PPC4XX && HW_RANDOM=y
default y
help
This option provides the kernel-side support for the TRNG hardware
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m
2021-01-30 22:55 ` [PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m Florian Fainelli
@ 2021-02-05 3:38 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2021-02-05 3:38 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, arndb, kbuild-all, kernel test robot,
David S. Miller, open list:CRYPTO API
On Sat, Jan 30, 2021 at 02:55:38PM -0800, Florian Fainelli wrote:
> It is currently possible to build CONFIG_HW_RANDOM_PPC4XX=y with
> CONFIG_HW_RANDOM=m which would lead to the inability of linking with
> devm_hwrng_{register,unregister}. We cannot have the framework modular
> and the consumer of that framework built-in, so make that dependency
> explicit.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-05 3:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-30 22:55 [PATCH 1/2] powerpc/Kconfig: Fix unmet direct dependency on NET Florian Fainelli
2021-01-30 22:55 ` [PATCH 2/2] crypto: crypto4xx - Avoid linking failure with HW_RANDOM=m Florian Fainelli
2021-02-05 3:38 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).