From: Pavel Machek <pavel@ucw.cz>
To: Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Dan Murphy <dmurphy@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
Date: Fri, 5 Feb 2021 11:34:38 +0100 [thread overview]
Message-ID: <20210205103438.GB27854@amd> (raw)
In-Reply-To: <DB8P190MB0634587826F57667BB3BBB6CD9B29@DB8P190MB0634.EURP190.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
On Fri 2021-02-05 09:59:19, Sven Schuchmann wrote:
> Hello Pavel,
>
> > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> > > index f13117eed976..4b40bf66483c 100644
> > > --- a/drivers/leds/leds-lp50xx.c
> > > +++ b/drivers/leds/leds-lp50xx.c
> > > @@ -267,7 +267,6 @@ struct lp50xx_led {
> > > struct led_classdev_mc mc_cdev;
> > > struct lp50xx *priv;
> > > unsigned long bank_modules;
> > > - int led_intensity[LP50XX_LEDS_PER_MODULE];
> > > u8 ctrl_bank_enabled;
> > > int led_number;
> > > };
> >
> > ? Does not make sense and changelog does not help.
>
> This is an unused variable which is in the driver
> (same as the regulator). Should I provide a patch on its own for that
> or just describe in the changelog?
Lets do separate patch here. DT changes will need Ack from Rob, this
can go in directly.
Can you or Dan submit patch getting the regulator support to work? If
not, I guess we should remove the regulator support after all.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-02-05 10:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:37 [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT Sven Schuchmann
2021-02-04 14:53 ` Pavel Machek
2021-02-05 9:59 ` AW: " Sven Schuchmann
2021-02-05 10:34 ` Pavel Machek [this message]
2021-02-05 11:21 ` Sven Schuchmann
2021-02-19 11:16 ` Pavel Machek
2021-02-19 11:38 ` AW: " Sven Schuchmann
2021-02-19 13:55 ` Andy Shevchenko
2021-02-19 14:09 ` AW: " Sven Schuchmann
2021-02-19 14:50 ` Andy Shevchenko
2021-02-19 14:18 ` Andy Shevchenko
2021-02-19 18:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205103438.GB27854@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).