From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sven Schuchmann <schuchmann@schleissheimer.de>,
Dan Murphy <dmurphy@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT
Date: Fri, 19 Feb 2021 19:07:21 +0100 [thread overview]
Message-ID: <20210219180721.GA8596@duo.ucw.cz> (raw)
In-Reply-To: <CAHp75VeE5vpfAXeppOkfAmQS=dwexW8SuWj3ovFmeCQ9kuQ5sg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
On Fri 2021-02-19 16:18:38, Andy Shevchenko wrote:
> On Fri, Feb 19, 2021 at 1:19 PM Pavel Machek <pavel@ucw.cz> wrote:
> > > > > > ? Does not make sense and changelog does not help.
> > > > >
> > > > > This is an unused variable which is in the driver
> > > > > (same as the regulator). Should I provide a patch on its own for that
> > > > > or just describe in the changelog?
> > > >
> > > > Lets do separate patch here. DT changes will need Ack from Rob, this
> > > > can go in directly.
> > >
> > > Okay, I will submit a separate patch
> > >
> > > > Can you or Dan submit patch getting the regulator support to work? If
> > > > not, I guess we should remove the regulator support after all.
> > >
> > > To be true I am fairly new to the kernel and have no idea
> > > how to test this. So no, I don't want provide a patch (except
> > > for removing), sorry.
> >
> > No problem. It seems Andy submitted series for this.
>
> Ah, now I understand what you, Sven, meant.
> I didn't touch regulator code, so it left the same, but making it work
> probably needs just enabling during ->probe().
Yep, sorry, I was confused.
Anyway, I'd rather seen patch fixing the regulator code than removing
it completely.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2021-02-19 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 14:37 [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT Sven Schuchmann
2021-02-04 14:53 ` Pavel Machek
2021-02-05 9:59 ` AW: " Sven Schuchmann
2021-02-05 10:34 ` Pavel Machek
2021-02-05 11:21 ` AW: " Sven Schuchmann
2021-02-19 11:16 ` Pavel Machek
2021-02-19 11:38 ` AW: " Sven Schuchmann
2021-02-19 13:55 ` Andy Shevchenko
2021-02-19 14:09 ` AW: " Sven Schuchmann
2021-02-19 14:50 ` Andy Shevchenko
2021-02-19 14:18 ` Andy Shevchenko
2021-02-19 18:07 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219180721.GA8596@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andy.shevchenko@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).