linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Add check for max clock rate in mode_valid
@ 2021-02-08  1:26 Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 1/3] drm/mediatek: mtk_dpi: " Jitao Shi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jitao Shi @ 2021-02-08  1:26 UTC (permalink / raw)
  To: Chun-Kuang Hu, Philipp Zabel
  Cc: airlied, daniel, robh+dt, matthias.bgg, srv_heupstream,
	yingjoe.chen, eddie.huang, ck.hu, dri-devel, devicetree,
	stonea168, huijuan.xie, linux-kernel, linux-arm-kernel,
	linux-mediatek, shuijing.li, Jitao Shi

Changes since v1:
 - fix build err.

Jitao Shi (3):
  drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid
  drm/mediatek: mtk_dpi: Add dpi config for mt8192
  dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi

 .../display/mediatek/mediatek,dpi.yaml        |  1 +
 drivers/gpu/drm/mediatek/mtk_dpi.c            | 26 +++++++++++++++++++
 2 files changed, 27 insertions(+)

-- 
2.25.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/3] drm/mediatek: mtk_dpi: Add check for max clock rate in mode_valid
  2021-02-08  1:26 [PATCH v2 0/3] Add check for max clock rate in mode_valid Jitao Shi
@ 2021-02-08  1:26 ` Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 2/3] drm/mediatek: mtk_dpi: Add dpi config for mt8192 Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi Jitao Shi
  2 siblings, 0 replies; 4+ messages in thread
From: Jitao Shi @ 2021-02-08  1:26 UTC (permalink / raw)
  To: Chun-Kuang Hu, Philipp Zabel
  Cc: airlied, daniel, robh+dt, matthias.bgg, srv_heupstream,
	yingjoe.chen, eddie.huang, ck.hu, dri-devel, devicetree,
	stonea168, huijuan.xie, linux-kernel, linux-arm-kernel,
	linux-mediatek, shuijing.li, Jitao Shi

Add per-platform max clock rate check in mtk_dpi_bridge_mode_valid.

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 52f11a63a330..ffa4a0f1989f 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -118,6 +118,7 @@ struct mtk_dpi_yc_limit {
 struct mtk_dpi_conf {
 	unsigned int (*cal_factor)(int clock);
 	u32 reg_h_fre_con;
+	u32 max_clock_khz;
 	bool edge_sel_en;
 };
 
@@ -555,9 +556,22 @@ static void mtk_dpi_bridge_enable(struct drm_bridge *bridge)
 	mtk_dpi_set_display_mode(dpi, &dpi->mode);
 }
 
+static enum drm_mode_status
+mtk_dpi_bridge_mode_valid(struct drm_bridge *bridge,
+			  const struct drm_display_mode *mode)
+{
+	struct mtk_dpi *dpi = bridge_to_dpi(bridge);
+
+	if (dpi->conf->max_clock_khz && mode->clock > dpi->conf->max_clock_khz)
+		return MODE_CLOCK_HIGH;
+
+	return MODE_OK;
+}
+
 static const struct drm_bridge_funcs mtk_dpi_bridge_funcs = {
 	.attach = mtk_dpi_bridge_attach,
 	.mode_set = mtk_dpi_bridge_mode_set,
+	.mode_valid = mtk_dpi_bridge_mode_valid,
 	.disable = mtk_dpi_bridge_disable,
 	.enable = mtk_dpi_bridge_enable,
 };
@@ -673,17 +687,20 @@ static unsigned int mt8183_calculate_factor(int clock)
 static const struct mtk_dpi_conf mt8173_conf = {
 	.cal_factor = mt8173_calculate_factor,
 	.reg_h_fre_con = 0xe0,
+	.max_clock_khz = 300000,
 };
 
 static const struct mtk_dpi_conf mt2701_conf = {
 	.cal_factor = mt2701_calculate_factor,
 	.reg_h_fre_con = 0xb0,
 	.edge_sel_en = true,
+	.max_clock_khz = 150000,
 };
 
 static const struct mtk_dpi_conf mt8183_conf = {
 	.cal_factor = mt8183_calculate_factor,
 	.reg_h_fre_con = 0xe0,
+	.max_clock_khz = 100000,
 };
 
 static int mtk_dpi_probe(struct platform_device *pdev)
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/3] drm/mediatek: mtk_dpi: Add dpi config for mt8192
  2021-02-08  1:26 [PATCH v2 0/3] Add check for max clock rate in mode_valid Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 1/3] drm/mediatek: mtk_dpi: " Jitao Shi
@ 2021-02-08  1:26 ` Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi Jitao Shi
  2 siblings, 0 replies; 4+ messages in thread
From: Jitao Shi @ 2021-02-08  1:26 UTC (permalink / raw)
  To: Chun-Kuang Hu, Philipp Zabel
  Cc: airlied, daniel, robh+dt, matthias.bgg, srv_heupstream,
	yingjoe.chen, eddie.huang, ck.hu, dri-devel, devicetree,
	stonea168, huijuan.xie, linux-kernel, linux-arm-kernel,
	linux-mediatek, shuijing.li, Jitao Shi

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index ffa4a0f1989f..f6f71eb67ff1 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -703,6 +703,12 @@ static const struct mtk_dpi_conf mt8183_conf = {
 	.max_clock_khz = 100000,
 };
 
+static const struct mtk_dpi_conf mt8192_conf = {
+	.cal_factor = mt8183_calculate_factor,
+	.reg_h_fre_con = 0xe0,
+	.max_clock_khz = 150000,
+};
+
 static int mtk_dpi_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
@@ -837,6 +843,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
 	{ .compatible = "mediatek,mt8183-dpi",
 	  .data = &mt8183_conf,
 	},
+	{ .compatible = "mediatek,mt8192-dpi",
+	  .data = &mt8192_conf,
+	},
 	{ },
 };
 
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi
  2021-02-08  1:26 [PATCH v2 0/3] Add check for max clock rate in mode_valid Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 1/3] drm/mediatek: mtk_dpi: " Jitao Shi
  2021-02-08  1:26 ` [PATCH v2 2/3] drm/mediatek: mtk_dpi: Add dpi config for mt8192 Jitao Shi
@ 2021-02-08  1:26 ` Jitao Shi
  2 siblings, 0 replies; 4+ messages in thread
From: Jitao Shi @ 2021-02-08  1:26 UTC (permalink / raw)
  To: Chun-Kuang Hu, Philipp Zabel
  Cc: airlied, daniel, robh+dt, matthias.bgg, srv_heupstream,
	yingjoe.chen, eddie.huang, ck.hu, dri-devel, devicetree,
	stonea168, huijuan.xie, linux-kernel, linux-arm-kernel,
	linux-mediatek, shuijing.li, Jitao Shi

Add compatible "mediatek,mt8192-dpi" for the mt8192 dpi.

Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index 6cdb734c91a9..2f566f19e6e0 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -22,6 +22,7 @@ properties:
       - mediatek,mt7623-dpi
       - mediatek,mt8173-dpi
       - mediatek,mt8183-dpi
+      - mediatek,mt8192-dpi
 
   reg:
     maxItems: 1
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-08  1:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08  1:26 [PATCH v2 0/3] Add check for max clock rate in mode_valid Jitao Shi
2021-02-08  1:26 ` [PATCH v2 1/3] drm/mediatek: mtk_dpi: " Jitao Shi
2021-02-08  1:26 ` [PATCH v2 2/3] drm/mediatek: mtk_dpi: Add dpi config for mt8192 Jitao Shi
2021-02-08  1:26 ` [PATCH v2 3/3] dt-bindings: mediatek,dpi: add mt8192 to mediatek,dpi Jitao Shi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).