From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Daniel Kiss <Daniel.Kiss@arm.com>,
Denis Nikitin <denik@chromium.org>, Al Grant <al.grant@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/8] tools headers UAPI: Update tools' copy of linux/coresight-pmu.h
Date: Mon, 8 Feb 2021 10:34:26 -0700 [thread overview]
Message-ID: <20210208173426.GA2077938@xps15> (raw)
In-Reply-To: <20210206150833.42120-3-leo.yan@linaro.org>
On Sat, Feb 06, 2021 at 11:08:27PM +0800, Leo Yan wrote:
> To get the changes in the commit:
>
> "coresight: etm-perf: Clarify comment on perf options".
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> tools/include/linux/coresight-pmu.h | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/tools/include/linux/coresight-pmu.h b/tools/include/linux/coresight-pmu.h
> index b0e35eec6499..5dc47cfdcf07 100644
> --- a/tools/include/linux/coresight-pmu.h
> +++ b/tools/include/linux/coresight-pmu.h
> @@ -10,11 +10,18 @@
> #define CORESIGHT_ETM_PMU_NAME "cs_etm"
> #define CORESIGHT_ETM_PMU_SEED 0x10
>
> -/* ETMv3.5/PTM's ETMCR config bit */
> -#define ETM_OPT_CYCACC 12
> -#define ETM_OPT_CTXTID 14
> -#define ETM_OPT_TS 28
> -#define ETM_OPT_RETSTK 29
> +/*
> + * Below are the definition of bit offsets for perf option, and works as
> + * arbitrary values for all ETM versions.
> + *
> + * Most of them are orignally from ETMv3.5/PTM's ETMCR config, therefore,
> + * ETMv3.5/PTM doesn't define ETMCR config bits with prefix "ETM3_" and
> + * directly use below macros as config bits.
> + */
> +#define ETM_OPT_CYCACC 12
> +#define ETM_OPT_CTXTID 14
> +#define ETM_OPT_TS 28
> +#define ETM_OPT_RETSTK 29
>
> /* ETMv4 CONFIGR programming bits for the ETM OPTs */
> #define ETM4_CFG_BIT_CYCACC 4
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-02-08 19:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 15:08 [PATCH v3 0/8] coresight: etm-perf: Fix pid tracing with VHE Leo Yan
2021-02-06 15:08 ` [PATCH v3 1/8] coresight: etm-perf: Clarify comment on perf options Leo Yan
2021-02-06 15:08 ` [PATCH v3 2/8] tools headers UAPI: Update tools' copy of linux/coresight-pmu.h Leo Yan
2021-02-08 17:34 ` Mathieu Poirier [this message]
2021-02-06 15:08 ` [PATCH v3 3/8] coresight: etm-perf: Support PID tracing for kernel at EL2 Leo Yan
2021-02-06 15:08 ` [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Leo Yan
2021-02-08 20:46 ` Mathieu Poirier
2021-02-09 1:58 ` Leo Yan
2021-03-05 17:29 ` Arnaldo Carvalho de Melo
2021-03-06 3:05 ` Leo Yan
2021-02-06 15:08 ` [PATCH v3 5/8] perf cs-etm: Support PID tracing in config Leo Yan
2021-02-08 18:55 ` Mathieu Poirier
2021-03-05 17:30 ` Arnaldo Carvalho de Melo
2021-02-06 15:08 ` [PATCH v3 6/8] perf cs-etm: Add helper cs_etm__get_pid_fmt() Leo Yan
2021-02-08 20:32 ` Mathieu Poirier
2021-02-11 12:36 ` Suzuki K Poulose
2021-02-06 15:08 ` [PATCH v3 7/8] perf cs-etm: Detect pid in VMID for kernel running at EL2 Leo Yan
2021-02-08 20:33 ` Mathieu Poirier
2021-02-06 15:08 ` [PATCH v3 8/8] Documentation: coresight: Add PID tracing description Leo Yan
2021-02-08 20:50 ` Mathieu Poirier
2021-02-08 21:15 ` Mike Leach
2021-02-11 12:38 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208173426.GA2077938@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=Daniel.Kiss@arm.com \
--cc=acme@kernel.org \
--cc=al.grant@arm.com \
--cc=corbet@lwn.net \
--cc=coresight@lists.linaro.org \
--cc=denik@chromium.org \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).