From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Daniel Kiss <Daniel.Kiss@arm.com>,
Denis Nikitin <denik@chromium.org>, Al Grant <al.grant@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/8] perf cs-etm: Add helper cs_etm__get_pid_fmt()
Date: Mon, 8 Feb 2021 13:32:10 -0700 [thread overview]
Message-ID: <20210208203210.GC2077938@xps15> (raw)
In-Reply-To: <20210206150833.42120-7-leo.yan@linaro.org>
On Sat, Feb 06, 2021 at 11:08:31PM +0800, Leo Yan wrote:
> This patch adds helper function cs_etm__get_pid_fmt(), by passing
> parameter "traceID", it returns the PID format.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> tools/perf/util/cs-etm.c | 42 ++++++++++++++++++++++++++++++++++++++++
> tools/perf/util/cs-etm.h | 1 +
> 2 files changed, 43 insertions(+)
>
> diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
> index a2a369e2fbb6..b9c1d329a7f1 100644
> --- a/tools/perf/util/cs-etm.c
> +++ b/tools/perf/util/cs-etm.c
> @@ -7,6 +7,7 @@
> */
>
> #include <linux/bitops.h>
> +#include <linux/coresight-pmu.h>
> #include <linux/err.h>
> #include <linux/kernel.h>
> #include <linux/log2.h>
> @@ -156,6 +157,47 @@ int cs_etm__get_cpu(u8 trace_chan_id, int *cpu)
> return 0;
> }
>
> +/*
> + * The returned PID format is presented by two bits:
> + *
> + * Bit ETM_OPT_CTXTID: CONTEXTIDR or CONTEXTIDR_EL1 is traced;
> + * Bit ETM_OPT_CTXTID2: CONTEXTIDR_EL2 is traced.
> + *
> + * It's possible that the two bits ETM_OPT_CTXTID and ETM_OPT_CTXTID2
> + * are enabled at the same time when the session runs on an EL2 kernel.
> + * This means the CONTEXTIDR_EL1 and CONTEXTIDR_EL2 both will be
> + * recorded in the trace data, the tool will selectively use
> + * CONTEXTIDR_EL2 as PID.
> + */
> +int cs_etm__get_pid_fmt(u8 trace_chan_id, u64 *pid_fmt)
> +{
> + struct int_node *inode;
> + u64 *metadata, val;
> +
> + inode = intlist__find(traceid_list, trace_chan_id);
> + if (!inode)
> + return -EINVAL;
> +
> + metadata = inode->priv;
> +
> + if (metadata[CS_ETM_MAGIC] == __perf_cs_etmv3_magic) {
> + val = metadata[CS_ETM_ETMCR];
> + /* CONTEXTIDR is traced */
> + if (val & BIT(ETM_OPT_CTXTID))
> + *pid_fmt = BIT(ETM_OPT_CTXTID);
> + } else {
> + val = metadata[CS_ETMV4_TRCCONFIGR];
> + /* CONTEXTIDR_EL2 is traced */
> + if (val & (BIT(ETM4_CFG_BIT_VMID) | BIT(ETM4_CFG_BIT_VMID_OPT)))
> + *pid_fmt = BIT(ETM_OPT_CTXTID2);
> + /* CONTEXTIDR_EL1 is traced */
> + else if (val & BIT(ETM4_CFG_BIT_CTXTID))
> + *pid_fmt = BIT(ETM_OPT_CTXTID);
> + }
> +
> + return 0;
> +}
> +
> void cs_etm__etmq_set_traceid_queue_timestamp(struct cs_etm_queue *etmq,
> u8 trace_chan_id)
> {
> diff --git a/tools/perf/util/cs-etm.h b/tools/perf/util/cs-etm.h
> index 4ad925d6d799..7cc3bba0017d 100644
> --- a/tools/perf/util/cs-etm.h
> +++ b/tools/perf/util/cs-etm.h
> @@ -173,6 +173,7 @@ struct cs_etm_packet_queue {
> int cs_etm__process_auxtrace_info(union perf_event *event,
> struct perf_session *session);
> int cs_etm__get_cpu(u8 trace_chan_id, int *cpu);
> +int cs_etm__get_pid_fmt(u8 trace_chan_id, u64 *pid_fmt);
> int cs_etm__etmq_set_tid(struct cs_etm_queue *etmq,
> pid_t tid, u8 trace_chan_id);
> bool cs_etm__etmq_is_timeless(struct cs_etm_queue *etmq);
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-02-08 21:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 15:08 [PATCH v3 0/8] coresight: etm-perf: Fix pid tracing with VHE Leo Yan
2021-02-06 15:08 ` [PATCH v3 1/8] coresight: etm-perf: Clarify comment on perf options Leo Yan
2021-02-06 15:08 ` [PATCH v3 2/8] tools headers UAPI: Update tools' copy of linux/coresight-pmu.h Leo Yan
2021-02-08 17:34 ` Mathieu Poirier
2021-02-06 15:08 ` [PATCH v3 3/8] coresight: etm-perf: Support PID tracing for kernel at EL2 Leo Yan
2021-02-06 15:08 ` [PATCH v3 4/8] perf cs-etm: Fix bitmap for option Leo Yan
2021-02-08 20:46 ` Mathieu Poirier
2021-02-09 1:58 ` Leo Yan
2021-03-05 17:29 ` Arnaldo Carvalho de Melo
2021-03-06 3:05 ` Leo Yan
2021-02-06 15:08 ` [PATCH v3 5/8] perf cs-etm: Support PID tracing in config Leo Yan
2021-02-08 18:55 ` Mathieu Poirier
2021-03-05 17:30 ` Arnaldo Carvalho de Melo
2021-02-06 15:08 ` [PATCH v3 6/8] perf cs-etm: Add helper cs_etm__get_pid_fmt() Leo Yan
2021-02-08 20:32 ` Mathieu Poirier [this message]
2021-02-11 12:36 ` Suzuki K Poulose
2021-02-06 15:08 ` [PATCH v3 7/8] perf cs-etm: Detect pid in VMID for kernel running at EL2 Leo Yan
2021-02-08 20:33 ` Mathieu Poirier
2021-02-06 15:08 ` [PATCH v3 8/8] Documentation: coresight: Add PID tracing description Leo Yan
2021-02-08 20:50 ` Mathieu Poirier
2021-02-08 21:15 ` Mike Leach
2021-02-11 12:38 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208203210.GC2077938@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=Daniel.Kiss@arm.com \
--cc=acme@kernel.org \
--cc=al.grant@arm.com \
--cc=corbet@lwn.net \
--cc=coresight@lists.linaro.org \
--cc=denik@chromium.org \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).