From: "Enrico Weigelt, metux IT consult" <info@metux.net>
To: linux-kernel@vger.kernel.org
Cc: rafael@kernel.org, info@metux.net, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, robh+dt@kernel.org,
frowand.list@gmail.com, pantelis.antoniou@konsulko.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org
Subject: [RFC PATCH 03/12] of: base: record root node in interator and use it for phandle lookup
Date: Mon, 8 Feb 2021 23:21:54 +0100 [thread overview]
Message-ID: <20210208222203.22335-4-info@metux.net> (raw)
In-Reply-To: <20210208222203.22335-1-info@metux.net>
For detached oftree support, find the root node and record it, on iterator
creation. If we find the root of the global oftree, record NULL, in order to
have a clear distinction between detached and non-detached cases. The recorded
root node is then used for resolving phandles.
Note that in the detached case, phandle cache can't be used, so we have a
little performance penalty on repeated phandle lookups.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/of/base.c | 13 ++++++++++++-
include/linux/of.h | 1 +
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 6b3d1e817808..e5ef611ed233 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1249,6 +1249,7 @@ int of_phandle_iterator_init(struct of_phandle_iterator *it,
{
const __be32 *list;
int size;
+ struct device_node *walk;
memset(it, 0, sizeof(*it));
@@ -1270,6 +1271,16 @@ int of_phandle_iterator_init(struct of_phandle_iterator *it,
it->phandle_end = list;
it->cur = list;
+ /*
+ * find the root of our tree and record it, if we're dealing with an
+ * detached oftree - in non-detached case, we record NULL, for clear
+ * distinction between these two cases.
+ */
+ for (walk=(struct device_node*)np;
+ walk->parent;
+ walk=(struct device_node*)walk->parent);
+ it->root = ((walk == of_root) ? NULL : walk);
+
return 0;
}
EXPORT_SYMBOL_GPL(of_phandle_iterator_init);
@@ -1297,7 +1308,7 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)
* Find the provider node and parse the #*-cells property to
* determine the argument length.
*/
- it->node = of_find_node_by_phandle(it->phandle);
+ it->node = of_find_node_by_phandle_from(it->root, it->phandle);
if (it->cells_name) {
if (!it->node) {
diff --git a/include/linux/of.h b/include/linux/of.h
index c285141653e5..dbf2c7442389 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -82,6 +82,7 @@ struct of_phandle_iterator {
const char *cells_name;
int cell_count;
const struct device_node *parent;
+ struct device_node *root;
/* List size information */
const __be32 *list_end;
--
2.11.0
next prev parent reply other threads:[~2021-02-08 22:26 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 22:21 RFC: oftree based setup of composite board devices Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 01/12] of: base: improve error message in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 02/12] of: base: introduce of_find_node_by_phandle_from() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` Enrico Weigelt, metux IT consult [this message]
2021-02-08 22:21 ` [RFC PATCH 04/12] of: base: introduce of_match_string() Enrico Weigelt, metux IT consult
2021-02-08 23:52 ` Rob Herring
2021-02-08 22:21 ` [RFC PATCH 05/12] of: kobj: __of_attach_node_sysfs(): add optional basename parameter Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 06/12] of: kobj: introduce of_attach_tree_sysfs() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support Enrico Weigelt, metux IT consult
2021-02-11 9:57 ` Bartosz Golaszewski
2021-03-01 14:51 ` Linus Walleij
2021-03-11 10:17 ` Enrico Weigelt, metux IT consult
2021-03-11 10:42 ` Andy Shevchenko
2021-03-18 8:00 ` Enrico Weigelt, metux IT consult
2021-03-25 9:09 ` Linus Walleij
2021-02-08 22:21 ` [RFC PATCH 08/12] drivers: base: introduce bus_remove_device_by_name() Enrico Weigelt, metux IT consult
2021-02-08 22:22 ` [RFC PATCH 09/12] drivers: base: reintroduce find_bus() Enrico Weigelt, metux IT consult
2021-02-13 10:20 ` Greg KH
2021-02-23 20:13 ` Enrico Weigelt, metux IT consult
2021-02-24 8:00 ` Greg KH
2021-02-24 15:30 ` Enrico Weigelt, metux IT consult
2021-02-24 16:28 ` Greg KH
2021-02-08 22:22 ` [RFC PATCH 10/12] export bus_get() / bus_put() Enrico Weigelt, metux IT consult
2021-02-08 22:22 ` [RFC PATCH 11/12] platform/x86: skeleton for oftree based board device initialization Enrico Weigelt, metux IT consult
2021-02-10 10:32 ` Andy Shevchenko
2021-02-12 9:58 ` Linus Walleij
2021-02-12 11:54 ` Enrico Weigelt, metux IT consult
2021-02-15 1:18 ` Frank Rowand
2021-02-23 20:41 ` Enrico Weigelt, metux IT consult
2021-03-02 13:33 ` Linus Walleij
2021-02-08 22:22 ` [RFC PATCH 12/12] platform/x86/of: add support for PC Engines APU v2/3/4 boards Enrico Weigelt, metux IT consult
2021-02-09 0:06 ` Rob Herring
2021-02-11 13:15 ` Enrico Weigelt, metux IT consult
2021-03-01 14:55 ` Linus Walleij
2021-02-08 23:48 ` RFC: oftree based setup of composite board devices Rob Herring
2021-02-10 22:13 ` Enrico Weigelt, metux IT consult
2021-02-15 1:12 ` Frank Rowand
2021-02-15 15:35 ` Andy Shevchenko
2021-02-24 13:00 ` Enrico Weigelt, metux IT consult
2021-02-24 23:14 ` Frank Rowand
2021-03-05 18:29 ` Rob Herring
2021-02-10 10:30 ` Andy Shevchenko
2021-02-11 11:08 ` Enrico Weigelt, metux IT consult
2021-02-11 11:41 ` Andy Shevchenko
2021-02-11 17:01 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208222203.22335-4-info@metux.net \
--to=info@metux.net \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).