From: Rob Herring <robh+dt@kernel.org>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Frank Rowand <frowand.list@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 12/12] platform/x86/of: add support for PC Engines APU v2/3/4 boards
Date: Mon, 8 Feb 2021 18:06:03 -0600 [thread overview]
Message-ID: <CAL_JsqJw+EjMoc92e-XMjn=0wat3TmcToHU1V2rW9UB9UhmDEA@mail.gmail.com> (raw)
In-Reply-To: <20210208222203.22335-13-info@metux.net>
On Mon, Feb 8, 2021 at 4:22 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Add oftree based support for PC Engines APUv2/3/4 board family.
> This is entirely separate from the existing pcengines-apuv2 driver.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/platform/of/Kconfig | 15 ++++++++
> drivers/platform/of/Makefile | 2 +
> drivers/platform/of/apu2x.dts | 86 +++++++++++++++++++++++++++++++++++++++++++
> drivers/platform/of/init.c | 7 ++++
> 4 files changed, 110 insertions(+)
> create mode 100644 drivers/platform/of/apu2x.dts
>
> diff --git a/drivers/platform/of/Kconfig b/drivers/platform/of/Kconfig
> index a0b5a641a7c6..e13b6ee8c316 100644
> --- a/drivers/platform/of/Kconfig
> +++ b/drivers/platform/of/Kconfig
> @@ -38,4 +38,19 @@ config PLATFORM_OF_DRV_SYSFS_DT
> Say Y here to enable exposing device tree nodes at
> /sys/firmware/devicetree.
>
> +config PLATFORM_OF_DRV_PCENGINES_APU2
> + bool "Support PC Engines APU2/3/4 mainboards"
> + depends on INPUT
> + depends on GPIOLIB
> + depends on X86
> + select GPIO_AMD_FCH
> + select KEYBOARD_GPIO_POLLED
> + select LEDS_GPIO
> + select INPUT_KEYBOARD
> + help
> + Say Y to enable devicetree based support for PC Engines APU2/3/4
> + mainboards. This supersedes the older pcengines-apu2 driver.
> +
> + Supports Gpios, front panel LEDs and front button.
> +
> endif # PLATFORM_OF_DRV
> diff --git a/drivers/platform/of/Makefile b/drivers/platform/of/Makefile
> index 84cf3003c500..dd4a13c18f16 100644
> --- a/drivers/platform/of/Makefile
> +++ b/drivers/platform/of/Makefile
> @@ -2,4 +2,6 @@
>
> ofboard-y := init.o drv.o
>
> +ofboard-$(CONFIG_PLATFORM_OF_DRV_PCENGINES_APU2) += apu2x.dtb.o
> +
> obj-$(CONFIG_PLATFORM_OF_DRV) += ofboard.o
> diff --git a/drivers/platform/of/apu2x.dts b/drivers/platform/of/apu2x.dts
> new file mode 100644
> index 000000000000..c16a59eb2a0e
> --- /dev/null
> +++ b/drivers/platform/of/apu2x.dts
> @@ -0,0 +1,86 @@
> +/dts-v1/;
> +
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/amd-fch-gpio.h>
> +
> +/ {
> + apu2x {
> + compatible = "virtual,dmi-board";
> + dmi-sys-vendor = "PC engines";
> + dmi-board-name =
> + "APU2",
> + "apu2",
> + "PC engines apu2",
> + "APU3",
> + "apu3",
> + "PC engines apu3",
> + "APU4",
> + "apu4",
> + "PC engines apu4";
I think these DMI properties just need to be the compatible string(s).
We already have a way to do matching with DT and don't need a
secondary way. If you can
> + unbind {
> + acpi = "PNP0076:00", "PNP0B00:00";
> + platform = "platform-framebuffer.0", "PNP0103:00";
This node really needs to go. It's clearly Linuxisms. It either has to
go in the kernel or userspace.
> + };
> + devices {
> + gpio1: gpio1 {
> + compatible = "amd,fch-gpio";
This of course will need to be documented.
> + gpio-controller;
> + status = "okay";
nit: That's the default.
> + ngpios=<7>;
> + #gpio-cells=<2>;
> + gpio-regs = <
> + AMD_FCH_GPIO_REG_GPIO57 // led1
> + AMD_FCH_GPIO_REG_GPIO58 // led2
> + AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 // led3
> + AMD_FCH_GPIO_REG_GPIO32_GE1 // modesw
> + AMD_FCH_GPIO_REG_GPIO33_GE2 // simawap
> + AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 // mpcie2
> + AMD_FCH_GPIO_REG_GPIO51 // mpcie3
> + >;
> + gpio-line-names =
> + "front-led1",
> + "front-led2",
> + "front-led3",
> + "front-button",
> + "simswap",
> + "mpcie2_reset",
> + "mpcie3_reset";
> + };
> + front-leds {
> + compatible = "gpio-leds";
> + led@0 {
> + gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "keep";
> + label = "apu:green:1";
> + };
> + led@1 {
> + gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "keep";
> + label = "apu:green:2";
> + };
> + led@2 {
> + gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "keep";
> + label = "apu:green:3";
> + };
> + };
> + front-keys {
> + compatible = "gpio-keys-polled";
> + address-cells = <1>;
> + size-cells = <0>;
> + poll-interval = <100>;
> + button@1 {
> + linux,code = <KEY_RESTART>;
> + label = "front button";
> + debounce-interval = <10>;
> + gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>;
> + };
> + };
> + };
> + };
> +};
> diff --git a/drivers/platform/of/init.c b/drivers/platform/of/init.c
> index 3b8373cda77a..195120dad26d 100644
> --- a/drivers/platform/of/init.c
> +++ b/drivers/platform/of/init.c
> @@ -47,7 +47,14 @@ static ssize_t fdt_image_raw_read(struct file *filep, struct kobject *kobj,
> return count;
> }
>
> +#ifdef CONFIG_PLATFORM_OF_DRV_PCENGINES_APU2
> +DECLARE_FDT_EXTERN(apu2x);
> +#endif
> +
> static struct fdt_image fdt[] = {
> +#ifdef CONFIG_PLATFORM_OF_DRV_PCENGINES_APU2
> + FDT_IMAGE_ENT(apu2x)
> +#endif
> };
>
> static int __init ofdrv_init_sysfs(struct fdt_image *image)
> --
> 2.11.0
>
next prev parent reply other threads:[~2021-02-09 0:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 22:21 RFC: oftree based setup of composite board devices Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 01/12] of: base: improve error message in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 02/12] of: base: introduce of_find_node_by_phandle_from() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 03/12] of: base: record root node in interator and use it for phandle lookup Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 04/12] of: base: introduce of_match_string() Enrico Weigelt, metux IT consult
2021-02-08 23:52 ` Rob Herring
2021-02-08 22:21 ` [RFC PATCH 05/12] of: kobj: __of_attach_node_sysfs(): add optional basename parameter Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 06/12] of: kobj: introduce of_attach_tree_sysfs() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support Enrico Weigelt, metux IT consult
2021-02-11 9:57 ` Bartosz Golaszewski
2021-03-01 14:51 ` Linus Walleij
2021-03-11 10:17 ` Enrico Weigelt, metux IT consult
2021-03-11 10:42 ` Andy Shevchenko
2021-03-18 8:00 ` Enrico Weigelt, metux IT consult
2021-03-25 9:09 ` Linus Walleij
2021-02-08 22:21 ` [RFC PATCH 08/12] drivers: base: introduce bus_remove_device_by_name() Enrico Weigelt, metux IT consult
2021-02-08 22:22 ` [RFC PATCH 09/12] drivers: base: reintroduce find_bus() Enrico Weigelt, metux IT consult
2021-02-13 10:20 ` Greg KH
2021-02-23 20:13 ` Enrico Weigelt, metux IT consult
2021-02-24 8:00 ` Greg KH
2021-02-24 15:30 ` Enrico Weigelt, metux IT consult
2021-02-24 16:28 ` Greg KH
2021-02-08 22:22 ` [RFC PATCH 10/12] export bus_get() / bus_put() Enrico Weigelt, metux IT consult
2021-02-08 22:22 ` [RFC PATCH 11/12] platform/x86: skeleton for oftree based board device initialization Enrico Weigelt, metux IT consult
2021-02-10 10:32 ` Andy Shevchenko
2021-02-12 9:58 ` Linus Walleij
2021-02-12 11:54 ` Enrico Weigelt, metux IT consult
2021-02-15 1:18 ` Frank Rowand
2021-02-23 20:41 ` Enrico Weigelt, metux IT consult
2021-03-02 13:33 ` Linus Walleij
2021-02-08 22:22 ` [RFC PATCH 12/12] platform/x86/of: add support for PC Engines APU v2/3/4 boards Enrico Weigelt, metux IT consult
2021-02-09 0:06 ` Rob Herring [this message]
2021-02-11 13:15 ` Enrico Weigelt, metux IT consult
2021-03-01 14:55 ` Linus Walleij
2021-02-08 23:48 ` RFC: oftree based setup of composite board devices Rob Herring
2021-02-10 22:13 ` Enrico Weigelt, metux IT consult
2021-02-15 1:12 ` Frank Rowand
2021-02-15 15:35 ` Andy Shevchenko
2021-02-24 13:00 ` Enrico Weigelt, metux IT consult
2021-02-24 23:14 ` Frank Rowand
2021-03-05 18:29 ` Rob Herring
2021-02-10 10:30 ` Andy Shevchenko
2021-02-11 11:08 ` Enrico Weigelt, metux IT consult
2021-02-11 11:41 ` Andy Shevchenko
2021-02-11 17:01 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJw+EjMoc92e-XMjn=0wat3TmcToHU1V2rW9UB9UhmDEA@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).