* [PATCH] dt-bindings: Use portable sort for version cmp
@ 2021-02-01 16:58 Iskren Chernev
2021-02-09 20:57 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Iskren Chernev @ 2021-02-01 16:58 UTC (permalink / raw)
To: Rob Herring
Cc: Iskren Chernev, Rob Herring, Masahiro Yamada, Andrei Ziureaev,
Cristian Ciocaltea, devicetree, linux-kernel
sort -C is like sort -c >/dev/null but less portable. It fails on
busybox sort (i.e alpine linux).
Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
Fixes: ea5b8b5eb004 ("dt-bindings: Add a minimum version check for dtschema")
---
Documentation/devicetree/bindings/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index 90fcad98984d..780e5618ec0a 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -10,7 +10,7 @@ DT_SCHEMA_MIN_VERSION = 2020.8.1
PHONY += check_dtschema_version
check_dtschema_version:
@{ echo $(DT_SCHEMA_MIN_VERSION); \
- $(DT_DOC_CHECKER) --version 2>/dev/null || echo 0; } | sort -VC || \
+ $(DT_DOC_CHECKER) --version 2>/dev/null || echo 0; } | sort -Vc >/dev/null || \
{ echo "ERROR: dtschema minimum version is v$(DT_SCHEMA_MIN_VERSION)" >&2; false; }
quiet_cmd_extract_ex = DTEX $@
base-commit: fd821bf0ed9a7db09d2e007df697f4d9ecfda99a
prerequisite-patch-id: c90e3d48df0672dab84da1b294374598bfc45db8
prerequisite-patch-id: f0b48cda55170cf82855daa6f7b4edfdba83d90c
prerequisite-patch-id: 48482c0c3e2797459e311f73db1828f2531bd11c
prerequisite-patch-id: 5512fd0c8367c8c8a2ace8003b533057422e1437
prerequisite-patch-id: 1635c0e78c99506fd2710f54be4e5fc5980712a6
prerequisite-patch-id: e80dacf2da55197be027f297617868832ddabfc9
prerequisite-patch-id: bd3efb4ced6ceb2c6a50dcd8527ea4d6d19baf5d
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: Use portable sort for version cmp
2021-02-01 16:58 [PATCH] dt-bindings: Use portable sort for version cmp Iskren Chernev
@ 2021-02-09 20:57 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-02-09 20:57 UTC (permalink / raw)
To: Iskren Chernev
Cc: Andrei Ziureaev, Masahiro Yamada, devicetree, Rob Herring,
linux-kernel, Cristian Ciocaltea
On Mon, 01 Feb 2021 18:58:28 +0200, Iskren Chernev wrote:
> sort -C is like sort -c >/dev/null but less portable. It fails on
> busybox sort (i.e alpine linux).
>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> Fixes: ea5b8b5eb004 ("dt-bindings: Add a minimum version check for dtschema")
> ---
> Documentation/devicetree/bindings/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-10 0:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 16:58 [PATCH] dt-bindings: Use portable sort for version cmp Iskren Chernev
2021-02-09 20:57 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).