* [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static
@ 2021-02-10 7:56 Wei Yongjun
2021-03-18 0:23 ` Chun-Kuang Hu
2021-04-01 9:28 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2021-02-10 7:56 UTC (permalink / raw)
To: Hulk Robot, Matthias Brugger, CK Hu
Cc: Wei Yongjun, linux-arm-kernel, linux-mediatek, linux-kernel
The sparse tool complains as follows:
drivers/soc/mediatek/mtk-mutex.c:464:24: warning:
symbol 'mtk_mutex_driver' was not declared. Should it be static?
This symbol is not used outside of mtk-mutex.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/soc/mediatek/mtk-mutex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index f531b119da7a..3a315a62e783 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = {
};
MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);
-struct platform_driver mtk_mutex_driver = {
+static struct platform_driver mtk_mutex_driver = {
.probe = mtk_mutex_probe,
.remove = mtk_mutex_remove,
.driver = {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static
2021-02-10 7:56 [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static Wei Yongjun
@ 2021-03-18 0:23 ` Chun-Kuang Hu
2021-04-01 9:28 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Chun-Kuang Hu @ 2021-03-18 0:23 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hulk Robot, Matthias Brugger, CK Hu,
moderated list:ARM/Mediatek SoC support, linux-kernel, Linux ARM
Hi, Yongjun:
Wei Yongjun <weiyongjun1@huawei.com> 於 2021年2月10日 週三 下午3:49寫道:
>
> The sparse tool complains as follows:
>
> drivers/soc/mediatek/mtk-mutex.c:464:24: warning:
> symbol 'mtk_mutex_driver' was not declared. Should it be static?
>
> This symbol is not used outside of mtk-mutex.c, so this
> commit marks it static.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/soc/mediatek/mtk-mutex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index f531b119da7a..3a315a62e783 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = {
> };
> MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);
>
> -struct platform_driver mtk_mutex_driver = {
> +static struct platform_driver mtk_mutex_driver = {
> .probe = mtk_mutex_probe,
> .remove = mtk_mutex_remove,
> .driver = {
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static
2021-02-10 7:56 [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static Wei Yongjun
2021-03-18 0:23 ` Chun-Kuang Hu
@ 2021-04-01 9:28 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2021-04-01 9:28 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot, CK Hu
Cc: linux-arm-kernel, linux-mediatek, linux-kernel
On 10/02/2021 08:56, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/soc/mediatek/mtk-mutex.c:464:24: warning:
> symbol 'mtk_mutex_driver' was not declared. Should it be static?
>
> This symbol is not used outside of mtk-mutex.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to v5.12-next/soc
Thanks!
> ---
> drivers/soc/mediatek/mtk-mutex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index f531b119da7a..3a315a62e783 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -461,7 +461,7 @@ static const struct of_device_id mutex_driver_dt_match[] = {
> };
> MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);
>
> -struct platform_driver mtk_mutex_driver = {
> +static struct platform_driver mtk_mutex_driver = {
> .probe = mtk_mutex_probe,
> .remove = mtk_mutex_remove,
> .driver = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-01 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 7:56 [PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static Wei Yongjun
2021-03-18 0:23 ` Chun-Kuang Hu
2021-04-01 9:28 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).