From: Dan Carpenter <dan.carpenter@oracle.com>
To: karthek <mail@karthek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc
Date: Wed, 10 Feb 2021 12:01:20 +0300 [thread overview]
Message-ID: <20210210090120.GU20820@kadam> (raw)
In-Reply-To: <CAJ5zXr1hJ6ts7Gqi_vfaJceZ8qKPgFk479h4sA9AxFrAdB8vHw@mail.gmail.com>
On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote:
> On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > > @@ -789,7 +759,7 @@ static void phy_PostSetBwMode8723B(struct adapter *Adapter)
> > >
> > > PHY_SetBBReg(Adapter, rFPGA1_RFMOD, bRFMOD, 0x0);
> > >
> > > -/* PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */
> > > + /*PHY_SetBBReg(Adapter, rFPGA0_AnalogParameter2, BIT10, 1); */
> >
> > This format is wrong. Anyway, just delete the commented out code.
> >
> > regards,
> > dan carpenter
> >
>
> how can i delete that, i have no idea what this driver does
> i'm just fixing coding style issues for eudyptula challenge.
> i dont think its a good idea to delete the code without knowing its
> purpose even though its commented out
Commented code obviously doesn't do anything at all?
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-10 9:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 21:12 [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc karthik alapati
2021-02-10 8:06 ` Dan Carpenter
2021-02-10 8:58 ` karthek
2021-02-10 9:01 ` Dan Carpenter [this message]
[not found] ` <CAJ5zXr1OW+RfNNuXOZDjUvm=EKz5C9=GPc243z3Wk_qc3N=6sQ@mail.gmail.com>
2021-02-10 9:27 ` karthek
2021-02-10 12:06 ` Dan Carpenter
2021-02-10 19:10 karthik alapati
2021-02-10 19:18 ` karthek
2021-02-11 10:04 ` Greg Kroah-Hartman
2021-02-11 10:39 ` karthek
2021-02-11 11:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210090120.GU20820@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@karthek.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).