linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: kostap@marvell.com
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vladimir.vid@sartura.hr,
	tmn505@gmail.com, luka.kovacic@sartura.hr,
	sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com,
	andrew@lunn.ch, vkoul@kernel.org, kishon@ti.com,
	miquel.raynal@bootlin.com, mw@semihalf.com, jaz@semihalf.com,
	nadavh@marvell.com, stefanc@marvell.com, bpeled@marvell.com
Subject: Re: [PATCH v5 1/5] Documentation/bindings: phy: update references to cp11x
Date: Wed, 10 Feb 2021 13:03:22 -0600	[thread overview]
Message-ID: <20210210190322.GA2549599@robh.at.kernel.org> (raw)
In-Reply-To: <20210210131604.28806-2-kostap@marvell.com>

On Wed, Feb 10, 2021 at 03:16:00PM +0200, kostap@marvell.com wrote:
> From: Grzegorz Jaszczyk <jaz@semihalf.com>
> 
> The cp11x references in dts has changed, reflect it in comphy
> documentation.

Who cares. Examples are just examples.

If you really want to improve the binding, convert it to schema.

> Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
> ---
>  Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> index 8c60e6985950..5ffd0f55d010 100644
> --- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> @@ -42,22 +42,22 @@ Required properties (child nodes):
>  
>  Examples:
>  
> -	cpm_comphy: phy@120000 {
> +	CP11X_LABEL(comphy): phy@120000 {
>  		compatible = "marvell,comphy-cp110";
>  		reg = <0x120000 0x6000>;
> -		marvell,system-controller = <&cpm_syscon0>;
> -		clocks = <&CP110_LABEL(clk) 1 5>, <&CP110_LABEL(clk) 1 6>,
> -			 <&CP110_LABEL(clk) 1 18>;
> +		marvell,system-controller = <&CP11X_LABEL(syscon0)>;
> +		clocks = <&CP11X_LABEL(clk) 1 5>, <&CP11X_LABEL(clk) 1 6>,
> +			 <&CP11X_LABEL(clk) 1 18>;
>  		clock-names = "mg_clk", "mg_core_clk", "axi_clk";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		cpm_comphy0: phy@0 {
> +		CP11X_LABEL(comphy0): phy@0 {
>  			reg = <0>;
>  			#phy-cells = <1>;
>  		};
>  
> -		cpm_comphy1: phy@1 {
> +		CP11X_LABEL(comphy1): phy@1 {
>  			reg = <1>;
>  			#phy-cells = <1>;
>  		};
> -- 
> 2.17.1
> 

  reply	other threads:[~2021-02-10 19:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 13:15 [PATCH v5 0/5] DTS updates for Marvell Armada CN913x platforms kostap
2021-02-10 13:16 ` [PATCH v5 1/5] Documentation/bindings: phy: update references to cp11x kostap
2021-02-10 19:03   ` Rob Herring [this message]
2021-02-10 13:16 ` [PATCH v5 2/5] arch/arm64/boot/dts/marvell: fix NAND partitioning scheme kostap
2021-02-10 13:16 ` [PATCH v5 3/5] arm64: dts: cn913x: add device trees for topology B boards kostap
2021-02-10 13:16 ` [PATCH v5 4/5] dts: marvell: Enable 10G interfaces on 9130-DB and 9131-DB boards kostap
2021-02-10 14:02   ` Marcin Wojtas
2021-02-10 13:16 ` [PATCH v5 5/5] arm64: dts: add support for Marvell cn9130-crb platform kostap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210210190322.GA2549599@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bpeled@marvell.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jaz@semihalf.com \
    --cc=kishon@ti.com \
    --cc=kostap@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luka.kovacic@sartura.hr \
    --cc=miquel.raynal@bootlin.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    --cc=tmn505@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=vladimir.vid@sartura.hr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).