linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: kexec: Remove unused kexec_reinit callback
@ 2021-02-10 23:52 Joel Stanley
  2021-02-11  7:34 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Stanley @ 2021-02-10 23:52 UTC (permalink / raw)
  To: Russell King, Arnd Bergmann
  Cc: Andrew Jeffery, linux-arm-kernel, linux-kernel

The last (only?) user of this was removed in commit ba364fc752da ("ARM:
Kirkwood: Remove mach-kirkwood"), back in v3.17.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/include/asm/kexec.h    | 3 ---
 arch/arm/kernel/machine_kexec.c | 8 --------
 2 files changed, 11 deletions(-)

diff --git a/arch/arm/include/asm/kexec.h b/arch/arm/include/asm/kexec.h
index 22751b5b5735..e62832dcba76 100644
--- a/arch/arm/include/asm/kexec.h
+++ b/arch/arm/include/asm/kexec.h
@@ -56,9 +56,6 @@ static inline void crash_setup_regs(struct pt_regs *newregs,
 	}
 }
 
-/* Function pointer to optional machine-specific reinitialization */
-extern void (*kexec_reinit)(void);
-
 static inline unsigned long phys_to_boot_phys(phys_addr_t phys)
 {
 	return phys_to_idmap(phys);
diff --git a/arch/arm/kernel/machine_kexec.c b/arch/arm/kernel/machine_kexec.c
index 2b09dad7935e..f567032a09c0 100644
--- a/arch/arm/kernel/machine_kexec.c
+++ b/arch/arm/kernel/machine_kexec.c
@@ -147,11 +147,6 @@ void machine_crash_shutdown(struct pt_regs *regs)
 	pr_info("Loading crashdump kernel...\n");
 }
 
-/*
- * Function pointer to optional machine-specific reinitialization
- */
-void (*kexec_reinit)(void);
-
 void machine_kexec(struct kimage *image)
 {
 	unsigned long page_list, reboot_entry_phys;
@@ -187,9 +182,6 @@ void machine_kexec(struct kimage *image)
 
 	pr_info("Bye!\n");
 
-	if (kexec_reinit)
-		kexec_reinit();
-
 	soft_restart(reboot_entry_phys);
 }
 
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: kexec: Remove unused kexec_reinit callback
  2021-02-10 23:52 [PATCH] ARM: kexec: Remove unused kexec_reinit callback Joel Stanley
@ 2021-02-11  7:34 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2021-02-11  7:34 UTC (permalink / raw)
  To: Joel Stanley
  Cc: Russell King, Arnd Bergmann, Andrew Jeffery, Linux ARM, linux-kernel

On Thu, Feb 11, 2021 at 12:52 AM Joel Stanley <joel@jms.id.au> wrote:
>
> The last (only?) user of this was removed in commit ba364fc752da ("ARM:
> Kirkwood: Remove mach-kirkwood"), back in v3.17.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-11  7:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 23:52 [PATCH] ARM: kexec: Remove unused kexec_reinit callback Joel Stanley
2021-02-11  7:34 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).