* [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
@ 2021-02-11 21:26 Pritthijit Nath
2021-02-11 21:31 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Pritthijit Nath @ 2021-02-11 21:26 UTC (permalink / raw)
To: forest, gregkh, oscar.carter, tvboxspy
Cc: devel, linux-kernel, Pritthijit Nath
This change fixes a checkpatch CHECK style issue for "Alignment should
match open parenthesis".
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
drivers/staging/vt6656/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 5b8da06e3916..bcd4d467e03a 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
ret = vnt_rf_write_embedded(priv,
- vt3226d0_lo_current_table[hw_value]);
+ vt3226d0_lo_current_table[hw_value]);
if (ret)
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
2021-02-11 21:26 [PATCH] staging: vt6656: Fixed issue with alignment in rf.c Pritthijit Nath
@ 2021-02-11 21:31 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2021-02-11 21:31 UTC (permalink / raw)
To: Pritthijit Nath; +Cc: forest, oscar.carter, tvboxspy, devel, linux-kernel
On Fri, Feb 12, 2021 at 02:56:47AM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should
> match open parenthesis".
>
> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> ---
> drivers/staging/vt6656/rf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> index 5b8da06e3916..bcd4d467e03a 100644
> --- a/drivers/staging/vt6656/rf.c
> +++ b/drivers/staging/vt6656/rf.c
> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>
> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
> ret = vnt_rf_write_embedded(priv,
> - vt3226d0_lo_current_table[hw_value]);
> + vt3226d0_lo_current_table[hw_value]);
> if (ret)
> return ret;
> }
> --
> 2.25.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
@ 2021-02-11 21:37 Pritthijit Nath
0 siblings, 0 replies; 9+ messages in thread
From: Pritthijit Nath @ 2021-02-11 21:37 UTC (permalink / raw)
To: forest, gregkh, oscar.carter, tvboxspy
Cc: devel, linux-kernel, Pritthijit Nath
This change fixes a checkpatch CHECK style issue for "Alignment should
match open parenthesis".
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
Fixed trailing space in changelog.
drivers/staging/vt6656/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 5b8da06e3916..bcd4d467e03a 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
ret = vnt_rf_write_embedded(priv,
- vt3226d0_lo_current_table[hw_value]);
+ vt3226d0_lo_current_table[hw_value]);
if (ret)
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
@ 2021-02-11 15:24 Pritthijit Nath
2021-02-11 20:29 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Pritthijit Nath @ 2021-02-11 15:24 UTC (permalink / raw)
To: forest, gregkh, oscar.carter, tvboxspy
Cc: devel, linux-kernel, Pritthijit Nath
This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
drivers/staging/vt6656/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 5b8da06e3916..bcd4d467e03a 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
ret = vnt_rf_write_embedded(priv,
- vt3226d0_lo_current_table[hw_value]);
+ vt3226d0_lo_current_table[hw_value]);
if (ret)
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
2021-02-11 15:24 Pritthijit Nath
@ 2021-02-11 20:29 ` Greg KH
2021-02-11 20:37 ` Pritthijit Nath
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2021-02-11 20:29 UTC (permalink / raw)
To: Pritthijit Nath; +Cc: forest, oscar.carter, tvboxspy, devel, linux-kernel
On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
>
> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> ---
> drivers/staging/vt6656/rf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> index 5b8da06e3916..bcd4d467e03a 100644
> --- a/drivers/staging/vt6656/rf.c
> +++ b/drivers/staging/vt6656/rf.c
> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>
> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
> ret = vnt_rf_write_embedded(priv,
> - vt3226d0_lo_current_table[hw_value]);
> + vt3226d0_lo_current_table[hw_value]);
> if (ret)
> return ret;
> }
> --
> 2.25.1
Please run this change, with the changelog above, through
checkpatch.pl, fix that, and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
2021-02-11 20:29 ` Greg KH
@ 2021-02-11 20:37 ` Pritthijit Nath
2021-02-11 20:44 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Pritthijit Nath @ 2021-02-11 20:37 UTC (permalink / raw)
To: Greg KH; +Cc: forest, oscar.carter, tvboxspy, devel, linux-kernel
On 12/02/21 1:59 am, Greg KH wrote:
> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
>> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
>>
>> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
>> ---
>> drivers/staging/vt6656/rf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 5b8da06e3916..bcd4d467e03a 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>>
>> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
>> ret = vnt_rf_write_embedded(priv,
>> - vt3226d0_lo_current_table[hw_value]);
>> + vt3226d0_lo_current_table[hw_value]);
>> if (ret)
>> return ret;
>> }
>> --
>> 2.25.1
>
> Please run this change, with the changelog above, through
> checkpatch.pl, fix that, and resend.
>
> thanks,
>
> greg k-h
>
This change fixes a checkpatch CHECK style issue for "Alignment should
match open parenthesis".
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
drivers/staging/vt6656/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
index 5b8da06e3916..bcd4d467e03a 100644
--- a/drivers/staging/vt6656/rf.c
+++ b/drivers/staging/vt6656/rf.c
@@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
ret = vnt_rf_write_embedded(priv,
- vt3226d0_lo_current_table[hw_value]);
+ vt3226d0_lo_current_table[hw_value]);
if (ret)
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
2021-02-11 20:37 ` Pritthijit Nath
@ 2021-02-11 20:44 ` Greg KH
2021-02-11 21:02 ` Pritthijit Nath
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2021-02-11 20:44 UTC (permalink / raw)
To: Pritthijit Nath; +Cc: tvboxspy, devel, oscar.carter, forest, linux-kernel
On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote:
> On 12/02/21 1:59 am, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
> >> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
> >>
> >> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> >> ---
> >> drivers/staging/vt6656/rf.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> >> index 5b8da06e3916..bcd4d467e03a 100644
> >> --- a/drivers/staging/vt6656/rf.c
> >> +++ b/drivers/staging/vt6656/rf.c
> >> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
> >>
> >> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
> >> ret = vnt_rf_write_embedded(priv,
> >> - vt3226d0_lo_current_table[hw_value]);
> >> + vt3226d0_lo_current_table[hw_value]);
> >> if (ret)
> >> return ret;
> >> }
> >> --
> >> 2.25.1
> >
> > Please run this change, with the changelog above, through
> > checkpatch.pl, fix that, and resend.
> >
> > thanks,
> >
> > greg k-h
> >
>
> This change fixes a checkpatch CHECK style issue for "Alignment should
> match open parenthesis".
>
> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> ---
> drivers/staging/vt6656/rf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> index 5b8da06e3916..bcd4d467e03a 100644
> --- a/drivers/staging/vt6656/rf.c
> +++ b/drivers/staging/vt6656/rf.c
> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>
> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
> ret = vnt_rf_write_embedded(priv,
> - vt3226d0_lo_current_table[hw_value]);
> + vt3226d0_lo_current_table[hw_value]);
> if (ret)
> return ret;
> }
I can't take this type of submission, do you see other patches submitted
this way on the mailing list?
Also, you have a trailing space in your changelog text :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
2021-02-11 20:44 ` Greg KH
@ 2021-02-11 21:02 ` Pritthijit Nath
2021-02-11 21:15 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Pritthijit Nath @ 2021-02-11 21:02 UTC (permalink / raw)
To: Greg KH; +Cc: tvboxspy, devel, oscar.carter, forest, linux-kernel
On 12/02/21 2:14 am, Greg KH wrote:
> On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote:
>> On 12/02/21 1:59 am, Greg KH wrote:
>>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
>>>> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
>>>>
>>>> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
>>>> ---
>>>> drivers/staging/vt6656/rf.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>>>> index 5b8da06e3916..bcd4d467e03a 100644
>>>> --- a/drivers/staging/vt6656/rf.c
>>>> +++ b/drivers/staging/vt6656/rf.c
>>>> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>>>>
>>>> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
>>>> ret = vnt_rf_write_embedded(priv,
>>>> - vt3226d0_lo_current_table[hw_value]);
>>>> + vt3226d0_lo_current_table[hw_value]);
>>>> if (ret)
>>>> return ret;
>>>> }
>>>> --
>>>> 2.25.1
>>>
>>> Please run this change, with the changelog above, through
>>> checkpatch.pl, fix that, and resend.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> This change fixes a checkpatch CHECK style issue for "Alignment should
>> match open parenthesis".
>>
>> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
>> ---
>> drivers/staging/vt6656/rf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 5b8da06e3916..bcd4d467e03a 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
>>
>> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
>> ret = vnt_rf_write_embedded(priv,
>> - vt3226d0_lo_current_table[hw_value]);
>> + vt3226d0_lo_current_table[hw_value]);
>> if (ret)
>> return ret;
>> }
>
> I can't take this type of submission, do you see other patches submitted
> this way on the mailing list?
Actually I am having a hard time since this one's my first. I would really appreciate if you could be a little clear. Should I resend the entire patch as a new thread?
>
> Also, you have a trailing space in your changelog text :(
Thanks for pointing out. Yes, I have fixed the trailing space.
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] staging: vt6656: Fixed issue with alignment in rf.c
2021-02-11 21:02 ` Pritthijit Nath
@ 2021-02-11 21:15 ` Greg KH
0 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2021-02-11 21:15 UTC (permalink / raw)
To: Pritthijit Nath; +Cc: tvboxspy, devel, oscar.carter, forest, linux-kernel
On Fri, Feb 12, 2021 at 02:32:51AM +0530, Pritthijit Nath wrote:
> On 12/02/21 2:14 am, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:07:50AM +0530, Pritthijit Nath wrote:
> >> On 12/02/21 1:59 am, Greg KH wrote:
> >>> On Thu, Feb 11, 2021 at 08:54:26PM +0530, Pritthijit Nath wrote:
> >>>> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
> >>>>
> >>>> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> >>>> ---
> >>>> drivers/staging/vt6656/rf.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> >>>> index 5b8da06e3916..bcd4d467e03a 100644
> >>>> --- a/drivers/staging/vt6656/rf.c
> >>>> +++ b/drivers/staging/vt6656/rf.c
> >>>> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
> >>>>
> >>>> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
> >>>> ret = vnt_rf_write_embedded(priv,
> >>>> - vt3226d0_lo_current_table[hw_value]);
> >>>> + vt3226d0_lo_current_table[hw_value]);
> >>>> if (ret)
> >>>> return ret;
> >>>> }
> >>>> --
> >>>> 2.25.1
> >>>
> >>> Please run this change, with the changelog above, through
> >>> checkpatch.pl, fix that, and resend.
> >>>
> >>> thanks,
> >>>
> >>> greg k-h
> >>>
> >>
> >> This change fixes a checkpatch CHECK style issue for "Alignment should
> >> match open parenthesis".
> >>
> >> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> >> ---
> >> drivers/staging/vt6656/rf.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
> >> index 5b8da06e3916..bcd4d467e03a 100644
> >> --- a/drivers/staging/vt6656/rf.c
> >> +++ b/drivers/staging/vt6656/rf.c
> >> @@ -687,7 +687,7 @@ static int vnt_rf_set_txpower(struct vnt_private *priv, u8 power,
> >>
> >> if (hw_value < ARRAY_SIZE(vt3226d0_lo_current_table)) {
> >> ret = vnt_rf_write_embedded(priv,
> >> - vt3226d0_lo_current_table[hw_value]);
> >> + vt3226d0_lo_current_table[hw_value]);
> >> if (ret)
> >> return ret;
> >> }
> >
> > I can't take this type of submission, do you see other patches submitted
> > this way on the mailing list?
> Actually I am having a hard time since this one's my first. I would really appreciate if you could be a little clear. Should I resend the entire patch as a new thread?
Of course, the kernel documentation says to do this, correct?
Look at the patches on the list for examples of how this works.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-11 21:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 21:26 [PATCH] staging: vt6656: Fixed issue with alignment in rf.c Pritthijit Nath
2021-02-11 21:31 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-02-11 21:37 Pritthijit Nath
2021-02-11 15:24 Pritthijit Nath
2021-02-11 20:29 ` Greg KH
2021-02-11 20:37 ` Pritthijit Nath
2021-02-11 20:44 ` Greg KH
2021-02-11 21:02 ` Pritthijit Nath
2021-02-11 21:15 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).