[PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Pritthijit Nath]

This change fixes a checkpatch CHECK style issue for "Alignment should match
open parenthesis".

Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
 drivers/staging/greybus/hid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index ed706f39e87a..a56c3fb5d35a 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
 }

 static int __gb_hid_get_raw_report(struct hid_device *hid,
-		unsigned char report_number, __u8 *buf, size_t count,
-		unsigned char report_type)
+				   unsigned char report_number, __u8 *buf, size_t count,
+				   unsigned char report_type)
 {
 	struct gb_hid *ghid = hid->driver_data;
 	int ret;
--
2.25.1

[PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

[Pritthijit Nath]

Fixed the spelling of 'transfered' to 'transferred'.

Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
 drivers/staging/greybus/hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index a56c3fb5d35a..6b19ff4743a9 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,

 	ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
 	if (report_id && ret >= 0)
-		ret++; /* add report_id to the number of transfered bytes */
+		ret++; /* add report_id to the number of transferrid bytes */

 	return 0;
 }
--
2.25.1

Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

[Johan Hovold]

On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> Fixed the spelling of 'transfered' to 'transferred'.
> 
> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> ---
>  drivers/staging/greybus/hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> index a56c3fb5d35a..6b19ff4743a9 100644
> --- a/drivers/staging/greybus/hid.c
> +++ b/drivers/staging/greybus/hid.c
> @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,
> 
>  	ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
>  	if (report_id && ret >= 0)
> -		ret++; /* add report_id to the number of transfered bytes */
> +		ret++; /* add report_id to the number of transferrid bytes */

You now misspelled transferred in a different way.

> 
>  	return 0;
>  }

Johan

Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

[Greg KH]

On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote:
> On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> > Fixed the spelling of 'transfered' to 'transferred'.
> > 
> > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> > ---
> >  drivers/staging/greybus/hid.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > index a56c3fb5d35a..6b19ff4743a9 100644
> > --- a/drivers/staging/greybus/hid.c
> > +++ b/drivers/staging/greybus/hid.c
> > @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,
> > 
> >  	ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
> >  	if (report_id && ret >= 0)
> > -		ret++; /* add report_id to the number of transfered bytes */
> > +		ret++; /* add report_id to the number of transferrid bytes */
> 
> You now misspelled transferred in a different way.

Oops, will go revert this, I need more coffee...

Re: [PATCH 2/2] staging: greybus: Fixed a misspelling in hid.c

[Viresh Kumar]

On 12-02-21, 09:54, Greg KH wrote:
> On Fri, Feb 12, 2021 at 09:44:04AM +0100, Johan Hovold wrote:
> > On Fri, Feb 12, 2021 at 01:48:35PM +0530, Pritthijit Nath wrote:
> > > Fixed the spelling of 'transfered' to 'transferred'.
> > > 
> > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> > > ---
> > >  drivers/staging/greybus/hid.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > > index a56c3fb5d35a..6b19ff4743a9 100644
> > > --- a/drivers/staging/greybus/hid.c
> > > +++ b/drivers/staging/greybus/hid.c
> > > @@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,
> > > 
> > >  	ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
> > >  	if (report_id && ret >= 0)
> > > -		ret++; /* add report_id to the number of transfered bytes */
> > > +		ret++; /* add report_id to the number of transferrid bytes */
> > 
> > You now misspelled transferred in a different way.
> 
> Oops, will go revert this, I need more coffee...

Yeah, its Friday.. You need a break too :)

-- 
viresh

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Viresh Kumar]

On 12-02-21, 13:48, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match
> open parenthesis".
> 
> Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> ---
>  drivers/staging/greybus/hid.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> index ed706f39e87a..a56c3fb5d35a 100644
> --- a/drivers/staging/greybus/hid.c
> +++ b/drivers/staging/greybus/hid.c
> @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
>  }
> 
>  static int __gb_hid_get_raw_report(struct hid_device *hid,
> -		unsigned char report_number, __u8 *buf, size_t count,
> -		unsigned char report_type)
> +				   unsigned char report_number, __u8 *buf, size_t count,
> +				   unsigned char report_type)
>  {
>  	struct gb_hid *ghid = hid->driver_data;
>  	int ret;

I can't even count the number of attempts we have seen in previous
years to make checkpatch --strict happy for greybus.

I say we make this change once and for all across greybus, so we don't
have to review or NAK someone afterwards.

Should I send a patch for this ?

-- 
viresh

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Greg KH]

On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> On 12-02-21, 13:48, Pritthijit Nath wrote:
> > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > open parenthesis".
> > 
> > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> > ---
> >  drivers/staging/greybus/hid.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > index ed706f39e87a..a56c3fb5d35a 100644
> > --- a/drivers/staging/greybus/hid.c
> > +++ b/drivers/staging/greybus/hid.c
> > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
> >  }
> > 
> >  static int __gb_hid_get_raw_report(struct hid_device *hid,
> > -		unsigned char report_number, __u8 *buf, size_t count,
> > -		unsigned char report_type)
> > +				   unsigned char report_number, __u8 *buf, size_t count,
> > +				   unsigned char report_type)
> >  {
> >  	struct gb_hid *ghid = hid->driver_data;
> >  	int ret;
> 
> I can't even count the number of attempts we have seen in previous
> years to make checkpatch --strict happy for greybus.
> 
> I say we make this change once and for all across greybus, so we don't
> have to review or NAK someone afterwards.
> 
> Should I send a patch for this ?

Sure, but note that over time, checkpatch adds new things so there will
always be something to change in here, until we move it out of the
drivers/staging/ area :)

I need to go fix up the greybus vibrator patch which was my first
attempt at getting back into that effort...

thanks,

greg k-h

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Viresh Kumar]

On 12-02-21, 10:17, Greg KH wrote:
> On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > > open parenthesis".
> > > 
> > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> > > ---
> > >  drivers/staging/greybus/hid.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > > index ed706f39e87a..a56c3fb5d35a 100644
> > > --- a/drivers/staging/greybus/hid.c
> > > +++ b/drivers/staging/greybus/hid.c
> > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
> > >  }
> > > 
> > >  static int __gb_hid_get_raw_report(struct hid_device *hid,
> > > -		unsigned char report_number, __u8 *buf, size_t count,
> > > -		unsigned char report_type)
> > > +				   unsigned char report_number, __u8 *buf, size_t count,
> > > +				   unsigned char report_type)
> > >  {
> > >  	struct gb_hid *ghid = hid->driver_data;
> > >  	int ret;
> > 
> > I can't even count the number of attempts we have seen in previous
> > years to make checkpatch --strict happy for greybus.
> > 
> > I say we make this change once and for all across greybus, so we don't
> > have to review or NAK someone afterwards.
> > 
> > Should I send a patch for this ?
> 
> Sure, but note that over time, checkpatch adds new things so there will
> always be something to change in here, until we move it out of the
> drivers/staging/ area :)

Right, though I wasn't worried about other checkpatch warning but
specially the "alignment - parenthesis" one. Everyone (specially
newbies) want to fix that everywhere :)

-- 
viresh

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Greg KH]

On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:17, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > > > open parenthesis".
> > > > 
> > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> > > > ---
> > > >  drivers/staging/greybus/hid.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > > > index ed706f39e87a..a56c3fb5d35a 100644
> > > > --- a/drivers/staging/greybus/hid.c
> > > > +++ b/drivers/staging/greybus/hid.c
> > > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
> > > >  }
> > > > 
> > > >  static int __gb_hid_get_raw_report(struct hid_device *hid,
> > > > -		unsigned char report_number, __u8 *buf, size_t count,
> > > > -		unsigned char report_type)
> > > > +				   unsigned char report_number, __u8 *buf, size_t count,
> > > > +				   unsigned char report_type)
> > > >  {
> > > >  	struct gb_hid *ghid = hid->driver_data;
> > > >  	int ret;
> > > 
> > > I can't even count the number of attempts we have seen in previous
> > > years to make checkpatch --strict happy for greybus.
> > > 
> > > I say we make this change once and for all across greybus, so we don't
> > > have to review or NAK someone afterwards.
> > > 
> > > Should I send a patch for this ?
> > 
> > Sure, but note that over time, checkpatch adds new things so there will
> > always be something to change in here, until we move it out of the
> > drivers/staging/ area :)
> 
> Right, though I wasn't worried about other checkpatch warning but
> specially the "alignment - parenthesis" one. Everyone (specially
> newbies) want to fix that everywhere :)

Sure, fix it up "right" if you want to, I'll take coding style fixes
from anyone :)

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Johan Hovold]

On Fri, Feb 12, 2021 at 02:51:30PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:17, Greg KH wrote:
> > On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> > > On 12-02-21, 13:48, Pritthijit Nath wrote:
> > > > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > > > open parenthesis".
> > > > 
> > > > Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
> > > > ---
> > > >  drivers/staging/greybus/hid.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > > > index ed706f39e87a..a56c3fb5d35a 100644
> > > > --- a/drivers/staging/greybus/hid.c
> > > > +++ b/drivers/staging/greybus/hid.c
> > > > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
> > > >  }
> > > > 
> > > >  static int __gb_hid_get_raw_report(struct hid_device *hid,
> > > > -		unsigned char report_number, __u8 *buf, size_t count,
> > > > -		unsigned char report_type)
> > > > +				   unsigned char report_number, __u8 *buf, size_t count,
> > > > +				   unsigned char report_type)
> > > >  {
> > > >  	struct gb_hid *ghid = hid->driver_data;
> > > >  	int ret;
> > > 
> > > I can't even count the number of attempts we have seen in previous
> > > years to make checkpatch --strict happy for greybus.
> > > 
> > > I say we make this change once and for all across greybus, so we don't
> > > have to review or NAK someone afterwards.
> > > 
> > > Should I send a patch for this ?
> > 
> > Sure, but note that over time, checkpatch adds new things so there will
> > always be something to change in here, until we move it out of the
> > drivers/staging/ area :)
> 
> Right, though I wasn't worried about other checkpatch warning but
> specially the "alignment - parenthesis" one. Everyone (specially
> newbies) want to fix that everywhere :)

But what will the checkpatch crew then work on? Better staging than the
rest of the kernel.

Perhaps just let them keep at it until we move the rest out (the price
we pay for taking this through staging apparently).

But there can't be that many instances left of this alignment
"violation" in staging/greybus (~4 it seems) if you want to get it over
with.

Johan

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Viresh Kumar]

On 12-02-21, 10:52, Johan Hovold wrote:
> But what will the checkpatch crew then work on?

Lol..

> Better staging than the rest of the kernel.

[ /me wondering on who stops them from sending patches for rest of the
kernel ? ]

-- 
viresh

Re: [PATCH 1/2] staging: greybus: Fixed alignment issue in hid.c

[Johan Hovold]

On Fri, Feb 12, 2021 at 03:25:29PM +0530, Viresh Kumar wrote:
> On 12-02-21, 10:52, Johan Hovold wrote:
> > But what will the checkpatch crew then work on?
> 
> Lol..
> 
> > Better staging than the rest of the kernel.
> 
> [ /me wondering on who stops them from sending patches for rest of the
> kernel ? ]

Ideally maintainers should at least push back when they do.

Johan