* [PATCH v2] arm64: Fix warning in mte_get_random_tag()
@ 2021-02-11 15:22 Vincenzo Frascino
2021-02-11 17:42 ` Andrey Konovalov
2021-02-12 10:54 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Vincenzo Frascino @ 2021-02-11 15:22 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel, kasan-dev
Cc: Vincenzo Frascino, Catalin Marinas, Will Deacon,
Andrey Konovalov, Andrew Morton
The simplification of mte_get_random_tag() caused the introduction of the
warning below:
In file included from arch/arm64/include/asm/kasan.h:9,
from include/linux/kasan.h:16,
from mm/kasan/common.c:14:
mm/kasan/common.c: In function ‘mte_get_random_tag’:
arch/arm64/include/asm/mte-kasan.h:45:9: warning: ‘addr’ is used
uninitialized [-Wuninitialized]
45 | asm(__MTE_PREAMBLE "irg %0, %0"
|
Fix the warning using "=r" for the address in the asm inline.
Fixes: c8f8de4c0887 ("arm64: kasan: simplify and inline MTE functions")
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
This patch is based on linux-next/akpm
arch/arm64/include/asm/mte-kasan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/mte-kasan.h b/arch/arm64/include/asm/mte-kasan.h
index 3d58489228c0..7ab500e2ad17 100644
--- a/arch/arm64/include/asm/mte-kasan.h
+++ b/arch/arm64/include/asm/mte-kasan.h
@@ -43,7 +43,7 @@ static inline u8 mte_get_random_tag(void)
void *addr;
asm(__MTE_PREAMBLE "irg %0, %0"
- : "+r" (addr));
+ : "=r" (addr));
return mte_get_ptr_tag(addr);
}
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: Fix warning in mte_get_random_tag()
2021-02-11 15:22 [PATCH v2] arm64: Fix warning in mte_get_random_tag() Vincenzo Frascino
@ 2021-02-11 17:42 ` Andrey Konovalov
2021-02-12 10:54 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Andrey Konovalov @ 2021-02-11 17:42 UTC (permalink / raw)
To: Vincenzo Frascino
Cc: Linux ARM, LKML, kasan-dev, Catalin Marinas, Will Deacon, Andrew Morton
On Thu, Feb 11, 2021 at 4:22 PM Vincenzo Frascino
<vincenzo.frascino@arm.com> wrote:
>
> The simplification of mte_get_random_tag() caused the introduction of the
> warning below:
>
> In file included from arch/arm64/include/asm/kasan.h:9,
> from include/linux/kasan.h:16,
> from mm/kasan/common.c:14:
> mm/kasan/common.c: In function ‘mte_get_random_tag’:
> arch/arm64/include/asm/mte-kasan.h:45:9: warning: ‘addr’ is used
> uninitialized [-Wuninitialized]
> 45 | asm(__MTE_PREAMBLE "irg %0, %0"
> |
>
> Fix the warning using "=r" for the address in the asm inline.
>
> Fixes: c8f8de4c0887 ("arm64: kasan: simplify and inline MTE functions")
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrey Konovalov <andreyknvl@google.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>
> This patch is based on linux-next/akpm
>
> arch/arm64/include/asm/mte-kasan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/mte-kasan.h b/arch/arm64/include/asm/mte-kasan.h
> index 3d58489228c0..7ab500e2ad17 100644
> --- a/arch/arm64/include/asm/mte-kasan.h
> +++ b/arch/arm64/include/asm/mte-kasan.h
> @@ -43,7 +43,7 @@ static inline u8 mte_get_random_tag(void)
> void *addr;
>
> asm(__MTE_PREAMBLE "irg %0, %0"
> - : "+r" (addr));
> + : "=r" (addr));
>
> return mte_get_ptr_tag(addr);
> }
> --
> 2.30.0
>
Acked-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: Fix warning in mte_get_random_tag()
2021-02-11 15:22 [PATCH v2] arm64: Fix warning in mte_get_random_tag() Vincenzo Frascino
2021-02-11 17:42 ` Andrey Konovalov
@ 2021-02-12 10:54 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2021-02-12 10:54 UTC (permalink / raw)
To: Vincenzo Frascino
Cc: linux-arm-kernel, linux-kernel, kasan-dev, Will Deacon,
Andrey Konovalov, Andrew Morton
On Thu, Feb 11, 2021 at 03:22:08PM +0000, Vincenzo Frascino wrote:
> The simplification of mte_get_random_tag() caused the introduction of the
> warning below:
>
> In file included from arch/arm64/include/asm/kasan.h:9,
> from include/linux/kasan.h:16,
> from mm/kasan/common.c:14:
> mm/kasan/common.c: In function ‘mte_get_random_tag’:
> arch/arm64/include/asm/mte-kasan.h:45:9: warning: ‘addr’ is used
> uninitialized [-Wuninitialized]
> 45 | asm(__MTE_PREAMBLE "irg %0, %0"
> |
>
> Fix the warning using "=r" for the address in the asm inline.
>
> Fixes: c8f8de4c0887 ("arm64: kasan: simplify and inline MTE functions")
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Andrey Konovalov <andreyknvl@google.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-12 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 15:22 [PATCH v2] arm64: Fix warning in mte_get_random_tag() Vincenzo Frascino
2021-02-11 17:42 ` Andrey Konovalov
2021-02-12 10:54 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).