From: Richard Guy Briggs <rgb@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Phil Sutter <phil@nwl.cc>,
Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org, sgrubb@redhat.com,
Ondrej Mosnacek <omosnace@redhat.com>,
fw@strlen.de, twoerner@redhat.com,
Eric Paris <eparis@parisplace.org>,
tgraf@infradead.org
Subject: Re: [PATCH ghak124 v3] audit: log nftables configuration change events
Date: Fri, 12 Feb 2021 15:48:28 -0500 [thread overview]
Message-ID: <20210212204828.GL3141668@madcap2.tricolour.ca> (raw)
In-Reply-To: <20210211202628.GP2015948@madcap2.tricolour.ca>
On 2021-02-11 15:26, Richard Guy Briggs wrote:
> On 2021-02-11 11:29, Paul Moore wrote:
> > On Thu, Feb 11, 2021 at 10:16 AM Phil Sutter <phil@nwl.cc> wrote:
> > > Hi,
> > >
> > > On Thu, Jun 04, 2020 at 09:20:49AM -0400, Richard Guy Briggs wrote:
> > > > iptables, ip6tables, arptables and ebtables table registration,
> > > > replacement and unregistration configuration events are logged for the
> > > > native (legacy) iptables setsockopt api, but not for the
> > > > nftables netlink api which is used by the nft-variant of iptables in
> > > > addition to nftables itself.
> > > >
> > > > Add calls to log the configuration actions in the nftables netlink api.
> > >
> > > As discussed offline already, these audit notifications are pretty hefty
> > > performance-wise. In an internal report, 300% restore time of a ruleset
> > > containing 70k set elements is measured.
> >
> > If you're going to reference offline/off-list discussions in a post to
> > a public list, perhaps the original discussion shouldn't have been
> > off-list ;) If you don't involve us in the discussion, we have to
> > waste a lot of time getting caught up.
>
> Here's part of that discussion:
> https://bugzilla.redhat.com/show_bug.cgi?id=1918013
Here's the rest:
https://bugzilla.redhat.com/show_bug.cgi?id=1921624
> > > If I'm not mistaken, iptables emits a single audit log per table, ipset
> > > doesn't support audit at all. So I wonder how much audit logging is
> > > required at all (for certification or whatever reason). How much
> > > granularity is desired?
> >
> > That's a question for the people who track these certification
> > requirements, which is thankfully not me at the moment. Unless
> > somebody else wants to speak up, Steve Grubb is probably the only
> > person who tracks that sort of stuff and comments here.
> >
> > I believe the netfilter auditing was mostly a nice-to-have bit of
> > functionality to help add to the completeness of the audit logs, but I
> > could very easily be mistaken. Richard put together those patches, he
> > can probably provide the background/motivation for the effort.
>
> It was added because an audit test that normally produced records from
> iptables on one distro stopped producing any records on another.
> Investigation led to the fact that on the first it was using
> iptables-legacy API and on the other it was using iptables-nft API.
>
> > > I personally would notify once per transaction. This is easy and quick.
>
> This was the goal. iptables was atomic. nftables appears to no longer
> be so. If I have this wrong, please show how that works.
>
> > > Once per table or chain should be acceptable, as well. At the very
> > > least, we should not have to notify once per each element. This is the
> > > last resort of fast ruleset adjustments. If we lose it, people are
> > > better off with ipset IMHO.
> > >
> > > Unlike nft monitor, auditd is not designed to be disabled "at will". So
> > > turning it off for performance-critical workloads is no option.
>
> If it were to be disabled "at will" it would defeat the purpose of
> audit. Those records can already be filtered, or audit can be disabled,
> but let us look at rationalizing the current nftables records first.
>
> > Patches are always welcome, but it might be wise to get to the bottom
> > of the certification requirements first.
> >
> > paul moore
>
> - RGB
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2021-02-12 20:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 13:20 [PATCH ghak124 v3] audit: log nftables configuration change events Richard Guy Briggs
2020-06-04 17:03 ` Steve Grubb
2020-06-04 17:57 ` Richard Guy Briggs
2020-06-04 18:51 ` Steve Grubb
2020-06-24 0:34 ` Paul Moore
2020-06-24 10:03 ` Pablo Neira Ayuso
2020-06-24 12:34 ` Richard Guy Briggs
2020-06-24 13:03 ` Pablo Neira Ayuso
2020-06-24 13:26 ` Richard Guy Briggs
2021-02-11 15:16 ` Phil Sutter
2021-02-11 16:29 ` Paul Moore
2021-02-11 20:26 ` Richard Guy Briggs
2021-02-11 22:09 ` Florian Westphal
2021-02-17 23:41 ` Richard Guy Briggs
2021-02-18 8:22 ` Florian Westphal
2021-02-18 12:42 ` Richard Guy Briggs
2021-02-18 12:52 ` Florian Westphal
2021-02-18 13:28 ` Richard Guy Briggs
2021-02-18 13:41 ` Florian Westphal
2021-02-18 21:20 ` Richard Guy Briggs
2021-02-18 22:42 ` Florian Westphal
2021-02-19 6:26 ` Richard Guy Briggs
2021-02-19 19:25 ` Richard Guy Briggs
2021-02-12 20:48 ` Richard Guy Briggs [this message]
2021-02-11 21:02 ` Steve Grubb
2021-02-12 12:11 ` Phil Sutter
2021-02-12 20:54 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212204828.GL3141668@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=eparis@parisplace.org \
--cc=fw@strlen.de \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=phil@nwl.cc \
--cc=sgrubb@redhat.com \
--cc=tgraf@infradead.org \
--cc=twoerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).