From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"ivecera@redhat.com" <ivecera@redhat.com>,
"nikolay@nvidia.com" <nikolay@nvidia.com>,
"roopa@nvidia.com" <roopa@nvidia.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"rasmus.villemoes@prevas.dk" <rasmus.villemoes@prevas.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>
Subject: Re: [PATCH net-next v4 8/8] net: dsa: felix: Add support for MRP
Date: Wed, 17 Feb 2021 10:24:49 +0000 [thread overview]
Message-ID: <20210217102448.oea5dwl2qnhybir3@skbuf> (raw)
In-Reply-To: <20210216214205.32385-9-horatiu.vultur@microchip.com>
On Tue, Feb 16, 2021 at 10:42:05PM +0100, Horatiu Vultur wrote:
> @@ -112,6 +113,7 @@ static struct sk_buff *ocelot_rcv(struct sk_buff *skb,
> ocelot_xfh_get_qos_class(extraction, &qos_class);
> ocelot_xfh_get_tag_type(extraction, &tag_type);
> ocelot_xfh_get_vlan_tci(extraction, &vlan_tci);
> + ocelot_xfh_get_cpuq(extraction, &cpuq);
>
> skb->dev = dsa_master_find_slave(netdev, 0, src_port);
> if (!skb->dev)
> @@ -126,6 +128,12 @@ static struct sk_buff *ocelot_rcv(struct sk_buff *skb,
> skb->offload_fwd_mark = 1;
> skb->priority = qos_class;
>
> +#if IS_ENABLED(CONFIG_BRIDGE_MRP)
> + if (eth_hdr(skb)->h_proto == cpu_to_be16(ETH_P_MRP) &&
> + cpuq & BIT(OCELOT_MRP_CPUQ))
Checking the EtherType seems redundant, since those are the only frames
trapped to the MRP CPU queue.
Also, the cpuq variable is potentially unused when CONFIG_BRIDGE_MRP is
unset. I'm concerned that static analysis people may come in and try to
fix it up with even more ifdeffery, which is definitely not what I would
like to go for.
How about just the following, which is not conditionally compiled:
if (!(cpuq & BIT(OCELOT_MRP_CPUQ)))
skb->offload_fwd_mark = 1;
> + skb->offload_fwd_mark = 0;
> +#endif
> +
> /* Ocelot switches copy frames unmodified to the CPU. However, it is
> * possible for the user to request a VLAN modification through
> * VCAP_IS1_ACT_VID_REPLACE_ENA. In this case, what will happen is that
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-02-17 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 21:41 [PATCH net-next v4 0/8] bridge: mrp: Extend br_mrp_switchdev_* Horatiu Vultur
2021-02-16 21:41 ` [PATCH net-next v4 1/8] switchdev: mrp: Remove CONFIG_BRIDGE_MRP Horatiu Vultur
2021-02-17 10:26 ` Vladimir Oltean
2021-02-16 21:41 ` [PATCH net-next v4 2/8] switchdev: mrp: Extend ring_role_mrp and in_role_mrp Horatiu Vultur
2021-02-17 10:34 ` Vladimir Oltean
2021-02-17 15:58 ` Horatiu Vultur
2021-02-17 16:09 ` Vladimir Oltean
2021-02-16 21:42 ` [PATCH net-next v4 3/8] bridge: mrp: Add 'enum br_mrp_hw_support' Horatiu Vultur
2021-02-16 21:42 ` [PATCH net-next v4 4/8] bridge: mrp: Extend br_mrp_switchdev to detect better the errors Horatiu Vultur
2021-02-17 10:56 ` Vladimir Oltean
2021-02-17 16:02 ` Horatiu Vultur
2021-02-16 21:42 ` [PATCH net-next v4 5/8] bridge: mrp: Update br_mrp to use new return values of br_mrp_switchdev Horatiu Vultur
2021-02-17 10:59 ` Vladimir Oltean
2021-02-17 16:18 ` Horatiu Vultur
2021-02-16 21:42 ` [PATCH net-next v4 6/8] net: mscc: ocelot: Add support for MRP Horatiu Vultur
2021-02-17 11:14 ` Vladimir Oltean
2021-02-17 16:25 ` Horatiu Vultur
2021-02-17 11:51 ` Vladimir Oltean
2021-02-16 21:42 ` [PATCH net-next v4 7/8] net: dsa: add MRP support Horatiu Vultur
2021-02-17 11:23 ` Vladimir Oltean
2021-02-16 21:42 ` [PATCH net-next v4 8/8] net: dsa: felix: Add support for MRP Horatiu Vultur
2021-02-17 10:24 ` Vladimir Oltean [this message]
2021-02-16 23:00 ` [PATCH net-next v4 0/8] bridge: mrp: Extend br_mrp_switchdev_* patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217102448.oea5dwl2qnhybir3@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=roopa@nvidia.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).