* [PATCH] staging: wlan-ng: Fix comments typos @ 2021-02-10 14:59 Mairo Paul Rufus 2021-02-10 17:04 ` Greg KH 2021-02-18 16:15 ` Dan Carpenter 0 siblings, 2 replies; 5+ messages in thread From: Mairo Paul Rufus @ 2021-02-10 14:59 UTC (permalink / raw) To: gregkh; +Cc: trivial, devel, linux-kernel, Mairo Paul Rufus Signed-off-by: Mairo Paul Rufus <akoudanilo@gmail.com> --- drivers/staging/wlan-ng/p80211netdev.c | 2 +- drivers/staging/wlan-ng/prism2mib.c | 2 +- drivers/staging/wlan-ng/prism2sta.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c index 7b091c5a2984..4a6813e89916 100644 --- a/drivers/staging/wlan-ng/p80211netdev.c +++ b/drivers/staging/wlan-ng/p80211netdev.c @@ -274,7 +274,7 @@ static void p80211netdev_rx_bh(unsigned long arg) struct sk_buff *skb = NULL; struct net_device *dev = wlandev->netdev; - /* Let's empty our our queue */ + /* Let's empty our queue */ while ((skb = skb_dequeue(&wlandev->nsd_rxq))) { if (wlandev->state == WLAN_DEVICE_OPEN) { if (dev->type != ARPHRD_ETHER) { diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c index 7d7d77b04255..875812a391c9 100644 --- a/drivers/staging/wlan-ng/prism2mib.c +++ b/drivers/staging/wlan-ng/prism2mib.c @@ -292,7 +292,7 @@ int prism2mgmt_mibset_mibget(struct wlandevice *wlandev, void *msgp) /* ** Determine if this is a "mibget" or a "mibset". If this is a ** "mibget", then make sure that the MIB may be read. Otherwise, - ** this is a "mibset" so make make sure that the MIB may be written. + ** this is a "mibset" so make sure that the MIB may be written. */ isget = (msg->msgcode == DIDMSG_DOT11REQ_MIBGET); diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c index 8f25496188aa..e6dcb687e7a1 100644 --- a/drivers/staging/wlan-ng/prism2sta.c +++ b/drivers/staging/wlan-ng/prism2sta.c @@ -461,7 +461,7 @@ u32 prism2sta_ifstate(struct wlandevice *wlandev, u32 ifstate) case WLAN_MSD_FWLOAD: wlandev->msdstate = WLAN_MSD_RUNNING_PENDING; /* Initialize the device+driver for full - * operation. Note that this might me an FWLOAD to + * operation. Note that this might me an FWLOAD * to RUNNING transition so we must not do a chip * or board level reset. Note that on failure, * the MSD state is set to HWPRESENT because we @@ -1352,7 +1352,7 @@ void prism2sta_processing_defer(struct work_struct *data) * we get back in range. We should block transmits and * receives in this state. Do we need an indication here? * Probably not since a polling user-mode element would - * get this status from from p2PortStatus(FD40). What about + * get this status from p2PortStatus(FD40). What about * p80211? * Response: * Block Transmits, Ignore receives of data frames -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix comments typos 2021-02-10 14:59 [PATCH] staging: wlan-ng: Fix comments typos Mairo Paul Rufus @ 2021-02-10 17:04 ` Greg KH 2021-02-11 16:55 ` Mairo P. Rufus 2021-02-18 16:15 ` Dan Carpenter 1 sibling, 1 reply; 5+ messages in thread From: Greg KH @ 2021-02-10 17:04 UTC (permalink / raw) To: Mairo Paul Rufus; +Cc: devel, trivial, linux-kernel On Wed, Feb 10, 2021 at 03:59:52PM +0100, Mairo Paul Rufus wrote: > Signed-off-by: Mairo Paul Rufus <akoudanilo@gmail.com> > --- > drivers/staging/wlan-ng/p80211netdev.c | 2 +- > drivers/staging/wlan-ng/prism2mib.c | 2 +- > drivers/staging/wlan-ng/prism2sta.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c > index 7b091c5a2984..4a6813e89916 100644 > --- a/drivers/staging/wlan-ng/p80211netdev.c > +++ b/drivers/staging/wlan-ng/p80211netdev.c > @@ -274,7 +274,7 @@ static void p80211netdev_rx_bh(unsigned long arg) > struct sk_buff *skb = NULL; > struct net_device *dev = wlandev->netdev; > > - /* Let's empty our our queue */ > + /* Let's empty our queue */ > while ((skb = skb_dequeue(&wlandev->nsd_rxq))) { > if (wlandev->state == WLAN_DEVICE_OPEN) { > if (dev->type != ARPHRD_ETHER) { > diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c > index 7d7d77b04255..875812a391c9 100644 > --- a/drivers/staging/wlan-ng/prism2mib.c > +++ b/drivers/staging/wlan-ng/prism2mib.c > @@ -292,7 +292,7 @@ int prism2mgmt_mibset_mibget(struct wlandevice *wlandev, void *msgp) > /* > ** Determine if this is a "mibget" or a "mibset". If this is a > ** "mibget", then make sure that the MIB may be read. Otherwise, > - ** this is a "mibset" so make make sure that the MIB may be written. > + ** this is a "mibset" so make sure that the MIB may be written. > */ > > isget = (msg->msgcode == DIDMSG_DOT11REQ_MIBGET); > diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c > index 8f25496188aa..e6dcb687e7a1 100644 > --- a/drivers/staging/wlan-ng/prism2sta.c > +++ b/drivers/staging/wlan-ng/prism2sta.c > @@ -461,7 +461,7 @@ u32 prism2sta_ifstate(struct wlandevice *wlandev, u32 ifstate) > case WLAN_MSD_FWLOAD: > wlandev->msdstate = WLAN_MSD_RUNNING_PENDING; > /* Initialize the device+driver for full > - * operation. Note that this might me an FWLOAD to > + * operation. Note that this might me an FWLOAD > * to RUNNING transition so we must not do a chip > * or board level reset. Note that on failure, > * the MSD state is set to HWPRESENT because we > @@ -1352,7 +1352,7 @@ void prism2sta_processing_defer(struct work_struct *data) > * we get back in range. We should block transmits and > * receives in this state. Do we need an indication here? > * Probably not since a polling user-mode element would > - * get this status from from p2PortStatus(FD40). What about > + * get this status from p2PortStatus(FD40). What about > * p80211? > * Response: > * Block Transmits, Ignore receives of data frames > -- > 2.26.2 Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix comments typos 2021-02-10 17:04 ` Greg KH @ 2021-02-11 16:55 ` Mairo P. Rufus 2021-02-11 17:28 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Mairo P. Rufus @ 2021-02-11 16:55 UTC (permalink / raw) To: Greg KH; +Cc: devel, trivial, linux-kernel > Hi, > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > a patch that has triggered this response. He used to manually respond > to these common problems, but in order to save his sanity (he kept > writing the same thing over and over, yet to different people), I was > created. Hopefully you will not take offence and will fix the problem > in your patch and resubmit it so that it can be accepted into the Linux > kernel tree. > > You are receiving this message because of the following common error(s) > as indicated below: > > - You did not specify a description of why the patch is needed, or > possibly, any description at all, in the email body. Please read the > section entitled "The canonical patch format" in the kernel file, > Documentation/SubmittingPatches for what is needed in order to > properly describe the change. > > - You did not write a descriptive Subject: for the patch, allowing Greg, > and everyone else, to know what this patch is all about. Please read > the section entitled "The canonical patch format" in the kernel file, > Documentation/SubmittingPatches for what a proper Subject: line should > look like. > > If you wish to discuss this problem further, or you have questions about > how to resolve this issue, please feel free to respond to this email and > Greg will reply once he has dug out from the pending patches received > from other developers. > > thanks, > > greg k-h's patch email bot After double checking, I still can't figure out what I did wrong. I'm sorry for abusing your time, but can you help me on this one? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix comments typos 2021-02-11 16:55 ` Mairo P. Rufus @ 2021-02-11 17:28 ` Greg KH 0 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2021-02-11 17:28 UTC (permalink / raw) To: Mairo P. Rufus; +Cc: devel, trivial, linux-kernel On Thu, Feb 11, 2021 at 05:55:18PM +0100, Mairo P. Rufus wrote: > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept > > writing the same thing over and over, yet to different people), I was > > created. Hopefully you will not take offence and will fix the problem > > in your patch and resubmit it so that it can be accepted into the Linux > > kernel tree. > > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - You did not specify a description of why the patch is needed, or > > possibly, any description at all, in the email body. Please read the > > section entitled "The canonical patch format" in the kernel file, > > Documentation/SubmittingPatches for what is needed in order to > > properly describe the change. > > > > - You did not write a descriptive Subject: for the patch, allowing Greg, > > and everyone else, to know what this patch is all about. Please read > > the section entitled "The canonical patch format" in the kernel file, > > Documentation/SubmittingPatches for what a proper Subject: line should > > look like. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > > After double checking, I still can't figure out what I did wrong. I'm > sorry for abusing your time, but can you help me on this one? You don't quote your changelog text here, so it's hard to determine what needs to be done. But your subject line could use a lot of work, don't you agree? Read the above links for how to write a good one. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: wlan-ng: Fix comments typos 2021-02-10 14:59 [PATCH] staging: wlan-ng: Fix comments typos Mairo Paul Rufus 2021-02-10 17:04 ` Greg KH @ 2021-02-18 16:15 ` Dan Carpenter 1 sibling, 0 replies; 5+ messages in thread From: Dan Carpenter @ 2021-02-18 16:15 UTC (permalink / raw) To: Mairo Paul Rufus; +Cc: gregkh, devel, trivial, linux-kernel On Wed, Feb 10, 2021 at 03:59:52PM +0100, Mairo Paul Rufus wrote: > Signed-off-by: Mairo Paul Rufus <akoudanilo@gmail.com> No commit message. It should say something like: Checkpatch complained about the accidental repeated words like "our our" so I fixed it. > diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c > index 8f25496188aa..e6dcb687e7a1 100644 > --- a/drivers/staging/wlan-ng/prism2sta.c > +++ b/drivers/staging/wlan-ng/prism2sta.c > @@ -461,7 +461,7 @@ u32 prism2sta_ifstate(struct wlandevice *wlandev, u32 ifstate) > case WLAN_MSD_FWLOAD: > wlandev->msdstate = WLAN_MSD_RUNNING_PENDING; > /* Initialize the device+driver for full > - * operation. Note that this might me an FWLOAD to > + * operation. Note that this might me an FWLOAD ^^^^^^^^ This probably should be "might be". > * to RUNNING transition so we must not do a chip > * or board level reset. Note that on failure, > * the MSD state is set to HWPRESENT because we regards, dan carpenter ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-18 18:40 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-10 14:59 [PATCH] staging: wlan-ng: Fix comments typos Mairo Paul Rufus 2021-02-10 17:04 ` Greg KH 2021-02-11 16:55 ` Mairo P. Rufus 2021-02-11 17:28 ` Greg KH 2021-02-18 16:15 ` Dan Carpenter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).