From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kurt Manucredo <fuzzybritches@protonmail.com>
Cc: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
straube.linux@gmail.com, d.straghkov@ispras.ru, tiwai@suse.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform
Date: Fri, 19 Feb 2021 10:01:40 +0300 [thread overview]
Message-ID: <20210219070139.GP2222@kadam> (raw)
In-Reply-To: <20210218194830.8-1-fuzzybritches@protonmail.com>
On Thu, Feb 18, 2021 at 07:50:27PM +0000, Kurt Manucredo wrote:
> Signed-off-by: Kurt Manucredo <fuzzybritches@protonmail.com>
> ---
>
> The preferred coding style is:
> if (!StaAddr)
> return;
Above the Signed-off-by line. Also indenting is wrong. And it's hard
to understand what you're saying.
>
> thank you mr. dan carpenter
You're welcome. (These sorts of comments do go below the --- cut off
line so that's fine.)
regards,
dan carpenter
prev parent reply other threads:[~2021-02-19 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 19:50 [PATCH] staging: rtl8723bs: make if-statement checkpatch.pl conform Kurt Manucredo
2021-02-18 20:01 ` Greg KH
2021-02-19 7:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219070139.GP2222@kadam \
--to=dan.carpenter@oracle.com \
--cc=d.straghkov@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=fuzzybritches@protonmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).