From: Pavel Machek <pavel@ucw.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: [GIT PULL 5.11-rc8] LED fix
Date: Fri, 19 Feb 2021 12:20:00 +0100 [thread overview]
Message-ID: <20210219112000.GJ19207@duo.ucw.cz> (raw)
In-Reply-To: <CAHk-=wgmB6qH7Ho433B066S0=B-CtDNFtaZWOM3PMGWB0ERKSw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
Hi!
> On Sun, Feb 14, 2021 at 12:31 PM Pavel Machek <pavel@ucw.cz> wrote:
> >
> > 92bf22614b21 is my rc7, and it is parent of the commit I want you to
> > apply.
>
> Oh, right you are. I looked at your leds-cleanup-for-pavel branch for
> some reason, which was much older.
>
> Anyway, it does the remote lookup with git ls-remote, and doesn't find
> any matching ref for that 92bf22614 commit you gave it as a base, so
> that's why it complains. You _could_ fix that by just pushing all the
> tags you have locally to your remote too.
>
> Have you changed your behavior wrt git request-pull lately? Because
> that whole model you use is broken.
This was really one-off and I found the git messages quite confusing.
>
> The "end" commit shouldn't be my tag (and it shouldn't be a SHA1). It
> should be *your* branch name.
>
> So what you *should* have used is something like
>
> git request-pull master
> git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/
> for-rc8-5.11
>
> (assuming "master" is the upstream branch - which would be my
> v5.11-rc7) without any odd SHA games or anything like that.
Yes, pushing master should work. I tried to fall back to SHAs as I
find them less confusing.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-02-19 11:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 17:13 [GIT PULL 5.11-rc8] LED fix Pavel Machek
2021-02-14 19:57 ` Linus Torvalds
2021-02-14 20:31 ` Pavel Machek
2021-02-14 20:55 ` Linus Torvalds
2021-02-19 11:20 ` Pavel Machek [this message]
2021-02-14 20:58 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219112000.GJ19207@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).