* [PATCH] nvme: Apply the same fix Kingston SKC2000 nVME SSD as A2000
@ 2021-02-21 5:12 Zoltán Böszörményi
2021-02-24 9:19 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Zoltán Böszörményi @ 2021-02-21 5:12 UTC (permalink / raw)
To: linux-kernel
Cc: linux-scsi, linux-nvme, gregkh, Zoltán Böszörményi
From: Zoltán Böszörményi <zboszor@gmail.com>
My 2TB SKC2000 showed the exact same symptoms that were provided
in 538e4a8c57 ("nvme-pci: avoid the deepest sleep state on
Kingston A2000 SSDs"), i.e. a complete NVME lockup that needed
cold boot to get it back.
According to some sources, the A2000 is simply a rebadged
SKC2000 with a slightly optimized firmware.
Adding the SKC2000 PCI ID to the quirk list with the same workaround
as the A2000 made my laptop survive a 5 hours long Yocto bootstrap
buildfest which reliably triggered the SSD lockup previously.
Tested against 5.10.17.
Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 4a33287..3af6a95 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3264,6 +3264,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
{ PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */
.driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, },
+ { PCI_DEVICE(0x2646, 0x2262), /* KINGSTON SKC2000 NVMe SSD */
+ .driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */
.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme: Apply the same fix Kingston SKC2000 nVME SSD as A2000
2021-02-21 5:12 [PATCH] nvme: Apply the same fix Kingston SKC2000 nVME SSD as A2000 Zoltán Böszörményi
@ 2021-02-24 9:19 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2021-02-24 9:19 UTC (permalink / raw)
To: Zolt??n B??sz??rm??nyi
Cc: linux-kernel, gregkh, linux-nvme, linux-scsi, Zolt??n B??sz??rm??nyi
Thanks,
applied to nvme-5.12 with a slight tweak to the commit message.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-24 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 5:12 [PATCH] nvme: Apply the same fix Kingston SKC2000 nVME SSD as A2000 Zoltán Böszörményi
2021-02-24 9:19 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).