* [PATCH] staging: kpc2000: code style: fix alignment issues
@ 2021-02-18 20:28 Nikolay Kyx
2021-02-18 20:52 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Nikolay Kyx @ 2021-02-18 20:28 UTC (permalink / raw)
To: gregkh, sergiu.cuciurean; +Cc: Nikolay Kyx, devel, linux-kernel
kpc2000_i2c.c:
fix WARNING: line length of 124 exceeds 100 columns
fix CHECK: Alignment should match open parenthesis
kpc2000_spi.c:
fix CHECK: Alignment should match open parenthesis
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
drivers/staging/kpc2000/kpc2000_i2c.c | 6 ++++--
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..14f7940fa4fb 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -200,7 +200,9 @@ static int i801_check_post(struct kpc_i2c *priv, int status, int timeout)
outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
if (status)
- dev_warn(&priv->adapter.dev, "Failed clearing status flags at end of transaction (%02x)\n", status);
+ dev_warn(&priv->adapter.dev,
+ "Failed clearing status flags at end of transaction (%02x)\n",
+ status);
}
return result;
@@ -269,7 +271,7 @@ static int i801_block_transaction_by_block(struct kpc_i2c *priv,
}
status = i801_transaction(priv,
- I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
+ I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
if (status)
return status;
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 44017d523da5..16ca18b8aa15 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -465,7 +465,7 @@ kp_spi_probe(struct platform_device *pldev)
}
kpspi->base = devm_ioremap(&pldev->dev, r->start,
- resource_size(r));
+ resource_size(r));
status = spi_register_master(master);
if (status < 0) {
--
2.30.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] staging: kpc2000: code style: fix alignment issues
2021-02-18 20:28 [PATCH] staging: kpc2000: code style: fix alignment issues Nikolay Kyx
@ 2021-02-18 20:52 ` Greg KH
2021-02-19 8:04 ` [PATCH v2] " Nikolay Kyx
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2021-02-18 20:52 UTC (permalink / raw)
To: Nikolay Kyx; +Cc: sergiu.cuciurean, devel, linux-kernel
On Thu, Feb 18, 2021 at 11:28:14PM +0300, Nikolay Kyx wrote:
> kpc2000_i2c.c:
> fix WARNING: line length of 124 exceeds 100 columns
> fix CHECK: Alignment should match open parenthesis
>
> kpc2000_spi.c:
> fix CHECK: Alignment should match open parenthesis
This changelog is a bit odd.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what is needed in order
to properly describe the change.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] staging: kpc2000: code style: fix alignment issues
2021-02-18 20:52 ` Greg KH
@ 2021-02-19 8:04 ` Nikolay Kyx
2021-02-19 8:26 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Nikolay Kyx @ 2021-02-19 8:04 UTC (permalink / raw)
To: gregkh, sergiu.cuciurean; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl warnings:
WARNING: line length of 124 exceeds 100 columns
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c | 6 ++++--
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..14f7940fa4fb 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -200,7 +200,9 @@ static int i801_check_post(struct kpc_i2c *priv, int status, int timeout)
outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
if (status)
- dev_warn(&priv->adapter.dev, "Failed clearing status flags at end of transaction (%02x)\n", status);
+ dev_warn(&priv->adapter.dev,
+ "Failed clearing status flags at end of transaction (%02x)\n",
+ status);
}
return result;
@@ -269,7 +271,7 @@ static int i801_block_transaction_by_block(struct kpc_i2c *priv,
}
status = i801_transaction(priv,
- I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
+ I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
if (status)
return status;
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 44017d523da5..16ca18b8aa15 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -465,7 +465,7 @@ kp_spi_probe(struct platform_device *pldev)
}
kpspi->base = devm_ioremap(&pldev->dev, r->start,
- resource_size(r));
+ resource_size(r));
status = spi_register_master(master);
if (status < 0) {
--
2.30.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] staging: kpc2000: code style: fix alignment issues
2021-02-19 8:04 ` [PATCH v2] " Nikolay Kyx
@ 2021-02-19 8:26 ` Greg KH
2021-02-19 16:34 ` [PATCH v3 01/02] " Nikolay Kyx
2021-02-19 16:34 ` [PATCH v3 02/02] staging: kpc2000: code style: fix alignment issues Nikolay Kyx
0 siblings, 2 replies; 9+ messages in thread
From: Greg KH @ 2021-02-19 8:26 UTC (permalink / raw)
To: Nikolay Kyx; +Cc: sergiu.cuciurean, devel, linux-kernel
On Fri, Feb 19, 2021 at 11:04:51AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: line length of 124 exceeds 100 columns
> CHECK: Alignment should match open parenthesis
That's two different things, please make this two different patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 01/02] staging: kpc2000: code style: fix alignment issues
2021-02-19 8:26 ` Greg KH
@ 2021-02-19 16:34 ` Nikolay Kyx
2021-02-21 13:03 ` Greg KH
2021-02-19 16:34 ` [PATCH v3 02/02] staging: kpc2000: code style: fix alignment issues Nikolay Kyx
1 sibling, 1 reply; 9+ messages in thread
From: Nikolay Kyx @ 2021-02-19 16:34 UTC (permalink / raw)
To: gregkh, sergiu.cuciurean; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
v3: Splitted patch in two parts, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c | 2 +-
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..3f1f833d3b51 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -269,7 +269,7 @@ static int i801_block_transaction_by_block(struct kpc_i2c *priv,
}
status = i801_transaction(priv,
- I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
+ I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
if (status)
return status;
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 44017d523da5..16ca18b8aa15 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -465,7 +465,7 @@ kp_spi_probe(struct platform_device *pldev)
}
kpspi->base = devm_ioremap(&pldev->dev, r->start,
- resource_size(r));
+ resource_size(r));
status = spi_register_master(master);
if (status < 0) {
--
2.30.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 01/02] staging: kpc2000: code style: fix alignment issues
2021-02-19 16:34 ` [PATCH v3 01/02] " Nikolay Kyx
@ 2021-02-21 13:03 ` Greg KH
2021-02-21 13:22 ` [PATCH v4 01/02] staging: kpc2000: code style: match alignment with open parenthesis Nikolay Kyx
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2021-02-21 13:03 UTC (permalink / raw)
To: Nikolay Kyx; +Cc: sergiu.cuciurean, devel, linux-kernel
On Fri, Feb 19, 2021 at 07:34:11PM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl check:
>
> CHECK: Alignment should match open parenthesis
>
> in files kpc2000_i2c.c kpc2000_spi.c
>
> Signed-off-by: Nikolay Kyx <knv418@gmail.com>
> ---
>
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
>
> v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
> v3: Splitted patch in two parts, as suggested by Greg KH <gregkh@linuxfoundation.org>
You sent 2 different patches, that did different things, yet have the
same exact subject line :(
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 01/02] staging: kpc2000: code style: match alignment with open parenthesis
2021-02-21 13:03 ` Greg KH
@ 2021-02-21 13:22 ` Nikolay Kyx
2021-02-21 13:22 ` [PATCH v4 02/02] staging: kpc2000: code style: fix line length issue Nikolay Kyx
0 siblings, 1 reply; 9+ messages in thread
From: Nikolay Kyx @ 2021-02-21 13:22 UTC (permalink / raw)
To: gregkh, sergiu.cuciurean; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
v3: Splitted patch in two parts, as suggested by Greg KH <gregkh@linuxfoundation.org>
v4: Changed patch subject line, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c | 2 +-
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..3f1f833d3b51 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -269,7 +269,7 @@ static int i801_block_transaction_by_block(struct kpc_i2c *priv,
}
status = i801_transaction(priv,
- I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
+ I801_BLOCK_DATA | ENABLE_INT9 | I801_PEC_EN * hwpec);
if (status)
return status;
diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000/kpc2000_spi.c
index 44017d523da5..16ca18b8aa15 100644
--- a/drivers/staging/kpc2000/kpc2000_spi.c
+++ b/drivers/staging/kpc2000/kpc2000_spi.c
@@ -465,7 +465,7 @@ kp_spi_probe(struct platform_device *pldev)
}
kpspi->base = devm_ioremap(&pldev->dev, r->start,
- resource_size(r));
+ resource_size(r));
status = spi_register_master(master);
if (status < 0) {
--
2.30.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v4 02/02] staging: kpc2000: code style: fix line length issue
2021-02-21 13:22 ` [PATCH v4 01/02] staging: kpc2000: code style: match alignment with open parenthesis Nikolay Kyx
@ 2021-02-21 13:22 ` Nikolay Kyx
0 siblings, 0 replies; 9+ messages in thread
From: Nikolay Kyx @ 2021-02-21 13:22 UTC (permalink / raw)
To: gregkh, sergiu.cuciurean; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl warning:
WARNING: line length of 124 exceeds 100 columns
in file kpc2000_i2c.c
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
v3: Splitted patch in two parts, as suggested by Greg KH <gregkh@linuxfoundation.org>
v4: Changed patch subject line, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..68f5ec000365 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -200,7 +200,9 @@ static int i801_check_post(struct kpc_i2c *priv, int status, int timeout)
outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
if (status)
- dev_warn(&priv->adapter.dev, "Failed clearing status flags at end of transaction (%02x)\n", status);
+ dev_warn(&priv->adapter.dev,
+ "Failed clearing status flags at end of transaction (%02x)\n",
+ status);
}
return result;
--
2.30.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 02/02] staging: kpc2000: code style: fix alignment issues
2021-02-19 8:26 ` Greg KH
2021-02-19 16:34 ` [PATCH v3 01/02] " Nikolay Kyx
@ 2021-02-19 16:34 ` Nikolay Kyx
1 sibling, 0 replies; 9+ messages in thread
From: Nikolay Kyx @ 2021-02-19 16:34 UTC (permalink / raw)
To: gregkh, sergiu.cuciurean; +Cc: Nikolay Kyx, devel, linux-kernel
This patch fixes the following checkpatch.pl warning:
WARNING: line length of 124 exceeds 100 columns
in file kpc2000_i2c.c
Signed-off-by: Nikolay Kyx <knv418@gmail.com>
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH <gregkh@linuxfoundation.org>
v3: Splitted patch in two parts, as suggested by Greg KH <gregkh@linuxfoundation.org>
drivers/staging/kpc2000/kpc2000_i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 25bb5c97dd21..68f5ec000365 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -200,7 +200,9 @@ static int i801_check_post(struct kpc_i2c *priv, int status, int timeout)
outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
if (status)
- dev_warn(&priv->adapter.dev, "Failed clearing status flags at end of transaction (%02x)\n", status);
+ dev_warn(&priv->adapter.dev,
+ "Failed clearing status flags at end of transaction (%02x)\n",
+ status);
}
return result;
--
2.30.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-21 13:25 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 20:28 [PATCH] staging: kpc2000: code style: fix alignment issues Nikolay Kyx
2021-02-18 20:52 ` Greg KH
2021-02-19 8:04 ` [PATCH v2] " Nikolay Kyx
2021-02-19 8:26 ` Greg KH
2021-02-19 16:34 ` [PATCH v3 01/02] " Nikolay Kyx
2021-02-21 13:03 ` Greg KH
2021-02-21 13:22 ` [PATCH v4 01/02] staging: kpc2000: code style: match alignment with open parenthesis Nikolay Kyx
2021-02-21 13:22 ` [PATCH v4 02/02] staging: kpc2000: code style: fix line length issue Nikolay Kyx
2021-02-19 16:34 ` [PATCH v3 02/02] staging: kpc2000: code style: fix alignment issues Nikolay Kyx
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).