* [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2
@ 2021-02-22 14:15 Alban Bedel
2021-02-22 15:21 ` Alexander Kobel
2021-03-04 13:43 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Alban Bedel @ 2021-02-22 14:15 UTC (permalink / raw)
To: Alex Hung
Cc: Hans de Goede, Mark Gross, platform-driver-x86, linux-kernel,
Alban Bedel
Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the
HEBC method, which prevent the power button from working. Add a quirk
to enable the button array on this system family and fix the power
button.
Signed-off-by: Alban Bedel <albeu@free.fr>
---
drivers/platform/x86/intel-hid.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 2f5b8d09143e..57cc92891a57 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -90,6 +90,13 @@ static const struct dmi_system_id button_array_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
},
},
+ {
+ .ident = "Lenovo ThinkPad X1 Tablet Gen 2",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"),
+ },
+ },
{ }
};
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2
2021-02-22 14:15 [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2 Alban Bedel
@ 2021-02-22 15:21 ` Alexander Kobel
2021-03-04 13:43 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Kobel @ 2021-02-22 15:21 UTC (permalink / raw)
To: Alban Bedel, Alex Hung
Cc: Hans de Goede, Mark Gross, platform-driver-x86, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]
Hi,
LGTM. Tested on an affected device (20JCS00C00). Works like a charm.
Thanks,
Alex
On 2/22/21 3:15 PM, Alban Bedel wrote:
> Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the
> HEBC method, which prevent the power button from working. Add a quirk
> to enable the button array on this system family and fix the power
> button.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>
> ---
> drivers/platform/x86/intel-hid.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 2f5b8d09143e..57cc92891a57 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -90,6 +90,13 @@ static const struct dmi_system_id button_array_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
> },
> },
> + {
> + .ident = "Lenovo ThinkPad X1 Tablet Gen 2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"),
> + },
> + },
> { }
> };
>
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5916 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2
2021-02-22 14:15 [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2 Alban Bedel
2021-02-22 15:21 ` Alexander Kobel
@ 2021-03-04 13:43 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-03-04 13:43 UTC (permalink / raw)
To: Alban Bedel, Alex Hung; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 2/22/21 3:15 PM, Alban Bedel wrote:
> Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the
> HEBC method, which prevent the power button from working. Add a quirk
> to enable the button array on this system family and fix the power
> button.
>
> Signed-off-by: Alban Bedel <albeu@free.fr>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/intel-hid.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 2f5b8d09143e..57cc92891a57 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -90,6 +90,13 @@ static const struct dmi_system_id button_array_table[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
> },
> },
> + {
> + .ident = "Lenovo ThinkPad X1 Tablet Gen 2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"),
> + },
> + },
> { }
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-04 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 14:15 [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2 Alban Bedel
2021-02-22 15:21 ` Alexander Kobel
2021-03-04 13:43 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).