* [PATCH] sound: core: fixed coding style errors
@ 2021-02-22 19:41 Rajesh Kumbhakar
2021-02-23 6:39 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Rajesh Kumbhakar @ 2021-02-22 19:41 UTC (permalink / raw)
To: perex, tiwai, sfr; +Cc: alsa-devel, linux-kernel, Rajesh Kumbhakar
fixing ERROR: "foo * bar" should be "foo *bar"
fixing WARNING: Missing a blank line after declarations
Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
---
sound/core/hwdep_compat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
index a0b76706c..d8624a14a 100644
--- a/sound/core/hwdep_compat.c
+++ b/sound/core/hwdep_compat.c
@@ -36,11 +36,13 @@ enum {
SNDRV_HWDEP_IOCTL_DSP_LOAD32 = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
};
-static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
+static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
unsigned long arg)
{
struct snd_hwdep *hw = file->private_data;
+
void __user *argp = compat_ptr(arg);
+
switch (cmd) {
case SNDRV_HWDEP_IOCTL_PVERSION:
case SNDRV_HWDEP_IOCTL_INFO:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sound: core: fixed coding style errors
2021-02-22 19:41 [PATCH] sound: core: fixed coding style errors Rajesh Kumbhakar
@ 2021-02-23 6:39 ` Takashi Iwai
2021-02-23 6:47 ` Rajesh Kumbhakar
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2021-02-23 6:39 UTC (permalink / raw)
To: Rajesh Kumbhakar; +Cc: perex, tiwai, sfr, alsa-devel, linux-kernel
On Mon, 22 Feb 2021 20:41:56 +0100,
Rajesh Kumbhakar wrote:
>
> fixing ERROR: "foo * bar" should be "foo *bar"
> fixing WARNING: Missing a blank line after declarations
>
> Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
> ---
> sound/core/hwdep_compat.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
> index a0b76706c..d8624a14a 100644
> --- a/sound/core/hwdep_compat.c
> +++ b/sound/core/hwdep_compat.c
> @@ -36,11 +36,13 @@ enum {
> SNDRV_HWDEP_IOCTL_DSP_LOAD32 = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
> };
>
> -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
> +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
> unsigned long arg)
> {
> struct snd_hwdep *hw = file->private_data;
> +
> void __user *argp = compat_ptr(arg);
You shouldn't put a blank line here.
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-23 6:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 19:41 [PATCH] sound: core: fixed coding style errors Rajesh Kumbhakar
2021-02-23 6:39 ` Takashi Iwai
2021-02-23 6:47 ` Rajesh Kumbhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).