* linux-next: Signed-off-by missing for commits in Linus' tree
@ 2021-02-24 0:31 Stephen Rothwell
2021-02-24 0:33 ` Linus Torvalds
2021-02-24 19:52 ` Kees Cook
0 siblings, 2 replies; 7+ messages in thread
From: Stephen Rothwell @ 2021-02-24 0:31 UTC (permalink / raw)
To: Kees Cook
Cc: Linus Torvalds, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
Hi all,
Commits
b33fff07e3e3 ("x86, build: allow LTO to be selected")
d2dcd3e37475 ("x86, cpu: disable LTO for cpu.c")
e242db40be27 ("x86, vdso: disable LTO only for vDSO")
b1a1a1a09b46 ("kbuild: lto: postpone objtool")
41425ebe2024 ("objtool: Split noinstr validation from --vmlinux")
6dafca978033 ("x86, build: use objtool mcount")
22c8542d7b22 ("tracing: add support for objtool mcount")
0e731dbc1824 ("objtool: Don't autodetect vmlinux.o")
18a14575ae31 ("objtool: Fix __mcount_loc generation with Clang's assembler")
99d0021569c7 ("objtool: Add a pass for generating __mcount_loc")
are missing a Signed-off-by from their committer.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commits in Linus' tree
2021-02-24 0:31 linux-next: Signed-off-by missing for commits in Linus' tree Stephen Rothwell
@ 2021-02-24 0:33 ` Linus Torvalds
2021-02-24 0:49 ` Stephen Rothwell
2021-02-24 19:52 ` Kees Cook
1 sibling, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2021-02-24 0:33 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kees Cook, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Feb 23, 2021 at 4:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> are missing a Signed-off-by from their committer.
Gaah. Maybe I should do some pre-pull hook or something to notice this
automatically (like you clearly do).
Linus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commits in Linus' tree
2021-02-24 0:33 ` Linus Torvalds
@ 2021-02-24 0:49 ` Stephen Rothwell
2021-02-24 20:27 ` Kees Cook
2021-02-24 21:30 ` Kees Cook
0 siblings, 2 replies; 7+ messages in thread
From: Stephen Rothwell @ 2021-02-24 0:49 UTC (permalink / raw)
To: Linus Torvalds
Cc: Kees Cook, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]
Hi Linus,
On Tue, 23 Feb 2021 16:33:47 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Tue, Feb 23, 2021 at 4:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > are missing a Signed-off-by from their committer.
>
> Gaah. Maybe I should do some pre-pull hook or something to notice this
> automatically (like you clearly do).
I have attached the scripts I run over things after fetching them, but
before merging them (so not a hook, sorry). check_commits runs
check_fixes - but just for my convenience.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: check_commits --]
[-- Type: application/x-shellscript, Size: 1611 bytes --]
[-- Attachment #1.3: check_fixes --]
[-- Type: application/x-shellscript, Size: 4299 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commits in Linus' tree
2021-02-24 0:31 linux-next: Signed-off-by missing for commits in Linus' tree Stephen Rothwell
2021-02-24 0:33 ` Linus Torvalds
@ 2021-02-24 19:52 ` Kees Cook
1 sibling, 0 replies; 7+ messages in thread
From: Kees Cook @ 2021-02-24 19:52 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linus Torvalds, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, Feb 24, 2021 at 11:31:08AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> b33fff07e3e3 ("x86, build: allow LTO to be selected")
> d2dcd3e37475 ("x86, cpu: disable LTO for cpu.c")
> e242db40be27 ("x86, vdso: disable LTO only for vDSO")
> b1a1a1a09b46 ("kbuild: lto: postpone objtool")
> 41425ebe2024 ("objtool: Split noinstr validation from --vmlinux")
> 6dafca978033 ("x86, build: use objtool mcount")
> 22c8542d7b22 ("tracing: add support for objtool mcount")
> 0e731dbc1824 ("objtool: Don't autodetect vmlinux.o")
> 18a14575ae31 ("objtool: Fix __mcount_loc generation with Clang's assembler")
> 99d0021569c7 ("objtool: Add a pass for generating __mcount_loc")
>
> are missing a Signed-off-by from their committer.
Ieeeee! Ugh, yes, my bad, entirely. I screwed up when rebuilding the
LTO "part 2" series for the -rc1 window (missed the -s on the cherry-pick).
Since we can't change git history, the best fix I can do is send it here
to the list. Obviously, these should all be considered:
Signed-off-by: Kees Cook <keescook@chromium.org>
Again, apologies. I, too, will add a commit hook to check for this. (Is
there an existing script anyone else is already using?)
--
Kees Cook
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commits in Linus' tree
2021-02-24 0:49 ` Stephen Rothwell
@ 2021-02-24 20:27 ` Kees Cook
2021-02-24 21:30 ` Kees Cook
1 sibling, 0 replies; 7+ messages in thread
From: Kees Cook @ 2021-02-24 20:27 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linus Torvalds, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, Feb 24, 2021 at 11:49:42AM +1100, Stephen Rothwell wrote:
> Hi Linus,
>
> On Tue, 23 Feb 2021 16:33:47 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> > On Tue, Feb 23, 2021 at 4:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > are missing a Signed-off-by from their committer.
> >
> > Gaah. Maybe I should do some pre-pull hook or something to notice this
> > automatically (like you clearly do).
>
> I have attached the scripts I run over things after fetching them, but
> before merging them (so not a hook, sorry). check_commits runs
> check_fixes - but just for my convenience.
Thank you! I've added these to my PR workflow now, and it yells quite loudly.
I'm still looking at some kind of push hook too...
--
Kees Cook
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commits in Linus' tree
2021-02-24 0:49 ` Stephen Rothwell
2021-02-24 20:27 ` Kees Cook
@ 2021-02-24 21:30 ` Kees Cook
2021-02-27 23:38 ` Linus Walleij
1 sibling, 1 reply; 7+ messages in thread
From: Kees Cook @ 2021-02-24 21:30 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linus Torvalds, Linux Kernel Mailing List,
Linux Next Mailing List, Linus Walleij, Jonathan Corbet, Greg KH
On Wed, Feb 24, 2021 at 11:49:42AM +1100, Stephen Rothwell wrote:
> Hi Linus,
>
> On Tue, 23 Feb 2021 16:33:47 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> > On Tue, Feb 23, 2021 at 4:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > are missing a Signed-off-by from their committer.
> >
> > Gaah. Maybe I should do some pre-pull hook or something to notice this
> > automatically (like you clearly do).
>
> I have attached the scripts I run over things after fetching them, but
> before merging them (so not a hook, sorry). check_commits runs
> check_fixes - but just for my convenience.
>
> --
> Cheers,
> Stephen Rothwell
Based on the pre-push.sample file, here is what I've added to my
.git/hooks/pre-push hook:
z40=0000000000000000000000000000000000000000
while read local_ref local_sha remote_ref remote_sha
do
if [ "$local_sha" = $z40 ]
then
# Handle delete
:
else
if [ "$remote_sha" = $z40 ]
then
# New branch, examine all commits
range="$local_sha"
else
# Update to existing branch, examine new commits
range="$remote_sha..$local_sha"
fi
if ! $HOME/bin/check_commits "$range"; then
exit 1
fi
fi
done
(and I modified check_fixes and check_commits to exit non-zero on failure)
I wonder if we need this in Documentation/maintainer/configure-git.rst
and to put check_commits and check_fixes into tools/ somewhere?
(Though goodness, please never aim your hook at your tree's tools/
directory.)
--
Kees Cook
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Signed-off-by missing for commits in Linus' tree
2021-02-24 21:30 ` Kees Cook
@ 2021-02-27 23:38 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2021-02-27 23:38 UTC (permalink / raw)
To: Kees Cook
Cc: Stephen Rothwell, Linus Torvalds, Linux Kernel Mailing List,
Linux Next Mailing List, Jonathan Corbet, Greg KH
On Wed, Feb 24, 2021 at 10:30 PM Kees Cook <keescook@chromium.org> wrote:
> I wonder if we need this in Documentation/maintainer/configure-git.rst
That is generally a good idea.
> and to put check_commits and check_fixes into tools/ somewhere?
People keep saying we should put git hooks somewhere where
they can be reused easily. What about just creating
scripts/git-hooks?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-27 23:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-24 0:31 linux-next: Signed-off-by missing for commits in Linus' tree Stephen Rothwell
2021-02-24 0:33 ` Linus Torvalds
2021-02-24 0:49 ` Stephen Rothwell
2021-02-24 20:27 ` Kees Cook
2021-02-24 21:30 ` Kees Cook
2021-02-27 23:38 ` Linus Walleij
2021-02-24 19:52 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).