udldrmfb: causes WARN in i915 on X60 (x86-32)

udldrmfb: causes WARN in i915 on X60 (x86-32)

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 4041 bytes --]

Hi!

This is in -next, but I get same behaviour on 5.11; and no, udl does
not work, but monitor is detected:

pavel@amd:~/g/tui/crashled$ xrandr 
Screen 0: minimum 320 x 200, current 1024 x 768, maximum 4096 x 4096
LVDS1 connected 1024x768+0+0 (normal left inverted right x axis y axis) 246mm x 185mm
   1024x768      50.00*+  60.00    40.00  
   800x600       60.32    56.25  
   640x480       59.94  
VGA1 disconnected (normal left inverted right x axis y axis)
DVI-1-0 connected 1024x768+0+0 304mm x 228mm
   1024x768      60.00*+  75.03  
   800x600       75.00    60.32  
   640x480       75.00    59.94  
   720x400       70.08  
  1024x768 (0x45) 65.000MHz -HSync -VSync
        h: width  1024 start 1048 end 1184 total 1344 skew    0 clock  48.36KHz
        v: height  768 start  771 end  777 total  806           clock  60.00Hz
  800x600 (0x47) 40.000MHz +HSync +VSync
        h: width   800 start  840 end  968 total 1056 skew    0 clock  37.88KHz
        v: height  600 start  601 end  605 total  628           clock  60.32Hz
  640x480 (0x49) 25.175MHz -HSync -VSync
        h: width   640 start  656 end  752 total  800 skew    0 clock  31.47KHz
        v: height  480 start  490 end  492 total  525           clock  59.94Hz
pavel@amd:~/g/tui/crashled$ 


[13957.499755] wlan0: associated
[13962.906368] udl 1-5:1.0: [drm] fb1: udldrmfb frame buffer device
[13972.585101] ------------[ cut here ]------------
[13972.585117] WARNING: CPU: 0 PID: 3159 at kernel/dma/mapping.c:192 dma_map_sg_attrs+0x38/0x50
[13972.585137] Modules linked in:
[13972.585149] CPU: 0 PID: 3159 Comm: Xorg Not tainted 5.11.0-next-20210223+ #176
[13972.585158] Hardware name: LENOVO 17097HU/17097HU, BIOS 7BETD8WW (2.19 ) 03/31/2011
[13972.585166] EIP: dma_map_sg_attrs+0x38/0x50
[13972.585176] Code: f0 01 00 00 00 74 23 ff 75 0c 53 e8 72 1b 00 00 5a 59 85 c0 78 1c 8b 5d fc c9 c3 8d b4 26 00 00 00 00 0f 0b 8d b6 00 00 00 00 <0f> 0b 31 c0 eb e6 66 90 0f 0b 8d b4 26 00 00 00 00 8d b4 26 00 00
[13972.585186] EAX: c296c41c EBX: 00000000 ECX: 00000055 EDX: dbbc4800
[13972.585194] ESI: c69f9ea0 EDI: d2c313c0 EBP: c5cbdda8 ESP: c5cbdda4
[13972.585202] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00210246
[13972.585211] CR0: 80050033 CR2: b6b99000 CR3: 05d42000 CR4: 000006b0
[13972.585219] Call Trace:
[13972.585227]  i915_gem_map_dma_buf+0xee/0x160
[13972.585240]  dma_buf_map_attachment+0xb8/0x140
[13972.585251]  drm_gem_prime_import_dev.part.0+0x33/0xc0
[13972.585262]  ? drm_gem_shmem_create+0x10/0x10
[13972.585271]  drm_gem_prime_import_dev+0x22/0x70
[13972.585280]  drm_gem_prime_fd_to_handle+0x186/0x1c0
[13972.585289]  ? drm_gem_prime_import_dev+0x70/0x70
[13972.585298]  ? drm_prime_destroy_file_private+0x20/0x20
[13972.585307]  drm_prime_fd_to_handle_ioctl+0x1c/0x30
[13972.585315]  drm_ioctl_kernel+0x8e/0xe0
[13972.585325]  ? drm_prime_destroy_file_private+0x20/0x20
[13972.585334]  drm_ioctl+0x1fd/0x380
[13972.585343]  ? drm_prime_destroy_file_private+0x20/0x20
[13972.585352]  ? ksys_write+0x5c/0xd0
[13972.585363]  ? vfs_write+0xeb/0x3f0
[13972.585371]  ? drm_ioctl_kernel+0xe0/0xe0
[13972.585380]  __ia32_sys_ioctl+0x369/0x7d0
[13972.585389]  ? exit_to_user_mode_prepare+0x4e/0x170
[13972.585398]  do_int80_syscall_32+0x2c/0x40
[13972.585409]  entry_INT80_32+0x111/0x111
[13972.585419] EIP: 0xb7f68092
[13972.585427] Code: 00 00 00 e9 90 ff ff ff ff a3 24 00 00 00 68 30 00 00 00 e9 80 ff ff ff ff a3 e8 ff ff ff 66 90 00 00 00 00 00 00 00 00 cd 80 <c3> 8d b4 26 00 00 00 00 8d b6 00 00 00 00 8b 1c 24 c3 8d b4 26 00
[13972.585436] EAX: ffffffda EBX: 00000030 ECX: c00c642e EDX: bfaeda30
[13972.585444] ESI: 00915790 EDI: c00c642e EBP: 00000030 ESP: bfaed9e4
[13972.585452] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00200296
[13972.585461]  ? asm_exc_nmi+0xcc/0x2bc
[13972.585470] ---[ end trace 46a21fad0595bc89 ]---
pavel@amd:~/g/tui/crashled$ 

Any ideas?

Best regards,

									Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 4654 bytes --]

Hi

Am 24.02.21 um 21:09 schrieb Pavel Machek:
> Hi!
> 
> This is in -next, but I get same behaviour on 5.11; and no, udl does

Thanks for reporting. We are in the process of fixing the issue. The 
latest patch is at [1].

Best regards
Thomas

[1] 
https://lore.kernel.org/dri-devel/b44307cf-25f9-acd0-eb35-92e8716205de@suse.de/T/#m74795744a58836dcba055fdcd6a0697811b8c14b

> not work, but monitor is detected:
> 
> pavel@amd:~/g/tui/crashled$ xrandr
> Screen 0: minimum 320 x 200, current 1024 x 768, maximum 4096 x 4096
> LVDS1 connected 1024x768+0+0 (normal left inverted right x axis y axis) 246mm x 185mm
>     1024x768      50.00*+  60.00    40.00
>     800x600       60.32    56.25
>     640x480       59.94
> VGA1 disconnected (normal left inverted right x axis y axis)
> DVI-1-0 connected 1024x768+0+0 304mm x 228mm
>     1024x768      60.00*+  75.03
>     800x600       75.00    60.32
>     640x480       75.00    59.94
>     720x400       70.08
>    1024x768 (0x45) 65.000MHz -HSync -VSync
>          h: width  1024 start 1048 end 1184 total 1344 skew    0 clock  48.36KHz
>          v: height  768 start  771 end  777 total  806           clock  60.00Hz
>    800x600 (0x47) 40.000MHz +HSync +VSync
>          h: width   800 start  840 end  968 total 1056 skew    0 clock  37.88KHz
>          v: height  600 start  601 end  605 total  628           clock  60.32Hz
>    640x480 (0x49) 25.175MHz -HSync -VSync
>          h: width   640 start  656 end  752 total  800 skew    0 clock  31.47KHz
>          v: height  480 start  490 end  492 total  525           clock  59.94Hz
> pavel@amd:~/g/tui/crashled$
> 
> 
> [13957.499755] wlan0: associated
> [13962.906368] udl 1-5:1.0: [drm] fb1: udldrmfb frame buffer device
> [13972.585101] ------------[ cut here ]------------
> [13972.585117] WARNING: CPU: 0 PID: 3159 at kernel/dma/mapping.c:192 dma_map_sg_attrs+0x38/0x50
> [13972.585137] Modules linked in:
> [13972.585149] CPU: 0 PID: 3159 Comm: Xorg Not tainted 5.11.0-next-20210223+ #176
> [13972.585158] Hardware name: LENOVO 17097HU/17097HU, BIOS 7BETD8WW (2.19 ) 03/31/2011
> [13972.585166] EIP: dma_map_sg_attrs+0x38/0x50
> [13972.585176] Code: f0 01 00 00 00 74 23 ff 75 0c 53 e8 72 1b 00 00 5a 59 85 c0 78 1c 8b 5d fc c9 c3 8d b4 26 00 00 00 00 0f 0b 8d b6 00 00 00 00 <0f> 0b 31 c0 eb e6 66 90 0f 0b 8d b4 26 00 00 00 00 8d b4 26 00 00
> [13972.585186] EAX: c296c41c EBX: 00000000 ECX: 00000055 EDX: dbbc4800
> [13972.585194] ESI: c69f9ea0 EDI: d2c313c0 EBP: c5cbdda8 ESP: c5cbdda4
> [13972.585202] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 EFLAGS: 00210246
> [13972.585211] CR0: 80050033 CR2: b6b99000 CR3: 05d42000 CR4: 000006b0
> [13972.585219] Call Trace:
> [13972.585227]  i915_gem_map_dma_buf+0xee/0x160
> [13972.585240]  dma_buf_map_attachment+0xb8/0x140
> [13972.585251]  drm_gem_prime_import_dev.part.0+0x33/0xc0
> [13972.585262]  ? drm_gem_shmem_create+0x10/0x10
> [13972.585271]  drm_gem_prime_import_dev+0x22/0x70
> [13972.585280]  drm_gem_prime_fd_to_handle+0x186/0x1c0
> [13972.585289]  ? drm_gem_prime_import_dev+0x70/0x70
> [13972.585298]  ? drm_prime_destroy_file_private+0x20/0x20
> [13972.585307]  drm_prime_fd_to_handle_ioctl+0x1c/0x30
> [13972.585315]  drm_ioctl_kernel+0x8e/0xe0
> [13972.585325]  ? drm_prime_destroy_file_private+0x20/0x20
> [13972.585334]  drm_ioctl+0x1fd/0x380
> [13972.585343]  ? drm_prime_destroy_file_private+0x20/0x20
> [13972.585352]  ? ksys_write+0x5c/0xd0
> [13972.585363]  ? vfs_write+0xeb/0x3f0
> [13972.585371]  ? drm_ioctl_kernel+0xe0/0xe0
> [13972.585380]  __ia32_sys_ioctl+0x369/0x7d0
> [13972.585389]  ? exit_to_user_mode_prepare+0x4e/0x170
> [13972.585398]  do_int80_syscall_32+0x2c/0x40
> [13972.585409]  entry_INT80_32+0x111/0x111
> [13972.585419] EIP: 0xb7f68092
> [13972.585427] Code: 00 00 00 e9 90 ff ff ff ff a3 24 00 00 00 68 30 00 00 00 e9 80 ff ff ff ff a3 e8 ff ff ff 66 90 00 00 00 00 00 00 00 00 cd 80 <c3> 8d b4 26 00 00 00 00 8d b6 00 00 00 00 8b 1c 24 c3 8d b4 26 00
> [13972.585436] EAX: ffffffda EBX: 00000030 ECX: c00c642e EDX: bfaeda30
> [13972.585444] ESI: 00915790 EDI: c00c642e EBP: 00000030 ESP: bfaed9e4
> [13972.585452] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 007b EFLAGS: 00200296
> [13972.585461]  ? asm_exc_nmi+0xcc/0x2bc
> [13972.585470] ---[ end trace 46a21fad0595bc89 ]---
> pavel@amd:~/g/tui/crashled$
> 
> Any ideas?
> 
> Best regards,
> 
> 									Pavel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi!

> >This is in -next, but I get same behaviour on 5.11; and no, udl does
> 
> Thanks for reporting. We are in the process of fixing the issue. The latest
> patch is at [1].
>

Thank you, that fixes the DMA issue, and I can use the udl.

...for a while. Then screensaver blanks laptop screen, udl screen
blanks too. Upon hitting a key, internal screen shows up, udl does
not.

I try rerunning xrandr ... --auto, but could not recover it.

Any ideas?

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1193 bytes --]

Hi

Am 25.02.21 um 10:53 schrieb Pavel Machek:
> Hi!
> 
>>> This is in -next, but I get same behaviour on 5.11; and no, udl does
>>
>> Thanks for reporting. We are in the process of fixing the issue. The latest
>> patch is at [1].
>>
> 
> Thank you, that fixes the DMA issue, and I can use the udl.
> 
> ...for a while. Then screensaver blanks laptop screen, udl screen
> blanks too. Upon hitting a key, internal screen shows up, udl does
> not.
> 
> I try rerunning xrandr ... --auto, but could not recover it.
> 
> Any ideas?

Did it work before the regression?

For testing, could you please remove the fix and then do

   git revert 6eb0233ec2d0

This would restore the old version. Please report back on the results.

Best regards
Thomas

> 
> Best regards,
> 								Pavel
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hi!

> > Thank you, that fixes the DMA issue, and I can use the udl.
> > 
> > ...for a while. Then screensaver blanks laptop screen, udl screen
> > blanks too. Upon hitting a key, internal screen shows up, udl does
> > not.
> > 
> > I try rerunning xrandr ... --auto, but could not recover it.
> > 
> > Any ideas?
> 
> Did it work before the regression?

I don't know. I'm trying to get it to work, I basically did not use it before.

> For testing, could you please remove the fix and then do
> 
>   git revert 6eb0233ec2d0
> 
> This would restore the old version. Please report back on the results.

I doubt this is related, but I can try.

Best regards,
									Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]

Hi!

> > > > This is in -next, but I get same behaviour on 5.11; and no, udl does
> > > 
> > > Thanks for reporting. We are in the process of fixing the issue. The latest
> > > patch is at [1].
> > > 
> > 
> > Thank you, that fixes the DMA issue, and I can use the udl.
> > 
> > ...for a while. Then screensaver blanks laptop screen, udl screen
> > blanks too. Upon hitting a key, internal screen shows up, udl does
> > not.
> > 
> > I try rerunning xrandr ... --auto, but could not recover it.
> > 
> > Any ideas?
> 
> Did it work before the regression?
> 
> For testing, could you please remove the fix and then do
> 
>   git revert 6eb0233ec2d0
> 
> This would restore the old version. Please report back on the
> results.

Ok, I went to 7f206cf3ec2b with 6eb0233ec2d0 reverted. That fails to
build:

drivers/usb/core/message.c: In function ‘usb_set_configuration’:
drivers/usb/core/message.c:2100:12: error: ‘struct device’ has no member named ‘dma_pfn_offset’
 2100 |   intf->dev.dma_pfn_offset = dev->dev.dma_pfn_offset;
      |            ^
drivers/usb/core/message.c:2100:38: error: ‘struct device’ has no member named ‘dma_pfn_offset’
 2100 |   intf->dev.dma_pfn_offset = dev->dev.dma_pfn_offset;
      |                                      ^
  CC      drivers/net/ethernet/intel/e1000e/param.o
make[3]: *** [scripts/Makefile.build:271: drivers/usb/core/message.o]
Error 1

So I tried to go to bad commit's parent:

git checkout 6eb0233ec2d0^
git log
commit cf141ae989e2ff119cd320326da5923b480d1641
    ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE

But that resulted in lockup soon after "--setprovidersource" command
was isued.

Best regards,
									Pavel

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: udldrm does not recover from powersave? Re: udldrmfb: causes WARN in i915 on X60 (x86-32)

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]

Hi

Am 25.02.21 um 10:53 schrieb Pavel Machek:
> Hi!
> 
>>> This is in -next, but I get same behaviour on 5.11; and no, udl does
>>
>> Thanks for reporting. We are in the process of fixing the issue. The latest
>> patch is at [1].
>>
> 
> Thank you, that fixes the DMA issue, and I can use the udl.
> 
> ...for a while. Then screensaver blanks laptop screen, udl screen
> blanks too. Upon hitting a key, internal screen shows up, udl does
> not.
> 
> I try rerunning xrandr ... --auto, but could not recover it.
> 
> Any ideas?

Seems unrelated. I tested for the issue with the last good revision and 
with the latest fix applied. I use Gnome/X11.

With both kernels, the udl adapter's display came back after suspending. 
So I'd attribute the problem to something else.

Best regards
Thomas

> 
> Best regards,
> 								Pavel
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]