linux-next: Fixes tag needs some work in the netfilter tree

linux-next: Fixes tag needs some work in the netfilter tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi all,

In commit

  8e24edddad15 ("netfilter: x_tables: gpf inside xt_find_revision()")

Fixes tag

  Fixes: 656caff20e1 ("netfilter 04/09: x_tables: fix match/target revision lookup")

has these problem(s):

  - SHA1 should be at least 12 digits long

I don't think it is worth rebasing to fix this, but it can be fixed for
future commits by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the netfilter tree

[Jozsef Kadlecsik]

Hi,

On Thu, 8 Feb 2024, Stephen Rothwell wrote:

> In commit
> 
>   6099505cd2a2 ("netfilter: ipset: Missing gc cancellations fixed")
> 
> Fixes tag
> 
>   Fixes: fdb8e12cc2cc ("netfilter: ipset: fix performance regression in swap operation")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant:
> 
> Fixes: 97f7cf1cd80e ("netfilter: ipset: fix performance regression in swap operation")

Yes, exactly. Accidentally I used the tag from my git tree and that caused 
the incorrect tag value. If that's OK, I'll send a fix for the nf-next 
tree when the patch reaches it.

Best regards,
Jozsef
-- 
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu
PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics
          H-1525 Budapest 114, POB. 49, Hungary

linux-next: Fixes tag needs some work in the netfilter tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

Hi all,

In commit

  6099505cd2a2 ("netfilter: ipset: Missing gc cancellations fixed")

Fixes tag

  Fixes: fdb8e12cc2cc ("netfilter: ipset: fix performance regression in swap operation")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant:

Fixes: 97f7cf1cd80e ("netfilter: ipset: fix performance regression in swap operation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the netfilter tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

In commit

  22cbdbcfb61a ("netfilter: conntrack: unregister ipv4 sockopts on error unwind")

Fixes tag

  Fixes: a0ae2562c6c ("netfilter: conntrack: remove l3proto abstraction")

has these problem(s):

  - SHA1 should be at least 12 digits long

This is probably not worth rebasing for, but can be avoided in the
future by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the netfilter tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Hi all,

n commit

  4ff6d55abba3 ("netfilter: ctnetlink: Resolve conntrack L3-protocol flush regression")

Fixes tag

  Fixes: 59c08c69c278 ("netfilter: ctnetlink: Support L3 protocol-filter

has these problem(s):

  - Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]