From: Viresh Kumar <viresh.kumar@linaro.org>
To: Jie Deng <jie.deng@intel.com>
Cc: linux-i2c@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, mst@redhat.com, wsa@kernel.org,
jasowang@redhat.com, wsa+renesas@sang-engineering.com,
andriy.shevchenko@linux.intel.com, conghui.chen@intel.com,
arnd@arndb.de, kblaiech@mellanox.com,
jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru,
rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com,
u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org,
yu1.wang@intel.com, shuo.a.liu@intel.com
Subject: Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver
Date: Tue, 2 Mar 2021 10:12:14 +0530 [thread overview]
Message-ID: <20210302044214.gnnce5ptwehrsnpc@vireshk-i7> (raw)
In-Reply-To: <00f826ffe1b6b4f5fb41de2b55ad6b8783b7ff45.1614579846.git.jie.deng@intel.com>
On 01-03-21, 14:41, Jie Deng wrote:
> +static int virtio_i2c_send_reqs(struct virtqueue *vq,
> + struct virtio_i2c_req *reqs,
> + struct i2c_msg *msgs, int nr)
> +{
> + struct scatterlist *sgs[3], out_hdr, msg_buf, in_hdr;
> + int i, outcnt, incnt, err = 0;
> + u8 *buf;
> +
> + for (i = 0; i < nr; i++) {
> + if (!msgs[i].len)
> + break;
> +
> + reqs[i].out_hdr.addr = cpu_to_le16(msgs[i].addr << 1);
And this won't work for 10 bit addressing right? Don't we support that
in kernel ?
From Spec:
\begin{tabular}{ |l||l|l|l|l|l|l|l|l|l|l|l|l|l|l|l|l| }
\hline
Bits & 15 & 14 & 13 & 12 & 11 & 10 & 9 & 8 & 7 & 6 & 5 & 4 & 3 & 2 & 1 & 0 \\
\hline
7-bit address & 0 & 0 & 0 & 0 & 0 & 0 & 0 & 0 & A6 & A5 & A4 & A3 & A2 & A1 & A0 & 0 \\
\hline
10-bit address & A7 & A6 & A5 & A4 & A3 & A2 & A1 & A0 & 1 & 1 & 1 & 1 & 0 & A9 & A8 & 0 \\
\hline
\end{tabular}
--
viresh
next prev parent reply other threads:[~2021-03-02 8:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 6:41 [PATCH v5] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-03-01 11:54 ` Viresh Kumar
2021-03-01 12:09 ` Andy Shevchenko
2021-03-01 12:10 ` Andy Shevchenko
2021-03-01 15:46 ` Arnd Bergmann
2021-03-02 3:46 ` Viresh Kumar
2021-03-02 3:44 ` Viresh Kumar
2021-03-02 2:21 ` Jie Deng
2021-03-02 3:43 ` Viresh Kumar
2021-03-02 6:28 ` Jie Deng
[not found] ` <b99b18e1-06a5-f526-a885-dc663da3612b@intel.com>
2021-03-02 7:24 ` Viresh Kumar
2021-03-02 8:17 ` Jie Deng
2021-03-01 12:07 ` Andy Shevchenko
2021-03-02 7:16 ` Jie Deng
2021-03-01 15:19 ` Arnd Bergmann
2021-03-02 4:01 ` Viresh Kumar
2021-03-02 4:22 ` Viresh Kumar
2021-03-02 5:06 ` Jie Deng
2021-03-02 5:16 ` Viresh Kumar
2021-03-02 5:42 ` Jason Wang
[not found] ` <56fdef9a-b373-32f2-6dac-e687caa813c8@intel.com>
2021-03-02 9:51 ` Stefan Hajnoczi
2021-03-02 10:54 ` Arnd Bergmann
2021-03-03 17:48 ` Stefan Hajnoczi
2021-03-02 4:42 ` Viresh Kumar [this message]
2021-03-02 5:21 ` Jie Deng
2021-03-02 5:25 ` Viresh Kumar
2021-03-03 7:54 ` Viresh Kumar
2021-03-03 8:46 ` Jie Deng
2021-03-03 9:38 ` Viresh Kumar
2021-03-04 1:47 ` Jie Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302044214.gnnce5ptwehrsnpc@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=conghui.chen@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=jie.deng@intel.com \
--cc=kblaiech@mellanox.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mst@redhat.com \
--cc=rppt@kernel.org \
--cc=shuo.a.liu@intel.com \
--cc=tali.perry1@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).