From: Jie Deng <jie.deng@intel.com>
To: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Vincent Guittot" <vincent.guittot@linaro.org>
Cc: linux-i2c@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, mst@redhat.com, wsa@kernel.org,
jasowang@redhat.com, wsa+renesas@sang-engineering.com,
andriy.shevchenko@linux.intel.com, conghui.chen@intel.com,
arnd@arndb.de, kblaiech@mellanox.com,
jarkko.nikula@linux.intel.com, Sergey.Semin@baikalelectronics.ru,
rppt@kernel.org, loic.poulain@linaro.org, tali.perry1@gmail.com,
u.kleine-koenig@pengutronix.de, bjorn.andersson@linaro.org,
yu1.wang@intel.com, shuo.a.liu@intel.com,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH v5] i2c: virtio: add a virtio i2c frontend driver
Date: Wed, 3 Mar 2021 16:46:43 +0800 [thread overview]
Message-ID: <876371c3-ba9a-5176-493b-5a883cba3b07@intel.com> (raw)
In-Reply-To: <20210303075430.n7ewkots6cgbbabi@vireshk-i7>
On 2021/3/3 15:54, Viresh Kumar wrote:
> On 01-03-21, 14:41, Jie Deng wrote:
>> diff --git a/drivers/i2c/busses/i2c-virtio.c b/drivers/i2c/busses/i2c-virtio.c
>> +static int virtio_i2c_send_reqs(struct virtqueue *vq,
>> + struct virtio_i2c_req *reqs,
>> + struct i2c_msg *msgs, int nr)
>> +{
>> + struct scatterlist *sgs[3], out_hdr, msg_buf, in_hdr;
>> + int i, outcnt, incnt, err = 0;
>> + u8 *buf;
>> +
>> + for (i = 0; i < nr; i++) {
>> + if (!msgs[i].len)
>> + break;
>> +
>> + reqs[i].out_hdr.addr = cpu_to_le16(msgs[i].addr << 1);
>> +
>> + if (i != nr - 1)
>> + reqs[i].out_hdr.flags |= VIRTIO_I2C_FLAGS_FAIL_NEXT;
>> +
>> + outcnt = incnt = 0;
>> + sg_init_one(&out_hdr, &reqs[i].out_hdr, sizeof(reqs[i].out_hdr));
>> + sgs[outcnt++] = &out_hdr;
>> +
>> + buf = kzalloc(msgs[i].len, GFP_KERNEL);
>> + if (!buf)
>> + break;
>> +
>> + if (msgs[i].flags & I2C_M_RD) {
>> + reqs[i].read_buf = buf;
>> + sg_init_one(&msg_buf, reqs[i].read_buf, msgs[i].len);
>> + sgs[outcnt + incnt++] = &msg_buf;
>> + } else {
>> + reqs[i].write_buf = buf;
>> + memcpy(reqs[i].write_buf, msgs[i].buf, msgs[i].len);
>> + sg_init_one(&msg_buf, reqs[i].write_buf, msgs[i].len);
>> + sgs[outcnt++] = &msg_buf;
>> + }
>> +
>> + sg_init_one(&in_hdr, &reqs[i].in_hdr, sizeof(reqs[i].in_hdr));
>> + sgs[outcnt + incnt++] = &in_hdr;
>> +
>> + err = virtqueue_add_sgs(vq, sgs, outcnt, incnt, &reqs[i], GFP_KERNEL);
>> + if (err < 0) {
>> + pr_err("failed to add msg[%d] to virtqueue.\n", i);
>> + if (msgs[i].flags & I2C_M_RD) {
>> + kfree(reqs[i].read_buf);
>> + reqs[i].read_buf = NULL;
>> + } else {
>> + kfree(reqs[i].write_buf);
>> + reqs[i].write_buf = NULL;
>> + }
>> + break;
>> + }
>> + }
>> +
>> + return i;
>> +}
>> diff --git a/include/uapi/linux/virtio_i2c.h b/include/uapi/linux/virtio_i2c.h
>> +/**
>> + * struct virtio_i2c_out_hdr - the virtio I2C message OUT header
>> + * @addr: the controlled device address
>> + * @padding: used to pad to full dword
>> + * @flags: used for feature extensibility
>> + */
>> +struct virtio_i2c_out_hdr {
>> + __le16 addr;
>> + __le16 padding;
>> + __le32 flags;
>> +};
> Both this code and the virtio spec (which is already merged) are
> missing msgs[i].flags and they are never sent to backend. The only
> flags available here are the ones defined by virtio spec and these are
> not i2c flags.
>
> I also looked at your i2c backend for acrn and it mistakenly copies
> the hdr.flag, which is the virtio flag and not i2c flag.
>
> https://github.com/projectacrn/acrn-hypervisor/blob/master/devicemodel/hw/pci/virtio/virtio_i2c.c#L539
>
> I will send a fix for the specs if you agree that there is a problem
> here.
>
> what am I missing here ? This should have been caught in your testing
> and so I feel I must be missing something.
This is not a problem. My original proposal was to mirror the struct
i2c_msg.
The code you looked at was based on that.
However, the virtio TC prefer not to mirror it. They have some concerns.
For example, there is a bit I2C_M_RD in i2c_msg.flag which has the same
meaning with
the R/W in virtio descriptor. This is a repetition which may cause problems.
So the virtio_i2c_out_hdr.flags is used to instead of i2c_msg.flags for
extension.
You can check this link
https://github.com/oasis-tcs/virtio-spec/issues/88 to learn the whole story.
There are discussions about the spec (v1 ~ v7).
I'm updating these drivers step by step to make sure they finally follow
the spec.
next prev parent reply other threads:[~2021-03-03 15:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 6:41 [PATCH v5] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-03-01 11:54 ` Viresh Kumar
2021-03-01 12:09 ` Andy Shevchenko
2021-03-01 12:10 ` Andy Shevchenko
2021-03-01 15:46 ` Arnd Bergmann
2021-03-02 3:46 ` Viresh Kumar
2021-03-02 3:44 ` Viresh Kumar
2021-03-02 2:21 ` Jie Deng
2021-03-02 3:43 ` Viresh Kumar
2021-03-02 6:28 ` Jie Deng
[not found] ` <b99b18e1-06a5-f526-a885-dc663da3612b@intel.com>
2021-03-02 7:24 ` Viresh Kumar
2021-03-02 8:17 ` Jie Deng
2021-03-01 12:07 ` Andy Shevchenko
2021-03-02 7:16 ` Jie Deng
2021-03-01 15:19 ` Arnd Bergmann
2021-03-02 4:01 ` Viresh Kumar
2021-03-02 4:22 ` Viresh Kumar
2021-03-02 5:06 ` Jie Deng
2021-03-02 5:16 ` Viresh Kumar
2021-03-02 5:42 ` Jason Wang
[not found] ` <56fdef9a-b373-32f2-6dac-e687caa813c8@intel.com>
2021-03-02 9:51 ` Stefan Hajnoczi
2021-03-02 10:54 ` Arnd Bergmann
2021-03-03 17:48 ` Stefan Hajnoczi
2021-03-02 4:42 ` Viresh Kumar
2021-03-02 5:21 ` Jie Deng
2021-03-02 5:25 ` Viresh Kumar
2021-03-03 7:54 ` Viresh Kumar
2021-03-03 8:46 ` Jie Deng [this message]
2021-03-03 9:38 ` Viresh Kumar
2021-03-04 1:47 ` Jie Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876371c3-ba9a-5176-493b-5a883cba3b07@intel.com \
--to=jie.deng@intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=alex.bennee@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=conghui.chen@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=kblaiech@mellanox.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mst@redhat.com \
--cc=rppt@kernel.org \
--cc=shuo.a.liu@intel.com \
--cc=stefanha@redhat.com \
--cc=tali.perry1@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).