* [PATCH -next] afs: Remove unused variable in afs_req_issue_op()
@ 2021-03-03 6:40 Wei Yongjun
2021-03-03 8:23 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2021-03-03 6:40 UTC (permalink / raw)
To: Hulk Robot, David Howells
Cc: Wei Yongjun, linux-afs, linux-kernel, kernel-janitors
GCC reports the following warning with W=1:
fs/afs/file.c:291:6: warning:
unused variable 'ret' [-Wunused-variable]
291 | int ret;
| ^~~
After commit 799fbdf96cd51, this variable is not used in function
afs_req_issue_op(), so this commit remove it to fix the warning.
Fixes: 799fbdf96cd51 ("afs: Use new fscache read helper API")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
fs/afs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/afs/file.c b/fs/afs/file.c
index af162d7dab5b..cf2b664a68a5 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -288,7 +288,6 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
{
struct afs_vnode *vnode = AFS_FS_I(subreq->rreq->inode);
struct afs_read *fsreq;
- int ret;
fsreq = afs_alloc_read(GFP_NOFS);
if (!fsreq)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] afs: Remove unused variable in afs_req_issue_op()
2021-03-03 6:40 [PATCH -next] afs: Remove unused variable in afs_req_issue_op() Wei Yongjun
@ 2021-03-03 8:23 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2021-03-03 8:23 UTC (permalink / raw)
To: Wei Yongjun
Cc: dhowells, Hulk Robot, linux-afs, linux-kernel, kernel-janitors
Wei Yongjun <weiyongjun1@huawei.com> wrote:
> GCC reports the following warning with W=1:
>
> fs/afs/file.c:291:6: warning:
> unused variable 'ret' [-Wunused-variable]
> 291 | int ret;
> | ^~~
>
> After commit 799fbdf96cd51, this variable is not used in function
> afs_req_issue_op(), so this commit remove it to fix the warning.
>
> Fixes: 799fbdf96cd51 ("afs: Use new fscache read helper API")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I've already fixed that and updated my branch, thanks. linux-next should pick
it up on the next merging.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-03 15:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 6:40 [PATCH -next] afs: Remove unused variable in afs_req_issue_op() Wei Yongjun
2021-03-03 8:23 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).