* [PATCH] powerpc: remove redundant space
@ 2021-03-03 11:57 maqiang
2021-03-03 21:33 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: maqiang @ 2021-03-03 11:57 UTC (permalink / raw)
To: mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel, maqiang
These one line of code don't meet the kernel coding style,
so remove the redundant space.
Signed-off-by: maqiang <maqianga@uniontech.com>
---
arch/powerpc/kernel/syscalls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
index 078608ec2e92..9248288752d5 100644
--- a/arch/powerpc/kernel/syscalls.c
+++ b/arch/powerpc/kernel/syscalls.c
@@ -81,7 +81,7 @@ SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
int
ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user *exp, struct __kernel_old_timeval __user *tvp)
{
- if ( (unsigned long)n >= 4096 )
+ if ((unsigned long)n >= 4096)
{
unsigned long __user *buffer = (unsigned long __user *)n;
if (!access_ok(buffer, 5*sizeof(unsigned long))
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: remove redundant space
2021-03-03 11:57 [PATCH] powerpc: remove redundant space maqiang
@ 2021-03-03 21:33 ` Christophe Leroy
0 siblings, 0 replies; 3+ messages in thread
From: Christophe Leroy @ 2021-03-03 21:33 UTC (permalink / raw)
To: maqiang; +Cc: linux-kernel, linuxppc-dev, paulus, benh, mpe
maqiang <maqianga@uniontech.com> a écrit :
> These one line of code don't meet the kernel coding style,
> so remove the redundant space.
There seems to be several other style issues in this function and in
the following one too. You should fix them all at once I think.
>
> Signed-off-by: maqiang <maqianga@uniontech.com>
> ---
> arch/powerpc/kernel/syscalls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
> index 078608ec2e92..9248288752d5 100644
> --- a/arch/powerpc/kernel/syscalls.c
> +++ b/arch/powerpc/kernel/syscalls.c
> @@ -81,7 +81,7 @@ SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
> int
> ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set
> __user *exp, struct __kernel_old_timeval __user *tvp)
> {
> - if ( (unsigned long)n >= 4096 )
> + if ((unsigned long)n >= 4096)
> {
> unsigned long __user *buffer = (unsigned long __user *)n;
> if (!access_ok(buffer, 5*sizeof(unsigned long))
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] powerpc: remove redundant space
@ 2022-09-06 15:32 Jingyu Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jingyu Wang @ 2022-09-06 15:32 UTC (permalink / raw)
To: mpe, npiggin, christophe.leroy; +Cc: linuxppc-dev, linux-kernel, Jingyu Wang
This commit remmove redundant space in arch/powerpc/sysdev/mmio_nvram.c
Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
---
arch/powerpc/sysdev/mmio_nvram.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/sysdev/mmio_nvram.c b/arch/powerpc/sysdev/mmio_nvram.c
index eb48210ef98e..cc15b161ada6 100644
--- a/arch/powerpc/sysdev/mmio_nvram.c
+++ b/arch/powerpc/sysdev/mmio_nvram.c
@@ -35,7 +35,7 @@ static ssize_t mmio_nvram_read(char *buf, size_t count, loff_t *index)
memcpy_fromio(buf, mmio_nvram_start + *index, count);
spin_unlock_irqrestore(&mmio_nvram_lock, flags);
-
+
*index += count;
return count;
}
@@ -71,7 +71,7 @@ static ssize_t mmio_nvram_write(char *buf, size_t count, loff_t *index)
memcpy_toio(mmio_nvram_start + *index, buf, count);
spin_unlock_irqrestore(&mmio_nvram_lock, flags);
-
+
*index += count;
return count;
}
@@ -117,7 +117,7 @@ int __init mmio_nvram_init(void)
}
nvram_addr = r.start;
mmio_nvram_len = resource_size(&r);
- if ( (!mmio_nvram_len) || (!nvram_addr) ) {
+ if ((!mmio_nvram_len) || (!nvram_addr)) {
printk(KERN_WARNING "nvram: address or length is 0\n");
ret = -EIO;
goto out;
base-commit: e47eb90a0a9ae20b82635b9b99a8d0979b757ad8
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-06 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 11:57 [PATCH] powerpc: remove redundant space maqiang
2021-03-03 21:33 ` Christophe Leroy
2022-09-06 15:32 Jingyu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).