* [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()
@ 2021-03-05 16:26 Denis Efremov
2021-03-05 21:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2021-03-05 16:26 UTC (permalink / raw)
To: Andreas Koensgen
Cc: Denis Efremov, David S. Miller, Jakub Kicinski, linux-hams,
netdev, linux-kernel
"len > sp->mtu" checked twice in a row in sp_encaps().
Remove the second check.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
drivers/net/hamradio/6pack.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 71d6629e65c9..9f5b5614a150 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -171,11 +171,6 @@ static void sp_encaps(struct sixpack *sp, unsigned char *icp, int len)
goto out_drop;
}
- if (len > sp->mtu) { /* sp->mtu = AX25_MTU = max. PACLEN = 256 */
- msg = "oversized transmit packet!";
- goto out_drop;
- }
-
if (p[0] > 5) {
msg = "invalid KISS command";
goto out_drop;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()
2021-03-05 16:26 [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps() Denis Efremov
@ 2021-03-05 21:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-05 21:10 UTC (permalink / raw)
To: Denis Efremov; +Cc: ajk, davem, kuba, linux-hams, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 5 Mar 2021 19:26:22 +0300 you wrote:
> "len > sp->mtu" checked twice in a row in sp_encaps().
> Remove the second check.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
> ---
> drivers/net/hamradio/6pack.c | 5 -----
> 1 file changed, 5 deletions(-)
Here is the summary with links:
- net/hamradio/6pack: remove redundant check in sp_encaps()
https://git.kernel.org/netdev/net/c/85554bcd123e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-05 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 16:26 [PATCH] net/hamradio/6pack: remove redundant check in sp_encaps() Denis Efremov
2021-03-05 21:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).