From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: cohuck@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, peterx@redhat.com
Subject: Re: [PATCH v1 06/14] vfio: Add vma to pfn callback
Date: Mon, 8 Mar 2021 20:33:44 -0400 [thread overview]
Message-ID: <20210309003344.GC4247@nvidia.com> (raw)
In-Reply-To: <161524009646.3480.6519905534709638083.stgit@gimli.home>
On Mon, Mar 08, 2021 at 02:48:16PM -0700, Alex Williamson wrote:
> Add a new vfio_device_ops callback to allow the bus driver to
> translate a vma mapping of a vfio device fd to a pfn. Plumb through
> vfio-core. Implemented for vfio-pci.
>
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> drivers/vfio/pci/vfio_pci.c | 1 +
> drivers/vfio/vfio.c | 16 ++++++++++++++++
> include/linux/vfio.h | 3 +++
> 3 files changed, 20 insertions(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index 415b5109da9b..585895970e9c 100644
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -1756,6 +1756,7 @@ static const struct vfio_device_ops vfio_pci_ops = {
> .mmap = vfio_pci_mmap,
> .request = vfio_pci_request,
> .match = vfio_pci_match,
> + .vma_to_pfn = vfio_pci_bar_vma_to_pfn,
> };
>
> static int vfio_pci_reflck_attach(struct vfio_pci_device *vdev);
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 3a3e85a0dc3e..c47895539a1a 100644
> +++ b/drivers/vfio/vfio.c
> @@ -944,6 +944,22 @@ struct vfio_device *vfio_device_get_from_vma(struct vm_area_struct *vma)
> }
> EXPORT_SYMBOL_GPL(vfio_device_get_from_vma);
>
> +int vfio_vma_to_pfn(struct vm_area_struct *vma, unsigned long *pfn)
> +{
> + struct vfio_device *device;
> +
> + if (!vma->vm_file || vma->vm_file->f_op != &vfio_device_fops)
> + return -EINVAL;
> +
> + device = vma->vm_file->private_data;
Since the caller has the vfio_device already I would pass in the
vfio_device here rather than look it up again.
If you are really worried about API mis-use then use a protective
assertion like this:
if (WARN_ON(vma->vm_file->private_data != device))
return -EINVAL;
Jason
next prev parent reply other threads:[~2021-03-09 0:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 21:47 [PATCH v1 00/14] vfio: Device memory DMA mapping improvements Alex Williamson
2021-03-08 21:47 ` [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device Alex Williamson
2021-03-09 8:36 ` Christoph Hellwig
2021-04-09 4:54 ` 答复: " Zengtao (B)
2021-04-09 14:24 ` Alex Williamson
2021-04-09 17:32 ` Jason Gunthorpe
2021-04-12 4:03 ` 答复: " Zengtao (B)
2021-04-12 4:09 ` Zengtao (B)
2021-03-08 21:47 ` [PATCH v1 02/14] vfio: Update vfio_add_group_dev() API Alex Williamson
2021-03-10 7:48 ` Christoph Hellwig
2021-03-10 12:19 ` Jason Gunthorpe
2021-03-10 15:28 ` Alex Williamson
2021-03-11 11:23 ` Christoph Hellwig
2021-03-08 21:47 ` [PATCH v1 03/14] vfio: Export unmap_mapping_range() wrapper Alex Williamson
2021-03-08 21:48 ` [PATCH v1 04/14] vfio/pci: Use vfio_device_unmap_mapping_range() Alex Williamson
2021-03-08 21:48 ` [PATCH v1 05/14] vfio: Create a vfio_device from vma lookup Alex Williamson
2021-03-08 21:48 ` [PATCH v1 06/14] vfio: Add vma to pfn callback Alex Williamson
2021-03-09 0:33 ` Jason Gunthorpe [this message]
2021-03-08 21:48 ` [PATCH v1 07/14] vfio: Add a device notifier interface Alex Williamson
2021-03-09 0:46 ` Jason Gunthorpe
2021-03-09 15:45 ` Alex Williamson
2021-03-09 16:47 ` Jason Gunthorpe
2021-03-10 7:56 ` Christoph Hellwig
2021-03-19 22:25 ` Alex Williamson
2021-03-22 15:16 ` Christoph Hellwig
2021-03-08 21:48 ` [PATCH v1 08/14] vfio/pci: Notify on device release Alex Williamson
2021-03-08 21:48 ` [PATCH v1 09/14] vfio/type1: Refactor pfn_list clearing Alex Williamson
2021-03-10 8:01 ` Christoph Hellwig
2021-03-08 21:49 ` [PATCH v1 10/14] vfio/type1: Pass iommu and dma objects through to vaddr_get_pfn Alex Williamson
2021-03-08 21:49 ` [PATCH v1 11/14] vfio/type1: Register device notifier Alex Williamson
2021-03-10 8:03 ` Christoph Hellwig
2021-03-08 21:49 ` [PATCH v1 12/14] vfio/type1: Support batching of device mappings Alex Williamson
2021-03-09 1:04 ` Jason Gunthorpe
2021-03-08 21:49 ` [PATCH v1 13/14] vfio: Remove extern from declarations across vfio Alex Williamson
2021-03-09 0:21 ` Halil Pasic
2021-03-09 1:07 ` Jason Gunthorpe
2021-03-08 21:49 ` [PATCH v1 14/14] vfio: Cleanup use of bare unsigned Alex Williamson
2021-03-09 1:07 ` Jason Gunthorpe
2021-03-09 8:31 ` Christoph Hellwig
2021-03-09 1:06 ` [PATCH v1 00/14] vfio: Device memory DMA mapping improvements Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309003344.GC4247@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).